DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kinsella, Ray" <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>,
	Rahul Shah <rahul.r.shah@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted
Date: Fri, 10 Sep 2021 14:40:53 +0100	[thread overview]
Message-ID: <afc00cae-3616-870b-c727-f26e34bf977a@ashroe.eu> (raw)
In-Reply-To: <CAJFAV8xA2Yc3uFXROYnpisp3R4vhudqzwi2S-FGUQXgUoW38Hw@mail.gmail.com>



On 10/09/2021 08:36, David Marchand wrote:
> On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray <mdr@ashroe.eu> wrote:
>> On 09/09/2021 17:40, Rahul Shah wrote:
>>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops,
>>> rte_port_eventdev_writer_ops symbols promoted
>>>
>>> Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
>>> ---
>>>  lib/port/version.map | 8 +++-----
>>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>>
>>
>> Hi Rahul,
>>
>> You need to strip the __rte_experimental attribute in the header file also.
> 
> That's what I first thought... but those are variables, and there were
> not marked in the header.

My mistake - should have checked.

> At least, those symbols must be alphabetically sorted in version.map.
> 
> 
> About checking for experimental mark on variables... I had a patch,
> but never got it in.
> I think we should instead (forbid such exports and|insist on) rework
> API / libraries that rely on public variables.
>

I'll pull together a script to identify all the variables in DPDK.
Are you expecting the rework on the port api to be done prior to 21.11?

Ray K
 

  reply	other threads:[~2021-09-10 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 16:40 Rahul Shah
2021-09-10  7:30 ` Kinsella, Ray
2021-09-10  7:36   ` David Marchand
2021-09-10 13:40     ` Kinsella, Ray [this message]
2021-10-13 12:12       ` Thomas Monjalon
2021-10-20  9:55         ` Kinsella, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afc00cae-3616-870b-c727-f26e34bf977a@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=rahul.r.shah@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).