From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC0FCA0547; Fri, 10 Sep 2021 15:41:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7E754112E; Fri, 10 Sep 2021 15:41:04 +0200 (CEST) Received: from mail-108-mta154.mxroute.com (mail-108-mta154.mxroute.com [136.175.108.154]) by mails.dpdk.org (Postfix) with ESMTP id 8680241104 for ; Fri, 10 Sep 2021 15:41:02 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta154.mxroute.com (ZoneMTA) with ESMTPSA id 17bcff09a8f00074ba.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 10 Sep 2021 13:40:57 +0000 X-Zone-Loop: f3daf9c65ddf6c0eb2e8e380400526e7bff93de63c11 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/2J2sFmmRMkfPWNW2wYRVEzA3DNJZHtxbM8Ngy3fGIU=; b=NejkR+sCc5pgb+EqHOFtz2lPeT fP2lI3jVxi91W/aXtC8f8JAjgA8tDjpeaSLHn8pbD4fLuzCh1GmBoYCnMWQOseCGKMsVoM5l+y0w6 8mcHeLKGiRWht49Bz0atNtAujdN+PjyeJbtyqveWJ993xAcA+qtty6z7w+1nom+hhmKZK6e3gaCDR eI98diwWN0YtePParTne5KseSpv6NT5PGlxxCERjqlVnaFv8Yohn0aixByQ+140+kKgxbf440JM2S lLKXHjjFo22MS6YdIcHkxVQjXK8D7wCmm5mPoWW40jyCgLqeMA+mmhAnWdGVIX2ub+dn/JxXhP2Ra 2Q36XAOA==; To: David Marchand , Rahul Shah Cc: dev References: <20210909164008.343712-1-rahul.r.shah@intel.com> <55677da6-68cf-eb65-e5bb-004a4bf970c5@ashroe.eu> From: "Kinsella, Ray" Message-ID: Date: Fri, 10 Sep 2021 14:40:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH] port: eventdev port api promoted X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/09/2021 08:36, David Marchand wrote: > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: >> On 09/09/2021 17:40, Rahul Shah wrote: >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, >>> rte_port_eventdev_writer_ops symbols promoted >>> >>> Signed-off-by: Rahul Shah >>> --- >>> lib/port/version.map | 8 +++----- >>> 1 file changed, 3 insertions(+), 5 deletions(-) >>> >> >> Hi Rahul, >> >> You need to strip the __rte_experimental attribute in the header file also. > > That's what I first thought... but those are variables, and there were > not marked in the header. My mistake - should have checked. > At least, those symbols must be alphabetically sorted in version.map. > > > About checking for experimental mark on variables... I had a patch, > but never got it in. > I think we should instead (forbid such exports and|insist on) rework > API / libraries that rely on public variables. > I'll pull together a script to identify all the variables in DPDK. Are you expecting the rework on the port api to be done prior to 21.11? Ray K