From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6FFAD1BA03 for ; Thu, 26 Oct 2017 00:01:11 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 25 Oct 2017 15:01:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,433,1503385200"; d="scan'208";a="167629742" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.45]) ([10.241.225.45]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2017 15:01:09 -0700 To: Tomasz Kulasek , dev@dpdk.org Cc: declan.doherty@intel.com References: <20171020154926.13452-1-tomaszx.kulasek@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 25 Oct 2017 15:01:09 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171020154926.13452-1-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix check slaves link properties X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 22:01:11 -0000 On 10/20/2017 8:49 AM, Tomasz Kulasek wrote: > Result of slaves link properties validation is not used when new slave > is added. > > This patch uses the value of link_properties_valid() to determinate if > slave can be used in the bonding. If function fails, error is returned > preventing to add slave with invalid link properties. > > Coverity issue: 158661 > Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") Cc: stable@dpdk.org > Signed-off-by: Tomasz Kulasek Reviewed-by: Ferruh Yigit