* [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure @ 2017-02-10 11:39 Fan Zhang 2017-02-10 13:59 ` Trahe, Fiona 2017-02-14 10:41 ` [dpdk-dev] [PATCH v2] " Fan Zhang 0 siblings, 2 replies; 10+ messages in thread From: Fan Zhang @ 2017-02-10 11:39 UTC (permalink / raw) To: dev; +Cc: pablo.de.lara.guarch Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> --- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 755dc65..564d93a 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -62,3 +62,7 @@ Deprecation Notices PMDs that implement the latter. Target release for removal of the legacy API will be defined once most PMDs have switched to rte_flow. + +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` structure. + The field ``cryptodev_configure_t`` function prototype will be added a + parameter of a struct rte_cryptodev_config type pointer. -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure 2017-02-10 11:39 [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure Fan Zhang @ 2017-02-10 13:59 ` Trahe, Fiona 2017-02-13 16:07 ` Zhang, Roy Fan 2017-02-14 0:21 ` Hemant Agrawal 2017-02-14 10:41 ` [dpdk-dev] [PATCH v2] " Fan Zhang 1 sibling, 2 replies; 10+ messages in thread From: Trahe, Fiona @ 2017-02-10 13:59 UTC (permalink / raw) To: Zhang, Roy Fan, dev; +Cc: De Lara Guarch, Pablo, Trahe, Fiona Hi Fan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > Sent: Friday, February 10, 2017 11:39 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 755dc65..564d93a 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -62,3 +62,7 @@ Deprecation Notices > PMDs that implement the latter. > Target release for removal of the legacy API will be defined once most > PMDs have switched to rte_flow. > + > +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` structure. > + The field ``cryptodev_configure_t`` function prototype will be added a > + parameter of a struct rte_cryptodev_config type pointer. > -- > 2.7.4 Can you fix the grammar here please. I'm not sure what the change is? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure 2017-02-10 13:59 ` Trahe, Fiona @ 2017-02-13 16:07 ` Zhang, Roy Fan 2017-02-13 17:34 ` Trahe, Fiona 2017-02-14 0:21 ` Hemant Agrawal 1 sibling, 1 reply; 10+ messages in thread From: Zhang, Roy Fan @ 2017-02-13 16:07 UTC (permalink / raw) To: Trahe, Fiona, dev; +Cc: De Lara Guarch, Pablo Hi Fiona, Sorry for my bad English, I will try to explain better here. "cryptodev_configure_t" is a function prototype with only "rte_cryptodev *dev" as sole parameter. Structure ``rte_cryptodev_ops`` holds one function pointer "dev_configure" of it. The patch involves in the announcement of adding a parameter of "struct rte_cryptodev_config" pointer so the function prototype could look like: typedef int (*cryptodev_configure_t)(struct rte_cryptodev *dev, struct rte_cryptodev_config *config); Without this parameter, a specific crypto PMD may not have enough information to configure itself. Which may not be big problem as other Cryptodevs as all configures are done in rte_cryptodev_configure(), but it is important for the scheduler PMD as it needs this parameter to configure all its slaves. Currently the user have to configure every slave one by one. The problem is, although I want to change an API of the function prototype "cryptodev_configure_t", but in order to do that I have to break the ABI of structure "rte_cryptodev_ops". Any help on the grammar for stating this nicer would be appreciated. Best regards, Fan > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, February 10, 2017 2:00 PM > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona > <fiona.trahe@intel.com> > Subject: RE: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure > > Hi Fan, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > Sent: Friday, February 10, 2017 11:39 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > > Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > > structure > > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 755dc65..564d93a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -62,3 +62,7 @@ Deprecation Notices > > PMDs that implement the latter. > > Target release for removal of the legacy API will be defined once most > > PMDs have switched to rte_flow. > > + > > +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` structure. > > + The field ``cryptodev_configure_t`` function prototype will be > > +added a > > + parameter of a struct rte_cryptodev_config type pointer. > > -- > > 2.7.4 > > Can you fix the grammar here please. I'm not sure what the change is? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure 2017-02-13 16:07 ` Zhang, Roy Fan @ 2017-02-13 17:34 ` Trahe, Fiona 0 siblings, 0 replies; 10+ messages in thread From: Trahe, Fiona @ 2017-02-13 17:34 UTC (permalink / raw) To: Zhang, Roy Fan, dev; +Cc: De Lara Guarch, Pablo Thanks Fan, now it makes sense. > -----Original Message----- > From: Zhang, Roy Fan > Sent: Monday, February 13, 2017 4:07 PM > To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Subject: RE: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure > > Hi Fiona, > > Sorry for my bad English, I will try to explain better here. > > "cryptodev_configure_t" is a function prototype with only "rte_cryptodev > *dev" > as sole parameter. Structure ``rte_cryptodev_ops`` holds one function pointer > "dev_configure" of it. > > The patch involves in the announcement of adding a parameter of > "struct rte_cryptodev_config" pointer so the function prototype could look > like: > > typedef int (*cryptodev_configure_t)(struct rte_cryptodev *dev, struct > rte_cryptodev_config *config); > > Without this parameter, a specific crypto PMD may not have enough > information to > configure itself. Which may not be big problem as other Cryptodevs as all > configures > are done in rte_cryptodev_configure(), but it is important for the scheduler > PMD as it > needs this parameter to configure all its slaves. Currently the user have to > configure > every slave one by one. > > The problem is, although I want to change an API of the function prototype > "cryptodev_configure_t", > but in order to do that I have to break the ABI of structure > "rte_cryptodev_ops". Any help on the grammar > for stating this nicer would be appreciated. > > Best regards, > Fan > > > > > > -----Original Message----- > > From: Trahe, Fiona > > Sent: Friday, February 10, 2017 2:00 PM > > To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona > > <fiona.trahe@intel.com> > > Subject: RE: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > > structure > > > > Hi Fan, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > > Sent: Friday, February 10, 2017 11:39 AM > > > To: dev@dpdk.org > > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > > > Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > > > structure > > > > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > > > --- > > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > b/doc/guides/rel_notes/deprecation.rst > > > index 755dc65..564d93a 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -62,3 +62,7 @@ Deprecation Notices > > > PMDs that implement the latter. > > > Target release for removal of the legacy API will be defined once most > > > PMDs have switched to rte_flow. > > > + > > > +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` > structure. > > > + The field ``cryptodev_configure_t`` function prototype will be > > > +added a > > > + parameter of a struct rte_cryptodev_config type pointer. > > > -- > > > 2.7.4 > > > > Can you fix the grammar here please. I'm not sure what the change is? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure 2017-02-10 13:59 ` Trahe, Fiona 2017-02-13 16:07 ` Zhang, Roy Fan @ 2017-02-14 0:21 ` Hemant Agrawal 2017-02-14 5:11 ` Hemant Agrawal 1 sibling, 1 reply; 10+ messages in thread From: Hemant Agrawal @ 2017-02-14 0:21 UTC (permalink / raw) To: Trahe, Fiona, Zhang, Roy Fan, dev; +Cc: De Lara Guarch, Pablo On 2/10/2017 7:59 AM, Trahe, Fiona wrote: > Hi Fan, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang >> Sent: Friday, February 10, 2017 11:39 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> >> Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops >> structure >> >> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> >> --- >> doc/guides/rel_notes/deprecation.rst | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index 755dc65..564d93a 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -62,3 +62,7 @@ Deprecation Notices >> PMDs that implement the latter. >> Target release for removal of the legacy API will be defined once most >> PMDs have switched to rte_flow. >> + >> +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` structure. >> + The field ``cryptodev_configure_t`` function prototype will be added a >> + parameter of a struct rte_cryptodev_config type pointer. >> -- >> 2.7.4 > > Can you fix the grammar here please. I'm not sure what the change is? > I also find it hard to understand it first. Not perfect, but I tried to reword it. A new parameter ``struct rte_cryptodev_config *config`` will be added to the ``cryptodev_configure_t`` function pointer field. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure 2017-02-14 0:21 ` Hemant Agrawal @ 2017-02-14 5:11 ` Hemant Agrawal 0 siblings, 0 replies; 10+ messages in thread From: Hemant Agrawal @ 2017-02-14 5:11 UTC (permalink / raw) To: Hemant Agrawal, Trahe, Fiona, Zhang, Roy Fan, dev; +Cc: De Lara Guarch, Pablo > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Monday, February 13, 2017 6:21 PM > To: Trahe, Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan > <roy.fan.zhang@intel.com>; dev@dpdk.org > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > Subject: Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure > > On 2/10/2017 7:59 AM, Trahe, Fiona wrote: > > Hi Fan, > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > >> Sent: Friday, February 10, 2017 11:39 AM > >> To: dev@dpdk.org > >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com> > >> Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > >> structure > >> > >> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > >> --- > >> doc/guides/rel_notes/deprecation.rst | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/doc/guides/rel_notes/deprecation.rst > >> b/doc/guides/rel_notes/deprecation.rst > >> index 755dc65..564d93a 100644 > >> --- a/doc/guides/rel_notes/deprecation.rst > >> +++ b/doc/guides/rel_notes/deprecation.rst > >> @@ -62,3 +62,7 @@ Deprecation Notices > >> PMDs that implement the latter. > >> Target release for removal of the legacy API will be defined once most > >> PMDs have switched to rte_flow. > >> + > >> +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` > structure. > >> + The field ``cryptodev_configure_t`` function prototype will be > >> +added a > >> + parameter of a struct rte_cryptodev_config type pointer. > >> -- > >> 2.7.4 > > > > Can you fix the grammar here please. I'm not sure what the change is? > > > I also find it hard to understand it first. Not perfect, but I tried to reword it. > > A new parameter ``struct rte_cryptodev_config *config`` will be added to the > ``cryptodev_configure_t`` function pointer field. > In any case, Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev ops structure 2017-02-10 11:39 [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure Fan Zhang 2017-02-10 13:59 ` Trahe, Fiona @ 2017-02-14 10:41 ` Fan Zhang 2017-02-14 10:48 ` Doherty, Declan 2017-02-14 20:37 ` Thomas Monjalon 1 sibling, 2 replies; 10+ messages in thread From: Fan Zhang @ 2017-02-14 10:41 UTC (permalink / raw) To: dev; +Cc: declan.doherty Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> --- v2: Rework the grammar doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index b49e0a0..d64858f 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -62,3 +62,7 @@ Deprecation Notices PMDs that implement the latter. Target release for removal of the legacy API will be defined once most PMDs have switched to rte_flow. + +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` structure. + A pointer to a rte_cryptodev_config structure will be added to the + function prototype "cryptodev_configuret_t, as a new parameter. -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev ops structure 2017-02-14 10:41 ` [dpdk-dev] [PATCH v2] " Fan Zhang @ 2017-02-14 10:48 ` Doherty, Declan 2017-02-14 11:03 ` De Lara Guarch, Pablo 2017-02-14 20:37 ` Thomas Monjalon 1 sibling, 1 reply; 10+ messages in thread From: Doherty, Declan @ 2017-02-14 10:48 UTC (permalink / raw) To: Fan Zhang, dev On 14/02/2017 10:41 AM, Fan Zhang wrote: > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > --- ... > Acked-by: Declan Doherty <declan.doherty@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev ops structure 2017-02-14 10:48 ` Doherty, Declan @ 2017-02-14 11:03 ` De Lara Guarch, Pablo 0 siblings, 0 replies; 10+ messages in thread From: De Lara Guarch, Pablo @ 2017-02-14 11:03 UTC (permalink / raw) To: Doherty, Declan, Zhang, Roy Fan, dev > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Doherty, Declan > Sent: Tuesday, February 14, 2017 10:48 AM > To: Zhang, Roy Fan; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev > ops structure > > On 14/02/2017 10:41 AM, Fan Zhang wrote: > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com> > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> > > --- > ... > > > > Acked-by: Declan Doherty <declan.doherty@intel.com> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: annouce ABI change for cryptodev ops structure 2017-02-14 10:41 ` [dpdk-dev] [PATCH v2] " Fan Zhang 2017-02-14 10:48 ` Doherty, Declan @ 2017-02-14 20:37 ` Thomas Monjalon 1 sibling, 0 replies; 10+ messages in thread From: Thomas Monjalon @ 2017-02-14 20:37 UTC (permalink / raw) To: Fan Zhang; +Cc: dev Applied ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-02-14 20:37 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-02-10 11:39 [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure Fan Zhang 2017-02-10 13:59 ` Trahe, Fiona 2017-02-13 16:07 ` Zhang, Roy Fan 2017-02-13 17:34 ` Trahe, Fiona 2017-02-14 0:21 ` Hemant Agrawal 2017-02-14 5:11 ` Hemant Agrawal 2017-02-14 10:41 ` [dpdk-dev] [PATCH v2] " Fan Zhang 2017-02-14 10:48 ` Doherty, Declan 2017-02-14 11:03 ` De Lara Guarch, Pablo 2017-02-14 20:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).