From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58B3BA0548; Tue, 27 Apr 2021 14:31:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEA4640150; Tue, 27 Apr 2021 14:31:22 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 0CD914014E for ; Tue, 27 Apr 2021 14:31:21 +0200 (CEST) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FV1JC0bymzPtCP for ; Tue, 27 Apr 2021 20:28:11 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Tue, 27 Apr 2021 20:31:12 +0800 To: Ferruh Yigit , References: <1619056552-43937-4-git-send-email-humin29@huawei.com> <1619444548-24977-1-git-send-email-humin29@huawei.com> <2c07eb7c-9383-294e-b7bc-efc7bea1aa1f@intel.com> From: "Min Hu (Connor)" Message-ID: Date: Tue, 27 Apr 2021 20:31:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <2c07eb7c-9383-294e-b7bc-efc7bea1aa1f@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: fix parse link fails code fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/27 19:11, Ferruh Yigit 写道: > On 4/26/2021 2:42 PM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> The link fails code should be parsed using the structure >> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >> >> Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengwen Feng >> Signed-off-by: Min Hu (Connor) >> --- >> v2: >> * kept original API interface. >> --- >> drivers/net/hns3/hns3_mbx.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c >> index eb202dd..755298f 100644 >> --- a/drivers/net/hns3/hns3_mbx.c >> +++ b/drivers/net/hns3/hns3_mbx.c >> @@ -346,12 +346,20 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code) >> } >> >> static void >> + >> hns3pf_handle_link_change_event(struct hns3_hw *hw, >> - struct hns3_mbx_pf_to_vf_cmd *req) >> + struct hns3_mbx_pf_to_vf_cmd *cmd) >> { >> #define LINK_STATUS_OFFSET 1 >> #define LINK_FAIL_CODE_OFFSET 2 >> >> + /* >> + * This message is reported by the firmware and is reported in >> + * 'struct hns3_mbx_vf_to_pf_cmd' format. Therefore, we should cast >> + * the cmd to 'struct hns3_mbx_vf_to_pf_cmd' first. >> + */ >> + struct hns3_mbx_vf_to_pf_cmd *req = (struct hns3_mbx_vf_to_pf_cmd *)cmd; >> + > > Hi Connor, > > I guess I am missing something obvious, why not get the parameter as 'struct > hns3_mbx_vf_to_pf_cmd' at first place? > . Hi, fixed in v3, thanks. >