From: Thomas Gleixner <tglx@linutronix.de>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Andy Lutomirski <luto@kernel.org>,
dev@dpdk.org, Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [dpdk-dev] Please stop using iopl() in DPDK
Date: Fri, 25 Oct 2019 22:43:54 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1910252232590.1905@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20191025091310.05770edc@hermes.lan>
On Fri, 25 Oct 2019, Stephen Hemminger wrote:
> On Thu, 24 Oct 2019 21:45:56 -0700
> Andy Lutomirski <luto@kernel.org> wrote:
> > 3. Use ioperm() instead of iopl().
>
> Ioperm has the wrong thread semantics. All DPDK applications have
> multiple threads and the initialization logic needs to work even
> if the thread is started later; threads can also be started by
> the user application.
>
> Iopl applies to whole process so this is not an issue.
No. iopl is also per thread and not per process. That has been that way
forever. The man page is blantantly wrong.
Both iopl and ioperm are inherited on fork.
Thanks,
tglx
next prev parent reply other threads:[~2019-10-27 22:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 4:45 Andy Lutomirski
2019-10-25 6:42 ` Willy Tarreau
2019-10-25 14:45 ` Andy Lutomirski
2019-10-25 15:03 ` Willy Tarreau
2019-10-27 23:44 ` Maciej W. Rozycki
2019-10-28 16:42 ` Stephen Hemminger
2019-10-28 18:00 ` Andy Lutomirski
2019-10-28 20:13 ` Willy Tarreau
2019-10-25 7:22 ` David Marchand
2019-10-25 16:13 ` Stephen Hemminger
2019-10-25 20:43 ` Thomas Gleixner [this message]
2019-10-26 0:27 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910252232590.1905@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dev@dpdk.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).