From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Paulis Gributs <paulis.gributs@intel.com>, <xiaoyun.li@intel.com>,
<anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices
Date: Thu, 15 Jul 2021 16:52:36 +0200 [thread overview]
Message-ID: <b00ffe28-bd8d-2fbb-faac-40c0a14624ea@intel.com> (raw)
In-Reply-To: <20210715132015.1587544-1-paulis.gributs@intel.com>
On 7/15/2021 3:20 PM, Paulis Gributs wrote:
> This patch removes most uses of the global variable rte_eth_devices
> from testpmd. This was done to avoid using the object directly which
> applications should not do.
>
> Most uses have been replaced with standard function calls, however
> the use of it in the show_macs function could not be replaced as no
> function call exists to get all mac addresses of a given port.
>
> Signed-off-by: Paulis Gributs <paulis.gributs@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
+1 to eliminate 'rte_eth_devices' access from application
next prev parent reply other threads:[~2021-07-15 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 13:20 Paulis Gributs
2021-07-15 14:52 ` Ferruh Yigit [this message]
2021-07-24 12:45 ` Thomas Monjalon
2021-07-16 2:13 ` Li, Xiaoyun
2021-07-19 16:42 ` Ferruh Yigit
2021-07-20 10:35 ` Thomas Monjalon
2021-07-20 12:16 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b00ffe28-bd8d-2fbb-faac-40c0a14624ea@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=paulis.gributs@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).