From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF99010BB3 for ; Thu, 30 Mar 2017 11:27:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490866073; x=1522402073; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=gCO8jtAwrTBBNhc035Tl7UyCPqT2AAG18SRFMCsV5iI=; b=eKJYcBC7UMzIpTUlFHj56z7mYYJAY4u4P5b6r0PvBwkHDRQ37G8nRRS4 t9qUD8sSVy5vEp2YWV65HqoXGhqTBg==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 02:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="82645760" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2017 02:27:50 -0700 To: Olivier Matz References: <1489770822-27539-1-git-send-email-olivier.matz@6wind.com> <20170324132131.2187-1-olivier.matz@6wind.com> <2c512b48-b791-7072-1b73-3ee07fd11a22@intel.com> <20170330105148.2d8db736@platinum> Cc: dev@dpdk.org, thomas.monjalon@6wind.com, robin.jarry@6wind.com, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com From: Ferruh Yigit Message-ID: Date: Thu, 30 Mar 2017 10:27:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330105148.2d8db736@platinum> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] mk: optimize directory dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 09:27:53 -0000 On 3/30/2017 9:51 AM, Olivier Matz wrote: > Hi Ferruh, > > On Tue, 28 Mar 2017 11:34:35 +0100, Ferruh Yigit wrote: >> On 3/24/2017 1:21 PM, Olivier Matz wrote: >>> Before this patch, the management of dependencies between directories >>> had several issues: >>> >>> - the generation of .depdirs, done at configuration is slow: it can take >>> more than one minute on some slow targets (usually ~10s on a standard >>> PC without -j). >>> >>> - for instance, it is possible to express a dependency like: >>> - app/foo depends on lib/librte_foo >>> - and lib/librte_foo depends on app/bar >>> But this won't work because the directories are traversed with a >>> depth-first algorithm, so we have to choose between doing 'app' before >>> or after 'lib'. >>> >>> - the script depdirs-rule.sh is too complex. >>> >>> - we cannot use "make -d" for debug, because the output of make is used for >>> the generation of .depdirs. >>> >>> This patch moves the DEPDIRS-* variables in the upper Makefile, making >>> the dependencies much easier to calculate. A DEPDIRS variable is still >>> used to process library dependencies in LDLIBS. >>> >>> After this commit, "make config" is almost immediate. >>> >>> Signed-off-by: Olivier Matz >>> Tested-by: Robin Jarry >>> Tested-by: Jerin Jacob >> >> <...> >> >>> DIRS-$(CONFIG_RTE_LIBRTE_PORT) += librte_port >>> +DEPDIRS-librte_port := librte_eal librte_mbuf librte_mempool librte_ether >>> +DEPDIRS-librte_port += librte_ip_frag librte_sched librte_kni >> ^ >> ---------------------------------------------------------+ >> >> <...> >> >>> diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile >>> index 44fa73520..76629a13a 100644 >>> --- a/lib/librte_port/Makefile >>> +++ b/lib/librte_port/Makefile >> <...> >>> -ifeq ($(CONFIG_RTE_LIBRTE_KNI),y) >>> -DEPDIRS-$(CONFIG_RTE_LIBRTE_PORT) += lib/librte_kni >>> -endif >> >> This check needs to be reflected to new method, otherwise causing build >> errors for i686 target. >> > > Did you notice an error? I see no error it with: > > make config T=x86_64-native-linuxapp-gcc > sed -i 's,CONFIG_RTE_LIBRTE_KNI=y,# CONFIG_RTE_LIBRTE_KNI is not set,' build/.config > make -j8 > > > I think it is not a problem, the DEPDIRS-* variable only gives an > ordering directive, which should be ok even if kni is not compiled. Can you please test shared library build, I am getting following error: == Build lib/librte_port LD librte_port.so.3.1 /usr/bin/ld: cannot find -lrte_kni collect2: error: ld returned 1 exit status .../mk/rte.lib.mk:127: recipe for target 'librte_port.so.3.1' failed make[3]: *** [librte_port.so.3.1] Error 1 .../mk/rte.subdir.mk:63: recipe for target 'librte_port' failed > > > Regards, > Olivier >