DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso
@ 2020-09-17  2:12 yang_y_yi
  2020-09-17  2:16 ` Hu, Jiayu
  0 siblings, 1 reply; 3+ messages in thread
From: yang_y_yi @ 2020-09-17  2:12 UTC (permalink / raw)
  To: dev; +Cc: jiayu.hu, thomas, yangyi01, yang_y_yi

From: Yi Yang <yangyi01@inspur.com>

Fragment offset of IPv4 header is measured in units of
8 bytes. Fragment offset of UDP fragments will be wrong
after GSO if pyld_unit_size isn't multiple of 8. Say
pyld_unit_size is 1500, fragment offset of the second
UDP fragment will be 187 (i.e. 1500 / 8), which means 1496,
and it will result in 4-byte data loss (1500 - 1496 = 4).
So UDP GRO will reassemble out a wrong packet.

Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation")

Signed-off-by: Yi Yang <yangyi01@inspur.com>
---
 lib/librte_gso/gso_udp4.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/librte_gso/gso_udp4.c b/lib/librte_gso/gso_udp4.c
index 21fea09..6fa68f2 100644
--- a/lib/librte_gso/gso_udp4.c
+++ b/lib/librte_gso/gso_udp4.c
@@ -69,7 +69,10 @@
 		return 1;
 	}
 
-	pyld_unit_size = gso_size - hdr_offset;
+	/* pyld_unit_size must be a multiple of 8 because frag_off
+	 * uses 8 bytes as unit.
+	 */
+	pyld_unit_size = (gso_size - hdr_offset) & ~7U;
 
 	/* Segment the payload */
 	ret = gso_do_segment(pkt, hdr_offset, pyld_unit_size, direct_pool,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso
  2020-09-17  2:12 [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso yang_y_yi
@ 2020-09-17  2:16 ` Hu, Jiayu
  2020-09-17 15:01   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Hu, Jiayu @ 2020-09-17  2:16 UTC (permalink / raw)
  To: yang_y_yi, dev; +Cc: thomas, yangyi01, Yigit, Ferruh

Acked-by: Jiayu Hu <jiayu.hu@intel.com>

> -----Original Message-----
> From: yang_y_yi@163.com <yang_y_yi@163.com>
> Sent: Thursday, September 17, 2020 10:13 AM
> To: dev@dpdk.org
> Cc: Hu, Jiayu <jiayu.hu@intel.com>; thomas@monjalon.net;
> yangyi01@inspur.com; yang_y_yi@163.com
> Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso
> 
> From: Yi Yang <yangyi01@inspur.com>
> 
> Fragment offset of IPv4 header is measured in units of
> 8 bytes. Fragment offset of UDP fragments will be wrong
> after GSO if pyld_unit_size isn't multiple of 8. Say
> pyld_unit_size is 1500, fragment offset of the second
> UDP fragment will be 187 (i.e. 1500 / 8), which means 1496,
> and it will result in 4-byte data loss (1500 - 1496 = 4).
> So UDP GRO will reassemble out a wrong packet.
> 
> Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation")
> 
> Signed-off-by: Yi Yang <yangyi01@inspur.com>
> ---
>  lib/librte_gso/gso_udp4.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_gso/gso_udp4.c b/lib/librte_gso/gso_udp4.c
> index 21fea09..6fa68f2 100644
> --- a/lib/librte_gso/gso_udp4.c
> +++ b/lib/librte_gso/gso_udp4.c
> @@ -69,7 +69,10 @@
>  		return 1;
>  	}
> 
> -	pyld_unit_size = gso_size - hdr_offset;
> +	/* pyld_unit_size must be a multiple of 8 because frag_off
> +	 * uses 8 bytes as unit.
> +	 */
> +	pyld_unit_size = (gso_size - hdr_offset) & ~7U;
> 
>  	/* Segment the payload */
>  	ret = gso_do_segment(pkt, hdr_offset, pyld_unit_size, direct_pool,
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso
  2020-09-17  2:16 ` Hu, Jiayu
@ 2020-09-17 15:01   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-09-17 15:01 UTC (permalink / raw)
  To: Hu, Jiayu, yang_y_yi, dev; +Cc: thomas, yangyi01

On 9/17/2020 3:16 AM, Hu, Jiayu wrote:

>> -----Original Message-----
>> From: yang_y_yi@163.com <yang_y_yi@163.com>
>> Sent: Thursday, September 17, 2020 10:13 AM
>> To: dev@dpdk.org
>> Cc: Hu, Jiayu <jiayu.hu@intel.com>; thomas@monjalon.net;
>> yangyi01@inspur.com; yang_y_yi@163.com
>> Subject: [PATCH v2] gso: fix pyld_unit_size issue for udp gso
>>
>> From: Yi Yang <yangyi01@inspur.com>
>>
>> Fragment offset of IPv4 header is measured in units of
>> 8 bytes. Fragment offset of UDP fragments will be wrong
>> after GSO if pyld_unit_size isn't multiple of 8. Say
>> pyld_unit_size is 1500, fragment offset of the second
>> UDP fragment will be 187 (i.e. 1500 / 8), which means 1496,
>> and it will result in 4-byte data loss (1500 - 1496 = 4).
>> So UDP GRO will reassemble out a wrong packet.
>>
>> Fixes: b166d4f30b66 ("gso: support UDP/IPv4 fragmentation")
>>
>> Signed-off-by: Yi Yang <yangyi01@inspur.com>
>
 > Acked-by: Jiayu Hu <jiayu.hu@intel.com>
 >

Applied to dpdk-next-net/main, thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-17 15:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17  2:12 [dpdk-dev] [PATCH v2] gso: fix pyld_unit_size issue for udp gso yang_y_yi
2020-09-17  2:16 ` Hu, Jiayu
2020-09-17 15:01   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git