From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57CE5A3160 for ; Fri, 11 Oct 2019 04:50:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F36C31E969; Fri, 11 Oct 2019 04:50:30 +0200 (CEST) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by dpdk.org (Postfix) with ESMTP id 7F1D21E964 for ; Fri, 11 Oct 2019 04:50:29 +0200 (CEST) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 99CFBAD233F01F080C2A for ; Fri, 11 Oct 2019 10:50:27 +0800 (CST) Received: from [127.0.0.1] (10.177.29.98) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 11 Oct 2019 10:50:19 +0800 To: Ferruh Yigit CC: , , , , , , References: <3f098f19-4029-21ae-b685-ece6af9e237a@huawei.com> From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)" Message-ID: Date: Fri, 11 Oct 2019 10:50:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.29.98] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, I have deleted the seq_id getting logs, and we can get the infos by other method, which is updated by Patch V4. Best Regards, Xiaoyun Wang 在 2019/10/8 23:33, Ferruh Yigit 写道: > On 10/8/2019 4:14 PM, Wangxiaoyun (Cloud, Network Chip Application Development > Dept) wrote: >> Hi Ferruh, >> Thanks for your comments. hinic pmd driver doesn't support 32-bit build, we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". >> and “defconfig_x86_x32-native-linux-gcc”. I don't know why it also build in 32-bit platform, can you tell me where also need me to add configuration. >> Also I build it on 64-bit platform，That's OK. > Hi Xiaoyun, > > You are right, driver doesn't support 32bit, I am force enabling it, just for build. > > Since the build error is only in the logging format identifiers, I think it make > sense to fix it, and it is better to use more proper format identifiers. > >> Best regards >> Xiaoyun Wang >> >> 在 2019/9/30 23:06, Ferruh Yigit 写道: >>> On 9/30/2019 3:00 PM, Xiaoyun wang wrote: >>>> This patch set adds advanced features for Huawei hinic pmd, >>>> such as VLAN filter and VLAN offload, SR-IOV, FW version get, >>>> set link down and up, Flow director for LACP, VRRP, BGP and so on. >>>> >>>> -- >>>> v2: >>>> - Fix RSS bugs for vxlan packets inner type >>>> - Add comments for new added func interface >>>> - Fix code review comments from patch v1 >>>> - Fix code style problems >>>> - Remove ceq interfaces and definitions that not used >>>> - Fix aeq init bugs, firstly alloc aeq resource, then set aeq ctrl len >>>> - Fix bar map bugs for VF Page size larger than PF >>>> - Modify link state set, add enable or disable fiber in tx direction >>>> - Fix mbox and mgmt channel sync lock mechanism to reduce CPU usage >>>> - Fix FDIR bugs for VRRP packets >>>> - Fit ABI changes from dpdk lib >>>> >>>> v3: >>>> - Split hinic.ini and hinic.rst to related feature patches >>>> - Add min_mtu & max_mtu initialization for hinic_dev_infos_get >>>> - Fix fdir config patch with net/hinic/base >>>> - Split link patch into link and fw version getting 2 patches >>>> - Update pmd doc files to new next version >>>> - Add comments for cover letter patch >>>> - Add rxq & txq info getting interfaces >>>> - Fix load intrinsics for receiving packets >>>> >>>> Xiaoyun wang (19): >>>> net/hinic/base: add mbox command channel for SRIOV >>>> net/hinic/base: add HW interfaces for SR-IOV >>>> net/hinic: add VF PMD operation interfaces >>>> net/hinic: add VLAN filter and offload >>>> net/hinic: add allmulticast mode and MTU set >>>> net/hinic: add unicast and multicast MAC set >>>> net/hinic/base: add fdir config interface >>>> net/hinic: add fdir validate flow operations >>>> net/hinic: create and destroy ntuple filter >>>> net/hinic: create and destroy fdir filter >>>> net/hinic: flush fdir filter >>>> net/hinic: set link down and up >>>> net/hinic: get firmware version >>>> net/hinic: support inner L3 checksum offload >>>> net/hinic: support LRO offload >>>> net/hinic: add hinic PMD doc files >>>> net/hinic/base: optimize aeq interfaces >>>> net/hinic: optimize RX performance >>>> net/hinic: add support for getting rxq or txq info >>> There is following 32-bit build error because of the log formatting [1], can you >>> please check it? >>> >>> >>> [1] >>> .../drivers/net/hinic/base/hinic_pmd_mbox.c(659): >>> error #181: argument of type "unsigned long long" is incompatible with format >>> "%lx", expecting argument of type "unsigned long" >>> PMD_DRV_LOG(ERR, "Fail to send mbox seg, seq_id: 0x%lx, >>> err: %d", >>> >>> . > > .