From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E026EA0C41;
	Wed, 23 Jun 2021 16:13:52 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CE1A7410E9;
	Wed, 23 Jun 2021 16:13:52 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 64323410F5
 for <dev@dpdk.org>; Wed, 23 Jun 2021 16:13:51 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C7F0A7F53F;
 Wed, 23 Jun 2021 17:13:50 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C7F0A7F53F
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1624457630;
 bh=PGcRe26irqjv+S/P3zBUOnYUiHg3/VNI/+T1a++bP0A=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=ODNNLlsh9z692+gAh6/xx5alV7ej+7OjGstCsNxDGL9geZUXm46G2obSoeGw6USRP
 B4/lXJfoYhdWCZnlKUlcbfUGiIvcEXFGv7PxnLXhRlPPS5TwQve7roQJ9+8irGlJOf
 UMi3VfiLyPjnqzOKV8fPHOWQjvwoT+3D2UgrcOyg=
To: Ori Kam <orika@nvidia.com>, Jan Viktorin <viktorin@cesnet.cz>,
 "dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>
References: <20210623091825.16269-1-viktorin@cesnet.cz>
 <BL1PR12MB533539ADD7914072D5D2B3F9D6089@BL1PR12MB5335.namprd12.prod.outlook.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <b063a455-e74a-502f-3af0-186161b6a6b2@oktetlabs.ru>
Date: Wed, 23 Jun 2021 17:13:50 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <BL1PR12MB533539ADD7914072D5D2B3F9D6089@BL1PR12MB5335.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct
 rte_flow_action
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/23/21 4:39 PM, Ori Kam wrote:
> Hi Jan,
> 
>> -----Original Message-----
>> From: Jan Viktorin <viktorin@cesnet.cz>
>> Sent: Wednesday, June 23, 2021 12:18 PM
>>
>> The struct rte_flow_action was missing from DPDK API documentation.
>>
>> Signed-off-by: Jan Viktorin <viktorin@cesnet.cz>
>> ---
>>  lib/ethdev/rte_flow.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>> 961a5884fe..70f455d47d 100644
>> --- a/lib/ethdev/rte_flow.h
>> +++ b/lib/ethdev/rte_flow.h
>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m,
>> uint32_t v)
>>  	*RTE_FLOW_DYNF_METADATA(m) = v;
>>  }
>>
>> -/*
>> +/**
>>   * Definition of a single action.
>>   *
>>   * A list of actions is terminated by a END action.
>> --
>> 2.32.0
> 
> Acked-by: Ori Kam <orika@nvidia.com>
> Thanks,
> Ori
> 

Not that important, but it looks like a fix which should be
backported to stable branches as well.
Shouldn't "Fixes:" be added with Cc to stable?

Andrew.