From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35FFAA0C4C; Tue, 5 Oct 2021 16:17:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 234C24132D; Tue, 5 Oct 2021 16:17:09 +0200 (CEST) Received: from mail-108-mta31.mxroute.com (mail-108-mta31.mxroute.com [136.175.108.31]) by mails.dpdk.org (Postfix) with ESMTP id A2B6C4130B for ; Tue, 5 Oct 2021 16:17:07 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta31.mxroute.com (ZoneMTA) with ESMTPSA id 17c50d0a5850008545.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 05 Oct 2021 14:17:03 +0000 X-Zone-Loop: b4a44a7624fc1eca993f0d7de340a9cbee13fc6893d0 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2DTEsQNqKZw3D5Z8EicALXwarZ0u/QyTNiByMYocVbg=; b=DQxY6BOID56DcPR7QGjvkxAdeD QBQmjVCEY0m45vUq3cC6yOiTUEpnwTSmst+blYBLtLEb6PGQFb5fAS7U5Daeo+jClvWCp+rwrY6Aj q8CsHJyYiTFitO0RkqG+7GTk/dx0POzw3skGB3wS+a4AAKkrE69w7UwP26yg0kqt0NIsO3J+Tb9id qg6y6KaMyzt2mIufGxidWD8i3vU2P8tKesLsH6/Wp8Uy6fTKv5mb23UT4RLX5Emvt16Jjn/u39I7I LddDa7yl9AZlHprJELiPmQLRHgTG9wFiiUE3Z99/mmN+QDnUoWxJydQMTmBgFZ09ttCSi6oA7UswV xtEwBZsw==; To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, Jasvinder Singh , Cristian Dumitrescu , Vladimir Medvedkin , Conor Walsh , Stephen Hemminger References: <20211005091626.31885-1-david.marchand@redhat.com> From: "Kinsella, Ray" Message-ID: Date: Tue, 5 Oct 2021 15:16:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211005091626.31885-1-david.marchand@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, RCPT_COUNT_SEVEN=0, FROM_HAS_DN=0, TO_DN_SOME=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, NEURAL_SPAM=0, MID_RHS_MATCH_FROM=0] Subject: Re: [dpdk-dev] [PATCH] sort symbols map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/10/2021 10:16, David Marchand wrote: > Fixed with ./devtools/update-abi.sh $(cat ABI_VERSION) > > Fixes: e73a7ab22422 ("net/softnic: promote manage API") > Fixes: 8f532a34c4f2 ("fib: promote API to stable") > Fixes: 4aeb92396b85 ("rib: promote API to stable") > > Signed-off-by: David Marchand > --- > I added "./devtools/update-abi.sh $(cat ABI_VERSION)" to my checks. > > I should have caught it when merging fib and rib patches... > But my eyes (or more likely brain) stopped at net/softnic bits. > > What do you think? > Should I wait a bit more and send a global patch to catch any missed > sorting just before rc1? > > In the meantime, if you merge .map updates, try to remember to run the > command above. > > Thanks. > --- > drivers/net/softnic/version.map | 2 +- > lib/fib/version.map | 21 ++++++++++----------- > lib/rib/version.map | 33 ++++++++++++++++----------------- > 3 files changed, 27 insertions(+), 29 deletions(-) > Something to add to the Symbol Bot also, maybe? Acked-by: Ray Kinsella