From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57D0DA0C45; Wed, 20 Oct 2021 09:52:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42DBF41174; Wed, 20 Oct 2021 09:52:53 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id DA83440142 for ; Wed, 20 Oct 2021 09:52:51 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 79D907F508; Wed, 20 Oct 2021 10:52:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 79D907F508 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634716371; bh=GxaATAGPZ8jZaQpNstZErnvbfmHVrqrcrzRaBR7HXLA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Kn0NyIrROQdB/XiylsGLMYGGvA9zT2IIyLiYIhuruhcGC0poDcZCRQa56x0AdX6QA yUnEBqAUYMlMvZDI/M+I6T8wjsuH3jJHdGsPzYGphV6nOK3Cm12NVRo0MTrGKDUFiD oAOHT3BZ+xxhESOtcYcVVE7Fv9kpIF38ydfDMq10= To: David Marchand Cc: Olivier Matz , dev References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Wed, 20 Oct 2021 10:52:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/6] mempool: cleanup namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 11:09 PM, David Marchand wrote: > On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko > wrote: >> >> Add RTE_ prefix to mempool API including internal. Keep old public API >> with fallback to new defines. Internal API is just renamed. >> >> v3: >> - fix typo >> - rebase on top of current main >> - add prefix to newly added MEMPOOL_F_NON_IO >> - fix deprecation usage >> - add Fixes tag the patch which deprecates unused macros > > Thanks for the quick rebase. > I had rebased v2 before Olivier comments. > I spotted a little issue diffing with your v3 (see comment on patch > 2), and fixed your v3 in a local branch of mine. > It passes my checks. > > I'll wait tomorrow, to see if Olivier wants to send some acks. Olivier has just added missing Acks. Do you need v4 from me with patch 2 fixes? Your changes LGTM and I don't mind if you fix it on apply.