* [dpdk-dev] [PATCH] net/softnic: fix resource leak
@ 2020-04-27 14:03 Jasvinder Singh
2020-04-27 17:15 ` [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline Jasvinder Singh
2020-05-13 12:45 ` [dpdk-dev] [PATCH] net/softnic: fix resource leak Mcnamara, John
0 siblings, 2 replies; 6+ messages in thread
From: Jasvinder Singh @ 2020-04-27 14:03 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu
When sending request messages to data plane pipelines, the
caller must free the memory allocated to request message on
receiving error response.
Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table entries")
Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
drivers/net/softnic/rte_eth_softnic_thread.c | 65 +++++++++++++++-----
1 file changed, 48 insertions(+), 17 deletions(-)
diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c
index 028911c19..f45dbbe1e 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -773,9 +773,9 @@ pipeline_msg_alloc(void)
}
static void
-pipeline_msg_free(struct pipeline_msg_rsp *rsp)
+pipeline_msg_free(void *msg)
{
- free(rsp);
+ free(msg);
}
static struct pipeline_msg_rsp *
@@ -843,8 +843,10 @@ softnic_pipeline_port_in_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -892,8 +894,10 @@ softnic_pipeline_port_in_enable(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -939,8 +943,10 @@ softnic_pipeline_port_in_disable(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -994,8 +1000,10 @@ softnic_pipeline_port_out_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1051,8 +1059,10 @@ softnic_pipeline_table_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1331,8 +1341,10 @@ softnic_pipeline_table_rule_add(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1415,8 +1427,10 @@ softnic_pipeline_table_rule_add_default(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1573,8 +1587,10 @@ softnic_pipeline_table_rule_add_bulk(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1638,8 +1654,10 @@ softnic_pipeline_table_rule_delete(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1688,8 +1706,10 @@ softnic_pipeline_table_rule_delete_default(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1748,8 +1768,10 @@ softnic_pipeline_table_rule_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1831,6 +1853,7 @@ softnic_pipeline_table_mtr_profile_add(struct pmd_internals *softnic,
rsp = pipeline_msg_send_recv(p, req);
if (rsp == NULL) {
free(mp);
+ pipeline_msg_free(req);
return -1;
}
@@ -1888,8 +1911,10 @@ softnic_pipeline_table_mtr_profile_delete(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -1951,8 +1976,10 @@ softnic_pipeline_table_rule_mtr_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -2016,8 +2043,10 @@ softnic_pipeline_table_dscp_table_update(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
@@ -2081,8 +2110,10 @@ softnic_pipeline_table_rule_ttl_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
+ if (rsp == NULL) {
+ pipeline_msg_free(req);
return -1;
+ }
/* Read response */
status = rsp->status;
--
2.21.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline
2020-04-27 14:03 [dpdk-dev] [PATCH] net/softnic: fix resource leak Jasvinder Singh
@ 2020-04-27 17:15 ` Jasvinder Singh
2020-05-01 15:48 ` Ferruh Yigit
2020-05-13 12:45 ` [dpdk-dev] [PATCH] net/softnic: fix resource leak Mcnamara, John
1 sibling, 1 reply; 6+ messages in thread
From: Jasvinder Singh @ 2020-04-27 17:15 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu
For sending request messages to data plane threads, the
caller invokes pipeline_msg_send_recv() function which never
returns null response. Thus, removed redundant check on
the returned response.
Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table entries")
Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
drivers/net/softnic/rte_eth_softnic_thread.c | 34 --------------------
1 file changed, 34 deletions(-)
diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c
index d61846e03..dcfb5eb82 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -835,8 +835,6 @@ softnic_pipeline_port_in_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -884,8 +882,6 @@ softnic_pipeline_port_in_enable(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -931,8 +927,6 @@ softnic_pipeline_port_in_disable(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -986,8 +980,6 @@ softnic_pipeline_port_out_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1043,8 +1035,6 @@ softnic_pipeline_table_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1323,8 +1313,6 @@ softnic_pipeline_table_rule_add(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1407,8 +1395,6 @@ softnic_pipeline_table_rule_add_default(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1565,8 +1551,6 @@ softnic_pipeline_table_rule_add_bulk(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1630,8 +1614,6 @@ softnic_pipeline_table_rule_delete(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1680,8 +1662,6 @@ softnic_pipeline_table_rule_delete_default(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1740,8 +1720,6 @@ softnic_pipeline_table_rule_stats_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1821,10 +1799,6 @@ softnic_pipeline_table_mtr_profile_add(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL) {
- free(mp);
- return -1;
- }
/* Read response */
status = rsp->status;
@@ -1880,8 +1854,6 @@ softnic_pipeline_table_mtr_profile_delete(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -1943,8 +1915,6 @@ softnic_pipeline_table_rule_mtr_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -2008,8 +1978,6 @@ softnic_pipeline_table_dscp_table_update(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
@@ -2073,8 +2041,6 @@ softnic_pipeline_table_rule_ttl_read(struct pmd_internals *softnic,
/* Send request and wait for response */
rsp = pipeline_msg_send_recv(p, req);
- if (rsp == NULL)
- return -1;
/* Read response */
status = rsp->status;
--
2.21.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline
2020-04-27 17:15 ` [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline Jasvinder Singh
@ 2020-05-01 15:48 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-05-01 15:48 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 4/27/2020 6:15 PM, Jasvinder Singh wrote:
> For sending request messages to data plane threads, the
> caller invokes pipeline_msg_send_recv() function which never
> returns null response. Thus, removed redundant check on
> the returned response.
>
> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
>
> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table entries")
> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak
2020-04-27 14:03 [dpdk-dev] [PATCH] net/softnic: fix resource leak Jasvinder Singh
2020-04-27 17:15 ` [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline Jasvinder Singh
@ 2020-05-13 12:45 ` Mcnamara, John
2020-05-13 13:55 ` Dumitrescu, Cristian
1 sibling, 1 reply; 6+ messages in thread
From: Mcnamara, John @ 2020-05-13 12:45 UTC (permalink / raw)
To: Dumitrescu, Cristian; +Cc: dev, Singh, Jasvinder
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
> Sent: Monday, April 27, 2020 3:03 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>
> When sending request messages to data plane pipelines, the caller must
> free the memory allocated to request message on receiving error response.
>
> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
>
> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
> entries")
> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Cristian,
Can you merge this and other Coverity fixes. They need to be cleared for DPDK 20.05.
John
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak
2020-05-13 12:45 ` [dpdk-dev] [PATCH] net/softnic: fix resource leak Mcnamara, John
@ 2020-05-13 13:55 ` Dumitrescu, Cristian
2020-05-13 15:32 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Dumitrescu, Cristian @ 2020-05-13 13:55 UTC (permalink / raw)
To: Mcnamara, John; +Cc: dev, Singh, Jasvinder
> -----Original Message-----
> From: Mcnamara, John <john.mcnamara@intel.com>
> Sent: Wednesday, May 13, 2020 1:46 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
> > Sent: Monday, April 27, 2020 3:03 PM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
> >
> > When sending request messages to data plane pipelines, the caller must
> > free the memory allocated to request message on receiving error
> response.
> >
> > Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
> > 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
> >
> > Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
> > Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
> > Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
> > entries")
> > Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
> > Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
>
>
>
> Cristian,
>
> Can you merge this and other Coverity fixes. They need to be cleared for
> DPDK 20.05.
>
> John
Ferruh and Jasvinder confirmed these are already merged.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/softnic: fix resource leak
2020-05-13 13:55 ` Dumitrescu, Cristian
@ 2020-05-13 15:32 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-05-13 15:32 UTC (permalink / raw)
To: Dumitrescu, Cristian, Mcnamara, John; +Cc: dev, Singh, Jasvinder
On 5/13/2020 2:55 PM, Dumitrescu, Cristian wrote:
>
>
>> -----Original Message-----
>> From: Mcnamara, John <john.mcnamara@intel.com>
>> Sent: Wednesday, May 13, 2020 1:46 PM
>> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Jasvinder Singh
>>> Sent: Monday, April 27, 2020 3:03 PM
>>> To: dev@dpdk.org
>>> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
>>> Subject: [dpdk-dev] [PATCH] net/softnic: fix resource leak
>>>
>>> When sending request messages to data plane pipelines, the caller must
>>> free the memory allocated to request message on receiving error
>> response.
>>>
>>> Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
>>> 357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
>>>
>>> Fixes: 6d4d05402501 ("net/softnic: add command to read stats")
>>> Fixes: 202905f3ee4d ("net/softnic: add command to create objects")
>>> Fixes: ee19326a4b1e ("net/softnic: add command for pipeline table
>>> entries")
>>> Fixes: 9bc0ce0ad17c ("net/softnic: add command for meter action")
>>> Fixes: 2505030a8383 ("net/softnic: add command for TTL action")
>>>
>>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>>
>>
>>
>>
>> Cristian,
>>
>> Can you merge this and other Coverity fixes. They need to be cleared for
>> DPDK 20.05.
>>
>> John
>
> Ferruh and Jasvinder confirmed these are already merged.
>
Patches are in the tree Cristian, but I think they are not addressing the
coverity issue correctly, that looks the reason that coverity issues are still
there.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-13 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 14:03 [dpdk-dev] [PATCH] net/softnic: fix resource leak Jasvinder Singh
2020-04-27 17:15 ` [dpdk-dev] [PATCH v2] net/softnic: fix resource leak for pipeline Jasvinder Singh
2020-05-01 15:48 ` Ferruh Yigit
2020-05-13 12:45 ` [dpdk-dev] [PATCH] net/softnic: fix resource leak Mcnamara, John
2020-05-13 13:55 ` Dumitrescu, Cristian
2020-05-13 15:32 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).