* [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation
@ 2017-01-15 19:50 Emmanuel Roullit
2017-01-16 12:58 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Emmanuel Roullit @ 2017-01-15 19:50 UTC (permalink / raw)
To: rahul.lakkireddy; +Cc: dev
clang reports the following error:
error: logical not is only applied to the left hand side of this bitwise
operator. [-Werror,-Wlogical-not-parentheses]
Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
drivers/net/cxgbe/cxgbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index 7ccf434..541fc40 100644
--- a/drivers/net/cxgbe/cxgbe_main.c
+++ b/drivers/net/cxgbe/cxgbe_main.c
@@ -959,7 +959,7 @@ int setup_rss(struct port_info *pi)
dev_debug(adapter, "%s: pi->rss_size = %u; pi->n_rx_qsets = %u\n",
__func__, pi->rss_size, pi->n_rx_qsets);
- if (!pi->flags & PORT_RSS_DONE) {
+ if (!(pi->flags & PORT_RSS_DONE)) {
if (adapter->flags & FULL_INIT_DONE) {
/* Fill default values with equal distribution */
for (j = 0; j < pi->rss_size; j++)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation
2017-01-15 19:50 [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation Emmanuel Roullit
@ 2017-01-16 12:58 ` Ferruh Yigit
2017-01-16 13:17 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16 12:58 UTC (permalink / raw)
To: Emmanuel Roullit, rahul.lakkireddy; +Cc: dev
On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
> clang reports the following error:
> error: logical not is only applied to the left hand side of this bitwise
> operator. [-Werror,-Wlogical-not-parentheses]
>
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation
2017-01-16 12:58 ` Ferruh Yigit
@ 2017-01-16 13:17 ` Ferruh Yigit
2017-01-16 13:18 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16 13:17 UTC (permalink / raw)
To: Emmanuel Roullit, rahul.lakkireddy; +Cc: dev
On 1/16/2017 12:58 PM, Ferruh Yigit wrote:
> On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
>> clang reports the following error:
>> error: logical not is only applied to the left hand side of this bitwise
>> operator. [-Werror,-Wlogical-not-parentheses]
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation
2017-01-16 13:17 ` Ferruh Yigit
@ 2017-01-16 13:18 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-01-16 13:18 UTC (permalink / raw)
To: Emmanuel Roullit, rahul.lakkireddy; +Cc: dev, dpdk stable
On 1/16/2017 1:17 PM, Ferruh Yigit wrote:
> On 1/16/2017 12:58 PM, Ferruh Yigit wrote:
>> On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
>>> clang reports the following error:
>>> error: logical not is only applied to the left hand side of this bitwise
>>> operator. [-Werror,-Wlogical-not-parentheses]
>>>
>>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
>
> Applied to dpdk-next-net/master, thanks.
CC: stable@dpdk.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-16 13:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-15 19:50 [dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation Emmanuel Roullit
2017-01-16 12:58 ` Ferruh Yigit
2017-01-16 13:17 ` Ferruh Yigit
2017-01-16 13:18 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).