From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E215FA0A02; Fri, 15 Jan 2021 10:35:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2349140E03; Fri, 15 Jan 2021 10:35:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id AD73A140DDA for ; Fri, 15 Jan 2021 10:35:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610703345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KYYefdJaC3OoJYyrPGK2MDJWfoWz3qVj5JF0RSBVhik=; b=YuSznrsjY0x/FZEJDY55mWHO/2v3MbstZ8Ro33uiz+Adds3mlzgbAGNjX37b+R++TxE4pY jdtF7yutTUttyFsbIxe356bIW8XWydHPb49DJG7q9+g+YokYnx/OiiXc89P/W0AYVoQVgJ CY44DjMUVYND08zlY7U6getsHI4AuBY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-rzgw2SdwMM-MVRJq9jwN3A-1; Fri, 15 Jan 2021 04:35:41 -0500 X-MC-Unique: rzgw2SdwMM-MVRJq9jwN3A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 136E21005D4D; Fri, 15 Jan 2021 09:35:40 +0000 (UTC) Received: from [10.36.110.24] (unknown [10.36.110.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 79F9E5D9C2; Fri, 15 Jan 2021 09:35:35 +0000 (UTC) To: David Marchand Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-15-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Fri, 15 Jan 2021 10:35:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/6/21 10:58 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> >> This patch improves the virtio_hw struct packing, >> going from 88 down to 80 bytes with a 6 bytes hole in >> the end of the first cacheline. Fields only used in the >> slow path are placed in the end, so that hot path only >> uses the first cacheline. > > This also changes some boolean fields to uint8_t but we still assign > the true/false values to them (in some cases). > This works, but I would align those fields' assignments to this type change. > Fixed, note it was already inconsistent for some. Thanks, Maxime