From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15537A0C45; Wed, 27 Oct 2021 10:28:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9168040040; Wed, 27 Oct 2021 10:28:03 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 3F9C34003F for ; Wed, 27 Oct 2021 10:28:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="290945038" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="290945038" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 01:27:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="494712537" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2021 01:27:51 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 01:27:51 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 01:27:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 01:27:50 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 01:27:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eu8zkqPVtJoxOOgeB828urRynkGqwxFmrybMkZpT3QY0rN8Qk8mMifWSvuqwWvLppAzn52l2SCmtofkwlxKvsQri5qjXwP45qWWRP5L3PQaS+XTH5pMVhz9YlAKPPpz5ndffNO5pnd7YBaFCRubbJ73Paz013C4W1rV2S9jb21Rsos9X8N9oB1pbpWSIZb7UysSIEtgE1M/UJjYF0uLMRhDTmp/VBt4pTZyD3uJZAwZ4glhOAZwc2Nrd0M9yryIAMWisOPcE3NUElRJinZDeVM02M3gxA3cyMq76aQLq+UFfXKKgIKMUvY3mfg1CmWMkVS+er9mzvjek8zCjyMH25A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q9C0YMl5JsP3/l6xfmZ/lG0bZOCYA6JmoVUrnzBsR6Q=; b=bgkgZStI5hpuPYMlHXMmzb7mbHsMwLzQy9J1GRucObtRQXU5926CSerBmEGgra2YIQzHiEEi0SSztKb0l2Ol3PDSRVSTQJVfb/2D7RDx8v1Bfa07gE4kKBkanetYg2ZRqzK1pZMcmnJbQjT30zEvJEnMoiUnqbL7sZuQb5ZtLtnDxACnNUfIDmyQcLwARV5Lcro3W9v2+WBOmWybBMPHqBK9V4UVKlHqDS5oeoYg1LIygASxXpJcTkZPIHjfz76vAUdSdCUDKCvRLWvR9Is2vU6LbuiODJeCh9lQKled4pxzABh/gJ0FbmnbCSnABal9wbk78e4NKV6bxnc8EfGd6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9C0YMl5JsP3/l6xfmZ/lG0bZOCYA6JmoVUrnzBsR6Q=; b=kt0yjVkVfYyofauHKNAa9YsShxOc0RVkKgAim3xyAbX7UIKypIP3M+PAHzC90XYNKMu3XlFtS+SGWrGf9V1MrYZW20/g6aeEoG+IIHtJQww9IKibqR+3V3XV9gs7PyNAiH0tkfvzBjTUPdEyNaXmhvrKZ5/cERnqxVM7uunSLOA= Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4983.namprd11.prod.outlook.com (2603:10b6:510:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct 2021 08:27:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 08:27:49 +0000 Message-ID: Date: Wed, 27 Oct 2021 09:27:43 +0100 Content-Language: en-US To: Stephen Hemminger CC: Jakub Grajciar , Somnath Kotur , Rosen Xu , Andrew Rybchenko , Ajit Khaparde , References: <20211026153802.1820636-1-ferruh.yigit@intel.com> <20211026153802.1820636-2-ferruh.yigit@intel.com> <20211026134724.5478f4c1@hermes.local> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211026134724.5478f4c1@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0244.eurprd04.prod.outlook.com (2603:10a6:10:28e::9) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0244.eurprd04.prod.outlook.com (2603:10a6:10:28e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Wed, 27 Oct 2021 08:27:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f778415-791f-41a3-acb8-08d99923a96d X-MS-TrafficTypeDiagnostic: PH0PR11MB4983: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V7i8sidCLM/CTEEcrrRoq3FCNDW9pZHgR/AjB0BcdLuQQA6g7FDd430SbHDx+nb+IKrdDvcVEC1Qimo1m8vWctunC0fft7rsR70TvYDfaMe5JevxYPtMKiuxNq3QE3qbDDjXRfcQvxsSQNXdKzTwZFgo73UnwcRrPKfTDiLL7PfGAxjwHOdgSGyIYifXRS2h1jOipcQWHtJiJMyvhok9Bo37egXQJ1fITEaEMyCggXF94BtMhqfsWyHI0qN9K5UfNE/P8MSbrBDd2k0LotZfasdG78Pfdk665JsSvKzNYr+0OYHQBQOenDRmb2Xrr65IxEiFD5xY8NMrjA+5BEuMw+GTnCa5AOFDP1nJitQz1vS8ASpDVNJwIbYBhz8Eis6WI5bxVqpFY+nj/xj0krU+BEa/Jsgn0snBa+dAxJ+soan5crwRtiUgKbsurg5xdmZEaYpqdRRFck4mx00CC+VtCFNwELM1dX/qFEt6R2HFy9pQrU91jgTjiBzyZ8YDeE3BdpA8b1CBkkv8SPhZwbJvvtr+H/N4FGCeqE7EzWPy3I3k1oVhP/R9Tlox7zWaOa1huG8K5XCXi4GI+4AYXI1liYzGCNFNVwXxZHrln+HL/NZ+1u21b4jKl5/itFGbnQn8zYjjvU3GZ6NrSmMR735M/FTJGR4+maiAtRw7YuDYcVijSdx0QuDm352lQEVXQLuHt2NF1ajD7T5Lpf7iRdW7ag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(26005)(956004)(53546011)(31696002)(6916009)(54906003)(82960400001)(316002)(16576012)(8936002)(8676002)(6486002)(86362001)(4326008)(508600001)(2616005)(6666004)(38100700002)(31686004)(66476007)(4744005)(44832011)(66946007)(5660300002)(66556008)(2906002)(36756003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWpWZVp6U0hxTmljMXZHdXY5UXRXNWQ4b2hLbUU3Z2lQVS9NUHNuN2g4bjNk?= =?utf-8?B?cXhUVVJKZkNSakc3ZnFDRXZUNkk2b2JydnJSZnlZN1A0aGk1cjBuTGdIZy9J?= =?utf-8?B?bUg2SU9qRTdwM2xhejZiZXFtM215OUlXbzFUdzlOWE13RjNKME51a1g1WFJp?= =?utf-8?B?MnlyVTIrb3dBTW5MVTZjdkx5UzdoemtueXY1c25rM2d5cnNQSVQvWHRCV1hW?= =?utf-8?B?SXpxRjByRFVTK3ZHQmg4YW0weFpSVlRiOWlLUHByanZOTDdMSkM4aDdKMFZ1?= =?utf-8?B?TEZwMkszWC9VSkxDWWFGM0FyRTBtUE9QQjNMZWtYT2cxS3MxUkJNaDZKZ3pK?= =?utf-8?B?LzNQTDlkZXdIUTlmNG50WjdXZStkVnVpWkNnbzRuTGFhcGp3ZjJnUldDcU9K?= =?utf-8?B?eUt2eVRRbXMyeFdObDdVa3NRVCtXQ1NPNHBjdlQyc2NWN2hwYUgvU2p3WlNT?= =?utf-8?B?MHpJaTNwZThCWjNFOGxCYTQ4UlR4a3JTVGQ1OUpmb2krcDVvcUh6VE5zUTJF?= =?utf-8?B?TXpNWEtmM05xcExaU29oSkZDdUVuZ0xuWFE0NEpOWFMzOWVpYlY2cEpzRU96?= =?utf-8?B?QmNObmUzVHZkM0F3NnNwRW5LMitEd0dwOTNnQzdQNXpiWlJ4bktKRnoxQy9E?= =?utf-8?B?cGRIdVRxM2YzZ05pbGVRVG1HT2tMa1dPQnk0SWRVR2Y0N2VlMWtVWWF5dWhC?= =?utf-8?B?Uk5BNDJLTG5MNnFFcGZCMlpzTHhteDRKcHk2ZE0zSFFScTVQNGVsWGFFc0FR?= =?utf-8?B?SEM3ZHBiTDZuZnJWYkFEVkxOZnZIS3QvejNZamdqaDQrMThCNzBoUjEvOXZO?= =?utf-8?B?SVpieDBLVEduUnNTVkdvRnFqK1pNZjFVZ3hjdGtleDNtcmk2b3Bjb0RqR1Vp?= =?utf-8?B?YUJRSFFReTdQd2ZNOXEvMDlMWkFFUC9CYXlFL1ZBOVhHVUU2UGd0VzlBVkhT?= =?utf-8?B?engwU0duOHI5QmVZenRVaHI1ZzlkWS9GR1lMRVZIVGdxaDhDWFlOWUN6NlZy?= =?utf-8?B?ZWRaK2JsVEptTnRPOUxmU3pKRE10MlVQQWRJeUhXbkhyaW5iNnY2eHBSUGZ0?= =?utf-8?B?eXFYMkE1U0d3QTJKWEFHOUcyM0NnY1NkM25Ddno4aEJOTXV2OEdiMC9Ga1Ny?= =?utf-8?B?Y1JidnBEMFRYTDZaL1VoeEI3VjNFTlVWQXY1MnJXNDZmK1BrY1l4UGdvUkpY?= =?utf-8?B?endUamhvdW9LakgvbDQvbzhocS9zYnJhT2hOQ3BtejBOSm43TzBFT1poQmsw?= =?utf-8?B?SHI4cUNaUFh6QktFRC9BOVZOQW80dnRXUVlRLzBVbDBLQkxENm9DOWc1Mnly?= =?utf-8?B?TFk5TkVUa3ZzS1ZKMjZGSG8xT1ZOekltQ0NoYTV1TkFIeVJ4N2F3N2pLU0dN?= =?utf-8?B?WHFwWlE0YU41YlVNYm93Z0FJeHN2SnVOV1hMNldBdHBtc0VXZEVxT0NkT1FF?= =?utf-8?B?UEQxUWdONUsyVE5QSmZTSzdwVnRsUGpyNzg3NFFtaTEzTkZjOXRFb1dXVVl2?= =?utf-8?B?cUV2Nnd3azgrT0drcThUU25pMWRxWjRjR3JYK0pMcmZOeG5XemFSM1BTNm16?= =?utf-8?B?bnU1TXp6dHRWYTdGTVVIN0dnd21BcE44aUhQMEtpelEyN0dlL0gxVE1sN3Rk?= =?utf-8?B?TTgxNjBuanpldDkrQ3dsRUxKSmdFbEc2V05pVUZReVJxSmpONmNlU0pyWFI3?= =?utf-8?B?ZmtoVVgwNHNsMGpOVEdnRWVWT0ZySWM3bUtRYW9sRVF3cVE1TkhzdHZKVmVV?= =?utf-8?B?dXZER2s5MjY5LzFYcXNFRTErV0tlaXJzdlJDSUc5YURJb1pMdFdxQjRrS3Mx?= =?utf-8?B?cmhLTUxOcnhLNFc2WWVvS0pxdEVLQjkwaWpGcithKzBQK2xyaXNWUUZaam54?= =?utf-8?B?NzZxU3I3MGMvV3Z5bmk5UnVadGY4UTBpYXhnVGFtSXlBVWhDby83bk0rVjNB?= =?utf-8?B?d1lrb3A2OVdKTGI4QXdBT0xQc3VTeG9rSHlONFozZ0pENHQ2UVZwTmlPeSt1?= =?utf-8?B?bUgxV05GdERZYzZvdW9hR2Y4RXF2bHJJYWd1THJaNDlHWUk5VFFHTkswellz?= =?utf-8?B?NHN6M3psTldlN1I3eTEyZklka1lsa0lVYWZSSmxXT3NkK25GOVF1MldQUGM2?= =?utf-8?B?WFA3UENIZFVETXNEQk5SeU9aRSt1RW5IdWhaZEpoc0lMZTUwRXVNTmFiS2Q0?= =?utf-8?Q?G8QxtZ7pPKWPA4f3V1zPCno=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3f778415-791f-41a3-acb8-08d99923a96d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 08:27:49.7547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iZVbHThqe6EruagqWScpNcE0TJKaWnQeQtc6o2B5HPFxzkf4AoVOOqzKWVyeXCU+TBLUG5TiPBqCo+gEK6CmKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] net/memif: fix driver init with default MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2021 9:47 PM, Stephen Hemminger wrote: > On Tue, 26 Oct 2021 16:38:01 +0100 > Ferruh Yigit wrote: > >> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c >> index 8cec493ffdb9..cbc99067c1c8 100644 >> --- a/drivers/net/memif/rte_eth_memif.c >> +++ b/drivers/net/memif/rte_eth_memif.c >> @@ -195,7 +195,7 @@ static int >> memif_dev_info(struct rte_eth_dev *dev __rte_unused, struct rte_eth_dev_info *dev_info) >> { >> dev_info->max_mac_addrs = 1; >> - dev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN; >> + dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_LEN; > > The cast is not necessary here. Not sure why the original code had it? > ack. I will send a new version to remove the cast, since touching those lines.