From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD3ECA0577; Tue, 14 Apr 2020 08:35:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 249B81C119; Tue, 14 Apr 2020 08:35:55 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 640041C118 for ; Tue, 14 Apr 2020 08:35:53 +0200 (CEST) IronPort-SDR: Mm4XLA7AmR9KI3tTE7y0K3mCMDaMCvUPWaNP+nHv9YGfNX92yBblpuofm/n6XaaFq1DzU063TG yN9eD8fTsn0w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2020 23:35:51 -0700 IronPort-SDR: B+CHloT4I2vtXmPLjRKrmoQng7TqcPAGI3Yqp6RX9ieZ0zuumxTgP9ZIDBlkAugmmXAEO4CCy9 4Q/u5cYyeSLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,381,1580803200"; d="scan'208";a="288123292" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 13 Apr 2020 23:35:51 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Apr 2020 23:35:51 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Apr 2020 14:35:49 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 14 Apr 2020 14:35:49 +0800 From: "Zhang, XuemingX" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Yang, Qiming" , "Wang, ShougangX" , "Ma, LihongX" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset Thread-Index: AQHWETW/LjAjHwCjJ0aSP6/Pp9wA0qh4EnFwgAAPwqA= Date: Tue, 14 Apr 2020 06:35:48 +0000 Message-ID: References: <20200413013839.71374-1-shougangx.wang@intel.com> <1027ae0f2b914553a602ff46967c8a98@intel.com> In-Reply-To: <1027ae0f2b914553a602ff46967c8a98@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Zhang, XuemingX >-----Original Message----- >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shougang Wang >Sent: Monday, April 13, 2020 9:39 AM >To: dev@dpdk.org >Cc: Lu, Wenzhuo ; Yang, Qiming >; Wang, ShougangX ; >stable@dpdk.org >Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset > >It's a normal behavior to change the link status to up after resetting the >port. So it is unnecessary to set link down before starting port, and >changing the link state(link up/down) frequently will cause link speed >unstable. > >Fixes: c3f2fbff78cf ("net/ixgbe: fix link status") >Cc: stable@dpdk.org > >Signed-off-by: Shougang Wang >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >b/drivers/net/ixgbe/ixgbe_ethdev.c >index 23b3f5b0c..206358b85 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -1196,7 +1196,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void >*init_params __rte_unused) > diag =3D ixgbe_bypass_init_hw(hw); > #else > diag =3D ixgbe_init_hw(hw); >- hw->mac.autotry_restart =3D false; > #endif /* RTE_LIBRTE_IXGBE_BYPASS */ > > /* >@@ -1307,8 +1306,6 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void >*init_params __rte_unused) > /* enable support intr */ > ixgbe_enable_intr(eth_dev); > >- ixgbe_dev_set_link_down(eth_dev); >- > /* initialize filter info */ > memset(filter_info, 0, > sizeof(struct ixgbe_filter_info)); >-- >2.17.1