From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E15057D6E for ; Mon, 29 May 2017 19:43:28 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2017 10:43:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,415,1491289200"; d="scan'208";a="267757238" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by fmsmga004.fm.intel.com with ESMTP; 29 May 2017 10:43:27 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170526183941.80678-1-ajit.khaparde@broadcom.com> <20170526183941.80678-9-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: Date: Mon, 29 May 2017 18:43:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170526183941.80678-9-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 08/25] bnxt: Add support for VLAN filter and strip dev_ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 17:43:29 -0000 On 5/26/2017 7:39 PM, Ajit Khaparde wrote: > This patch adds VLAN strip and offload callbacks. > To add a VLAN filter: > For each VNIC and each associated filter(s) > if VLAN exists: > if VLAN matches vlan_id > VLAN filter already exists, just skip and continue > else > add a new MAC+VLAN filter > else > Remove the old MAC only filter > Add a new MAC+VLAN filter > > To remove a VLAN filter: > For each VNIC and each associated filter(s) > if VLAN exists && VLAN matches vlan_id > remove the MAC+VLAN filter > add a new MAC only filter > else > VLAN filter doesn't exist, just skip and continue > > Signed-off-by: Ajit Khaparde This patch gives a build error [1] which seems fixed in next patch, can you please move fix to this patch. [1] .../drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_del_vlan_filter’: .../drivers/net/bnxt/bnxt_ethdev.c:1158:8: error: passing argument 2 of ‘bnxt_hwrm_set_filter’ makes pointer from integer without a cast [-Werror=int-conversion] vnic->fw_vnic_id, ^~~~ In file included from .../drivers/net/bnxt/bnxt_ethdev.c:46:0: .../drivers/net/bnxt/bnxt_hwrm.h:51:5: note: expected ‘struct bnxt_vnic_info *’ but argument is of type ‘uint16_t {aka short unsigned int}’ int bnxt_hwrm_set_filter(struct bnxt *bp, ^~~~~~~~~~~~~~~~~~~~ .../drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_add_vlan_filter’: .../drivers/net/bnxt/bnxt_ethdev.c:1232:35: error: passing argument 2 of ‘bnxt_hwrm_set_filter’ makes pointer from integer without a cast [-Werror=int-conversion] rc = bnxt_hwrm_set_filter(bp, vnic->fw_vnic_id, ^~~~ In file included from .../drivers/net/bnxt/bnxt_ethdev.c:46:0: .../drivers/net/bnxt/bnxt_hwrm.h:51:5: note: expected ‘struct bnxt_vnic_info *’ but argument is of type ‘uint16_t {aka short unsigned int}’ int bnxt_hwrm_set_filter(struct bnxt *bp, ^~~~~~~~~~~~~~~~~~~~