From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F0EDA0471 for ; Fri, 16 Aug 2019 09:51:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 257A21BE93; Fri, 16 Aug 2019 09:51:15 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 43B7D1BE91 for ; Fri, 16 Aug 2019 09:51:14 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D7C0468005A; Fri, 16 Aug 2019 07:51:12 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 16 Aug 2019 08:51:00 +0100 To: , , , Ajit Khaparde , "Somnath Kotur" , John Daley , "Hyong Youb Kim" , Beilei Xing , Qi Zhang , Jingjing Wu , Wenzhuo Lu , Qiming Yang , "Konstantin Ananyev" , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Nithin Dabilpuram , Kiran Kumar K CC: References: <20190816055511.2322-1-pbhagavatula@marvell.com> <20190816055511.2322-6-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: Date: Fri, 16 Aug 2019 10:50:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816055511.2322-6-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24850.003 X-TM-AS-Result: No-2.244400-8.000000-10 X-TMASE-MatchedRID: scwq2vQP8OEeimh1YYHcKKfOxh7hvX71UHV7v8X++rkZFDQxUvPcmKV8 RkjtRp4uL7y59K1QGD+4A3csSqVso9F/tAhYTSzXzG0LtXz4gg/r1pL7v/NuP6q9wgXVNwtgrr5 TE4GLzk2VSSgyW5ZGK2LKGUqcgEDoAyPdSNDdGO8D2WXLXdz+AVRjDXDWzDXT9imXleSBUWOguO sKaAvY9bBHT/mFjwlj576Jw4IaYsbUxcsh+ite354CIKY/Hg3AtOt1ofVlaoLWRN8STJpl3PoLR 4+zsDTt8fxdFDBKE7uKTmDxQix0VCcOAtmnsKq5IIevnxBqKR6tsugkyL1/I/DTBEow0LEYIU2y 2waSSA31vBD2KM1r4HGVSA+iRvsqo2cA6xc+cLlR029mOM6P0LrcE8xytxC5d5hZXZFoB8P6SR/ oeE+wFw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.244400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24850.003 X-MDID: 1565941873-DPj2cGBEw5rP Subject: Re: [dpdk-dev] [PATCH 5/7] net: update Rx flow action offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Prefix "net: " is typically used for lib/librte_net. It should be "drivers/net: " here. "Rx flow action offload" sounds strange. May be "Rx flow mark offload". On 8/16/19 8:55 AM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_FLOW_MARK flag for all supported NICs. "all supported NICs" sounds wrong here as well. It sounds like all NICs supported by DPDK. > Signed-off-by: Pavan Nikhilesh [snip] > diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c > index 695580b22..0f842e9e9 100644 > --- a/drivers/net/sfc/sfc_rx.c > +++ b/drivers/net/sfc/sfc_rx.c > @@ -619,7 +619,8 @@ struct sfc_dp_rx sfc_efx_rx = { > .features = SFC_DP_RX_FEAT_INTR, > .dev_offload_capa = DEV_RX_OFFLOAD_CHECKSUM, > .queue_offload_capa = DEV_RX_OFFLOAD_SCATTER | > - DEV_RX_OFFLOAD_RSS_HASH, > + DEV_RX_OFFLOAD_RSS_HASH | > + DEV_RX_OFFLOAD_FLOW_MARK, > .qsize_up_rings = sfc_efx_rx_qsize_up_rings, > .qcreate = sfc_efx_rx_qcreate, > .qdestroy = sfc_efx_rx_qdestroy, In the case of net/sfc it is supported by sfc_ef10_essb_rx only (drivers/net/sfc/sfc_ef10_essb_rx.c).