From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3F2342EAC; Tue, 18 Jul 2023 22:24:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9812242D81; Tue, 18 Jul 2023 22:24:07 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2056.outbound.protection.outlook.com [40.107.100.56]) by mails.dpdk.org (Postfix) with ESMTP id 5EE49410D3 for ; Tue, 18 Jul 2023 22:24:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNjzuH4cg6xXUByVx0hyXWS1alBLOdK/I0b22oUl8Cl0XD/rCUnRTWo9rLQ798T60yXxSJy5KdWiS4Qa8WML0mR+xbXOQneLG2sP0qAf+eU/8EZ5cSdgP0IeuB9M6RVA9BeH/Z2+6ly8kxImvB4KvgpcrwUEHMQn5RFFeF8FVpl0PHDPBYw3vN4vDFfM5vo5q9VetUEaEXxImQKTXcgwpQQEn9TM/urca5NULJw8G8oFkfYliU2Mg4RWzd7G5WqLGhxvrTlLmO4T7dQKY/TxY0sMmqaa6eyvSvzarRJ0iyi63FbAlXPUba1yUXE+bb/vjYb85KScjk5uG7JaZ2avsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dwksGzRy6apXohvwJeEkOWUBp/hAFNkRUoRCgtkkiBg=; b=ZO9bHrhbzQ95riohyRvzGxEeVErJbFkpjLS6iCjPHqDCl9XggR5Ag78xuw7wyx4IEI63uRu08q5HDV2XB8+jLzeKBdj+Js6KlGChpbkMOmSTpbMuAzlB4hje78ktALt2iXvmQmPLGiz1dVjddTwcYFrXM/8MbS2wIvOlG+PP2b0g+lr17jEAczJ8cKlGGK94Kj4o40IylYRpEai/eTpJreYaE9i63eZikyaL71q/QhOnSX8m08OhGWLdMtsnxTFWtW/9EHz1+jPCTRTOis2xPg5Shk+zv5MNeDxVpSObVASzYrckgDwKqzmFTnXOkS2Fng7+1O39Ugp4c/APGkAywQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dwksGzRy6apXohvwJeEkOWUBp/hAFNkRUoRCgtkkiBg=; b=ba9YWZfAlrUW/bGSwRSi+dt4VZF/pN0kiF3y2442aabTTCbVFq9hPdz+3povHRiXR6m7h35U6wwGlVXl3hU06tj5V02JMtlkvKx9eLUCcFvmLqTgP4y3/LJVjx/1i23WXjPvCws8BS33O7W7QCm6yPsihqZIfdjs4d5KIAoQhVw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6887.namprd12.prod.outlook.com (2603:10b6:806:261::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.28; Tue, 18 Jul 2023 20:24:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::15a9:4e83:4217:8b49]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::15a9:4e83:4217:8b49%7]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 20:24:04 +0000 Message-ID: Date: Tue, 18 Jul 2023 21:23:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/2] doc/contributing: provide coding details for dynamic logging Content-Language: en-US To: Bruce Richardson , dev@dpdk.org Cc: david.marchand@redhat.com, Chengwen Feng References: <20230613143355.77914-1-bruce.richardson@intel.com> <20230718164802.110560-1-bruce.richardson@intel.com> <20230718164802.110560-2-bruce.richardson@intel.com> From: Ferruh Yigit In-Reply-To: <20230718164802.110560-2-bruce.richardson@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0089.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6887:EE_ X-MS-Office365-Filtering-Correlation-Id: 154c1d8e-aa7f-4395-8d12-08db87ccee43 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8C4lg28SQeQzn/D/IErknWnq0dy9MXkWAuihpduaafVbQGydPFUPidwcv2L8i6iMfUAcloqUU0uLYA4KqiIzaoCxngnr9hFnEzEt44ctry4YAnKIuxJXYivhVYvaLspgbzLKCBgVqCgrfEK7j6JNECNjhuvWx1pYl0BwqcLdLp86BUU/RBu2vTFJIl4V4dodADYmCRK6rayqJbLi6p2ox0EKfs6NkkgQpZjTvPAH8jnAVP6A34SRVCP04XXurrOUxzu5N8sGytUz0M7+I17EAf2LyMXUQigH6vCdx0N33/yupmnrn8XaPc/lcH9QKdFE31dQpY8ip3TkA2628MfiRzJFlRnqrNAR4Y5XrSF54c7gzSROCJ11L3fFmr+FzvsMsZBDf0iHGgygB4ii6luXA7Z0Wllc2NrOtpLtmCE7oL/CQGpr6rO/qkbG4+oU3S0RUFfvOuuRpCqZYSuSh8CVj/2lAphl9oh5Sol8ahu4ed1ymS3cx0rl0XP9YpRx2vQ9315kEJefXl2v6Ywk7KlKlFJVm/Xztsd6qCMi/FjWllqYXAATSGzb87gVQN2qsZ1BvIwHePwVeefCSQ4EACDvrc5muNmHu4xkzmTfioHWyAhpKpztUaMZhhP/I1Kig7bE9dUOJ/gboLDp/SEtj6ttLg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(451199021)(31686004)(478600001)(6486002)(6666004)(2616005)(31696002)(86362001)(2906002)(4744005)(186003)(6512007)(53546011)(6506007)(26005)(38100700002)(44832011)(66946007)(66556008)(316002)(8676002)(5660300002)(66476007)(41300700001)(4326008)(8936002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWhoZmRxZ1BEcTl4K2g0YUtDeDBzMFZMM25iRHkrUWpaNXYvdDFOb1g5a3ZM?= =?utf-8?B?bEk4L28yWUQxeWZodWd2TENQR3BPODA2czJwVmtZajRLMnNLZXc2SnVZRUZP?= =?utf-8?B?VklqWWZZazNORjA0SGZBQWRaalpvR1BzQUZ0RGFBNzJVK2hZUVhJanB2Y2lR?= =?utf-8?B?S2EwUHAzTUR6TExUY3ZCWE0vdjJ3VnZEZ1RQQ2NSNzZSblRIVGNRM01TWUtn?= =?utf-8?B?M29kQmtpNit0cHdQRkJJM0xJV2RKUStsYlMxcDVzVlZMdGJTOCswR1ZOMXYv?= =?utf-8?B?YVJBY1RsRTU1ZDI2L1M1YTVyN3ZlYXNWeHIzcXhHeGtUc2w5aFhiN1czWGQ3?= =?utf-8?B?eEoyQXRJMGM5Vm42bGhzRGZsNGFKcFFaejlvMFlZMGhqKzNoMGNWK3l1bVMx?= =?utf-8?B?cUpSZmt6eXRRSkZUU0tPOHdTUm1DOVFFWFMxRHJ5Y0VUQ1QzSFBNamY0Z2I1?= =?utf-8?B?QzBkUExUWmd3TFhMOVZWUGU0dFcwdlR2bGtzWllwa1QzSm9Ld3M0UkNRSUNj?= =?utf-8?B?OFVmMGoxMTlFYzk3ZGU3SzREOHNqMVZ6a2dxYmVjMHJsU3lSanlxUUhGZ2Jq?= =?utf-8?B?TEViaEhoQUdCTjBFUzlldUxlcUpiUzBHLyt2REFkd2J0RlFsRi84a3BpcHlR?= =?utf-8?B?N2h0OU5DRnFpSG1BTEFDVmEvVFAyaVRPV0N3cWU4c1lwdXAzRUswRkRaUGNh?= =?utf-8?B?dThsRUhNTFB4NC8wOXhkd2t6bndOaGpvaktNUGNDSGl6TTJXL1BiVmlNb0NT?= =?utf-8?B?T3VUWmJQekg3V3JBOHVicmpkOVpBUlpqV3RGMVFoekhQOXN6dm5YSWxjQzhD?= =?utf-8?B?ZkxwMTE3RE1yZHZidm5UbG1UZEMyckpnT3JrU3JXM3pjejFNYW03SDJqSmYx?= =?utf-8?B?SU5sUjRFNWd1Q1Q2UmVXT095UUw1a2ZudUU3MStxZ3pHZzdsYVBVYVkxOXIr?= =?utf-8?B?M09CSktFUzVuYXB3NzdHem5ncklmT2FmNGYxd3lrT3Bvb0VnSWZETlY3UTBV?= =?utf-8?B?UFdGSDkvNmF0dmIrOWQwWlNmQjdiVkVqanBHdExSeGhrUkVPUFIzSVc5T3pZ?= =?utf-8?B?Rk85c1BEdVFNdUhsdldEN09FeEVrdm9BWnJZdnNhZUIrckhzRkRvQkJyVlgy?= =?utf-8?B?Zi90N2lJcTFkdEZFaDdqcFdacm9TUGJIVU9LUG1XWUptNTk0YkNoTEtYdzNU?= =?utf-8?B?dVhPUUszc0tqL2ZWWFBmRnRpNkdqSUR2TFRlTjdWOTVDOFdoT0VHdTZ4YTls?= =?utf-8?B?YjRIL01LckpCV0NEWmtSeFNnMWdLTjBxUkJ4cmZIV3g3WEpDKzJkSUpTbmpL?= =?utf-8?B?bi9lSkorOHJSbkNNRGZaK01meEFzTGUzY295bW9Sd292Q2kyQ2wrMlBoV3ht?= =?utf-8?B?NlREQ3Mrbm85Rm1RZmlBQ25PYlB5blVSeTZwRjcwK0dXMlFJMGwwZGRiaVFX?= =?utf-8?B?dWk1YXBSQjB0WWloaG5XNnB0dFRweE0ybElrODBLdWFWc0VoTmVTbmtvS2hi?= =?utf-8?B?SmgzK1hTaEY4WEFCdWxBMUpQNHREbWpycXNxV0tKYXV6dkxON3I0SnUyUXpV?= =?utf-8?B?M3grV3NwTTBRYUVCZGZOUG9EdFJoMUtiV0lZT3NnN2M0d0VkV2VvZTcxLzc5?= =?utf-8?B?RUMzbFIxUjhHMGFFTUxjRmV5cm56b1lFa3RFdzVucDBWb1pHZTJ6SmRVYkpp?= =?utf-8?B?TEMrR1AzcHRUdTlqdFkzUS9iVXBwa1g3dEdrd0VJN09aSkcyL2liWXFtNHBJ?= =?utf-8?B?RXdNdk9FN29TQjVqbGxjOVdTOGJ2VGplVmRQZmlVeEplalhzVGJnK0ExdGRM?= =?utf-8?B?L3BVa3ZMWFQyQmd0eEZPMEQ5b1VVTk9IakZsQjRqaHROYm5rTWg0ZTVFL2hp?= =?utf-8?B?aHRzZkRsMjJ2T2FkY0N6b05kVjVqc0RTYnBNSWgzUGRoTkJWYlNCdWg5eDVl?= =?utf-8?B?c0c2T29zbE5MdENMZHE3N1dMT0pNczRWWFBGQnIvdml6dENrSTZHV0t0QThW?= =?utf-8?B?TW0rTUVCK2RnRXllOGI0cnZiTlJENVpHVE9SMEhVMGU0SVBzWmNIUXpSQXYx?= =?utf-8?B?M3M1TzlyeXBKOU9Md1UxQmJRQ0xqT1Mzb001OW5OMXNLd2w1Uzd4bXAyZWRa?= =?utf-8?Q?mSzAZxrPQAgnvAcWbocavE3bl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 154c1d8e-aa7f-4395-8d12-08db87ccee43 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 20:24:04.5654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gwADgCxbexCD49zWbhakGoRNedz+H9CghYJWosDYHjHBR8jEsbElPqgeNZqOpLc7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6887 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/18/2023 5:48 PM, Bruce Richardson wrote: > While the section on dynamic logging in the contributors guide covered > the details of the logging naming scheme, it failed to cover exactly how > the component developer, i.e. the contributor, could actually use > dynamic logging in their component. > > Fix this by splitting the details of the naming scheme into a separate > subsection, and adding to the introduction on logging, a recommendation > (and example) to use RTE_LOG_REGISTER_DEFAULT. > > Similarly, when discussing specialization, include a reference to the > RTE_LOG_REGISTER_SUFFIX macro. > > Signed-off-by: Bruce Richardson > Acked-by: Chengwen Feng > Reviewed-by: David Marchand > Acked-by: Ferruh Yigit