From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13D84A04FF; Wed, 4 May 2022 17:09:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2C3840C35; Wed, 4 May 2022 17:09:36 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 910DE4069F for ; Wed, 4 May 2022 17:09:35 +0200 (CEST) Received: from [192.168.108.214] (unknown [188.170.87.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A0F7F82; Wed, 4 May 2022 18:09:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A0F7F82 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1651676975; bh=pmAiwByW9+shfhprrZtbl/sh05P0KDLLHM3lrAqd4CA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E+hl2HCXSTnEujXf78CNtu8qsMBRDXBDkjax9lDFoVM2ZmRpnhe5oF83g1n6qrEKA VE3XKy3iSCou4aDKLHZ8F8n5IAb9UfYHp7WqeHb0ZivHuAj+pVvzT7A208u87Oc9TN yoZid8pCPfGKuaila9QBTR2LH1jJK+8/w33vSsNI= Message-ID: Date: Wed, 4 May 2022 18:09:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature Content-Language: en-US To: Pankaj Gupta , jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org References: <20220503042257.15626-1-pagupta@vmware.com> <20220503042257.15626-9-pagupta@vmware.com> From: Andrew Rybchenko In-Reply-To: <20220503042257.15626-9-pagupta@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/3/22 07:22, Pankaj Gupta wrote: > Fix merge error in initialization for rxDataRing feature. Is it a bug fix? If so, it requires corresponding "Fixes:" tag and Cc to stable@dpdk.org in order to be backported to stable releases. > > Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. > > Signed-off-by: Pankaj Gupta > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index 9955f121f6..6ced76ae2a 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -876,6 +876,11 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) > rqd->conf.rxRingSize[1] = rxq->cmd_ring[1].size; > rqd->conf.compRingSize = rxq->comp_ring.size; > > + if (VMXNET3_VERSION_GE_3(hw)) { > + rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA; > + rqd->conf.rxDataRingDescSize = rxq->data_desc_size; > + } > + > if (hw->intr.lsc_only) > rqd->conf.intrIdx = 1; > else