From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3466E2C54 for ; Wed, 12 Jul 2017 16:18:44 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jul 2017 07:18:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,350,1496127600"; d="scan'208";a="125690254" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.130]) ([163.33.230.130]) by fmsmga005.fm.intel.com with ESMTP; 12 Jul 2017 07:18:43 -0700 To: Andrew Rybchenko , dev@dpdk.org References: <1499528715-1510-1-git-send-email-arybchenko@solarflare.com> Cc: Ivan Malov From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Wed, 12 Jul 2017 15:18:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1499528715-1510-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/sfc: add support for xstats retrieval by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 14:18:45 -0000 On 08/07/2017 16:45, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko [..] Reviewed-by: Remy Horton > + rc = sfc_port_update_mac_stats(sa); > + if (rc != 0) { > + SFC_ASSERT(rc > 0); > + ret = -rc; sfc_port_update_mac_stats() really ought to be returning -EINVAL or -ENOMEM rather than EINVAL/ENOMEM then doing a negation here. Other than that, code seems OK..