From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1374A0A02; Thu, 13 May 2021 15:26:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B69974067E; Thu, 13 May 2021 15:26:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E177C4003F for ; Thu, 13 May 2021 15:26:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620912387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tUflJKuXuya5qmg0oQlKZ2UH3Ue6YA+tj+wcGs+agyg=; b=ArhVqBu7gX4oSthJ5dVKEHlz8MeynlvWgV1V4MgLzfFC+jbqk/8CAKgvUkQ7EzZADTNsTa YB6F4ADSiaf8cBxjnc5DXpZdSaLhMCMWd4OC3yP1ExvE/Schr6szTNLGaWOx+cD9o7MfCG XiRJNK2ItjUi1VH2iQ97b58usFCzCJA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-sBpje60TM4m1VAjPlRzRWQ-1; Thu, 13 May 2021 09:26:24 -0400 X-MC-Unique: sBpje60TM4m1VAjPlRzRWQ-1 Received: by mail-wm1-f72.google.com with SMTP id w7-20020a1cdf070000b02901698cfc1c04so985249wmg.6 for ; Thu, 13 May 2021 06:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tUflJKuXuya5qmg0oQlKZ2UH3Ue6YA+tj+wcGs+agyg=; b=YkCTlSu5kxT/iyZD60oXTZl7fRuEjDh7K1nwittGH842al79E5K+/rFbtPXAnvpa4m XD/uzTL/qjjmwdhAtzIsWH9vRPdEDj7omTDLuX56FsRpaVgnKCAus3YuxqCj/0W72XtB mfudI5BoIDi0ArWgJiymrdzi5VWreJhkr1YRYA2EhgBKrc8oTbQZmUR+bd4lzBHY/Tcn n9SsFZt0iyW3rn0VNgwDr2iSVZlLuulTtAopWdLXY6jkCgM7YRdcQkDrS2AaR/QldMbO Ao1AbuAN2JnzdiaPcOUcoeRvYgkyQj0qPfvlvV3/XxOxtuHTubpgpPmte6OXNj1rFBqP ApZw== X-Gm-Message-State: AOAM532TexuN6NOUpJjH+p3E6DZVa5kBwHmnAQuU1pjQP/wvlYGYMEAo +LgZAy5H20Cnue44lQ+SK4Ns6N4FYSFPQjDXxv1fMxfhxQrxISa1QzWYRWQ2PqFKwjqm+kdj8OU XkOc= X-Received: by 2002:adf:f683:: with SMTP id v3mr51113447wrp.133.1620912382959; Thu, 13 May 2021 06:26:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxVUT9SNtXhf+Gpmho8pxW6S2akVe36By73Uo+xhU67EJd7KukiEp9jwoNqSFVyK6bw+7w9w== X-Received: by 2002:adf:f683:: with SMTP id v3mr51113432wrp.133.1620912382799; Thu, 13 May 2021 06:26:22 -0700 (PDT) Received: from [192.168.0.36] ([78.18.27.43]) by smtp.gmail.com with ESMTPSA id n20sm2215395wmk.12.2021.05.13.06.26.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 May 2021 06:26:22 -0700 (PDT) To: Ferruh Yigit , dev@dpdk.org, maxime.coquelin@redhat.com, david.marchand@redhat.com Cc: Thomas Monjalon , Chenbo Xia References: <20210513122826.49910-1-chenbo.xia@intel.com> <16af9049-f7b5-f4f8-a6f8-6897e904591f@intel.com> From: Kevin Traynor Message-ID: Date: Thu, 13 May 2021 14:26:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <16af9049-f7b5-f4f8-a6f8-6897e904591f@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] vhost: fix wrong IOTLB initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13/05/2021 14:10, Ferruh Yigit wrote: > On 5/13/2021 1:28 PM, Chenbo Xia wrote: >> This patch fixes an issue of application crash because of vhost iotlb >> not initialized when virtio has multiqueue enabled. >> >> iotlb messages will be sent when some queues are not enabled. If we >> initialize iotlb in vhost_user_set_vring_num, it could happen that >> iotlb update comes when iotlb pool of disabled queues are not >> initialized. >> >> Fixes: 968bbc7e2e50 ("vhost: avoid IOTLB mempool allocation while IOMMU disabled") >> >> Signed-off-by: Chenbo Xia > > > Hi Maxime, David, > > Can Red Hat QA verify this patch please? > I've requested for QA to test RC3+this patch. > Btw, the issue is for defect: > https://bugs.dpdk.org/show_bug.cgi?id=703 >