From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 455BE45B4A; Wed, 16 Oct 2024 07:15:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03AAD4021F; Wed, 16 Oct 2024 07:15:53 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2079.outbound.protection.outlook.com [40.107.104.79]) by mails.dpdk.org (Postfix) with ESMTP id C4DDD400D6 for ; Wed, 16 Oct 2024 07:15:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RN79O9jcWwvFeyxR4wWYt1dwBQEbKEpJaNPByYg59XR6nwcpAdwdTMQCi94rSbVdJBY1z4qFqt+wONtFB6KPka18ZiCKgBFSCc5woQUGcIpyYmHYiwdyHsnuyxS2aHvj6acr9PybgXTKhirchbPGXTkVzMjRC5VlvUc4vVrRIad11w69YtToV4mZWdOpj6XoP7jJFXXdSM8IIK0nQAdboAmNNYKyPnaphwLM7F1v8jdskTSYgXaF45Aip923nZR9nE4ZwClT8qm7RoAa4xc0zoCg7VDxdoikGkjEg32j0TFbKWrXU61koJhdAJ9PMwUjBk/k6X5Hkw/m0zfwlB8AMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZANMnyNrUQo7bkyet+NAGrSIIeRRa8TyxZ1Bx1BjpOo=; b=EwOQOQYG4oiuRz2JNZfCG4DB+edBJYpXrJiN90z0wnz0XcwABjP5goOEdT61JyPpqIYJGSf4DDdm+o6uzK3XtxX6GQ8mOam76/rNyFb14/da8Oa8mbYkS6u6Iyf84JWKchKgKhOTrFCL/DDByO+p7Ho704MFRZ1kmoCCQ1wQYPx9PyTGlb91iIYnsCeig9Y7iE8m8DedlYszrX/I1hcDGZ24hpdQJd6eCFk2w2kxFpRR8HDGlBKg0SRrTeXZKOzDWbUz4TTcLLtwxiv8EquyqvFCiz//lOYWEuXyxk54iwe3JA3G2P+x1nvnJcGXApO6PRvY/HZyIpXOUMcI+BUtjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZANMnyNrUQo7bkyet+NAGrSIIeRRa8TyxZ1Bx1BjpOo=; b=fjAtxw/RiJFc60q+M8fALLvMeLtFhBf4WiUUATUIiZJ9WKSraosHgZct6L6/12wl8db5ifMs4rIPMpdsbmUfcdjSIKWa6V82iESISyBx8BNosI4t470WWdEmQoYqpSgyy+jtMwJ5Kuf8YsOncmvm8N4DY4txaYfZQpLIQGvlXu8uSN+fgCbqSIQUC2h1j6C6d6Vq/MK0glBEieLl3HjKz97OKFKMH0t6sOCgwBuo5ZYo8/J7OfgOm5TJV66qFxDbewscB0XbVCX16khyynuB1RtPbBbNdN8WQVTH+q7qUK1BvN7b5Sg6E5tEtlWgorR/DSTmpX2iJcJuIkifzimpUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by DB9PR04MB9329.eurprd04.prod.outlook.com (2603:10a6:10:36f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Wed, 16 Oct 2024 05:15:50 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.8048.020; Wed, 16 Oct 2024 05:15:50 +0000 Message-ID: Date: Wed, 16 Oct 2024 10:45:44 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [v7 02/15] dma/dpaa2: refactor driver code Content-Language: en-US To: Stephen Hemminger Cc: Gagandeep Singh , dev@dpdk.org, Hemant Agrawal , Anatoly Burakov , Jun Yang References: <20241014093639.553467-1-g.singh@nxp.com> <20241015071403.1940833-1-g.singh@nxp.com> <20241015071403.1940833-3-g.singh@nxp.com> <20241015151137.50caf3be@hermes.local> <20241015221321.04275629@hermes.local> From: Hemant Agrawal In-Reply-To: <20241015221321.04275629@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN2PR01CA0006.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:25::11) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|DB9PR04MB9329:EE_ X-MS-Office365-Filtering-Correlation-Id: 9577773d-ef19-42bf-d230-08dceda19951 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MVpXcnhJL091RlNxSHNnbUo2ams5UXlPc0J2NjFlZnhQZ3ZTUlF4TzY4TzJm?= =?utf-8?B?K3BYb0N5Wlh0WUN1R3o1bkppYTdKb3JjU0FKUUFsYStPUXpiM20reE1xUk1j?= =?utf-8?B?MmI4TU1zSjY1WHc5V1BPR2p4cU9kL09pUE1GUXU2Szd6UW14Yk5qUUIzaWRF?= =?utf-8?B?WStxQVF1aGMvcVIrQVlwNHcvWGRPRURnalhDUnVjN1VaaHZ2QnAzTzNjZXd0?= =?utf-8?B?NkcrU1BjNThkejBrcllCSm80dnQ4WVN4SjZOellYNWM0cmovbUxnR1Q1WHNn?= =?utf-8?B?eDJXbUVtUm9iN3o5ZWg4c0ZYR3pKL2dnNDh5UjdoTkZtbE05TzlFSGpuZDJx?= =?utf-8?B?TW1CMGhzVlVVOXJlcm1LKzFDdFJCWUQ4cFlwUHJPejh0Nk5heHQ5Q2hoUm8v?= =?utf-8?B?bG5jdWdJQWdZOE1GVDlOM3JMMm9EQUk3R0RWQ0MxUWpZVmNwTXZaQS9GYnV2?= =?utf-8?B?TjdnS0ZMbkdQKzN1emkyTHlzM3JHVkNzSi9rMXZiamszRUhqMFFhYVpPcE9B?= =?utf-8?B?RGV6NEp0SzdxYzQxc3BoRFNTbGNtUkxFbzVCclcxSU5jczAzOXhoQmtaa09X?= =?utf-8?B?U0ZzMGlNbE5GRFBvd242WW5pVExYYTNGK05zS2ZDNEltTFZwaWxlOFNKbnZk?= =?utf-8?B?QlRXNHFFcFNFQjBjSHFaU0NkU01JWnVyalJpeHplbWVERlZJY1lRUXBZSVJ4?= =?utf-8?B?ckJpaERKUi9mQmpxZGZhcmRFNkU3Smp3aVYwSERHV0J6ZGtSNzR2UGVuVHA2?= =?utf-8?B?WkpSVFY4R2JCeHdRT1ZWNGNGaU0xWjZHK1BBempYTzQrRG02aHhJNkxIZ2dS?= =?utf-8?B?WmhoTmlUYjhDN0lreS9PMk5kWTR2bndJbDNRanZaNXV4anRhUDdLSHo3dUhu?= =?utf-8?B?RjZoak9xNkdmb3FvU3hwckRINnRESUtCQnZxNXdJeGpYTUYvRHAvVE9mamVo?= =?utf-8?B?cGtYaFRLcllIb0pIV2xlOWV4c3c0eFVCZVdyQTNKQlYvM1pTeWFPNWVTeDY4?= =?utf-8?B?b2R1cUtUM2R1QklZcmN3eStCYk8vemtOcklKT2FmZmtEK3dud2JUcnYzL0Vy?= =?utf-8?B?ZjdBTGptMlNqeC9Hc2Z3OHFGQlY4bncydFZpaEtINzM2ckg2SUpMWk9ITzRo?= =?utf-8?B?RzcwcDdrZU8vZlBiQjdjWTYvVm5rMW1lYk5hL2xJdDB6bE10WVMvNmxURS93?= =?utf-8?B?L1IxcGV3UWJUWXZvWEFxZmZFRUVOUjNoR0ZCSUZrWForeGR2ZTNTdC9ZSThM?= =?utf-8?B?dDRLUWduTHZOMnFRTmdYZFppb3gyZTF4S3ViYS9Xd01rNW82ZWREdzNLTUoz?= =?utf-8?B?S29DSWxmQ2dsaDhETEgvekNGbnY4RG5xWHNUKzloYlU3TE1kcGgyUVNYa2dN?= =?utf-8?B?S1FCTlV5M1hTNDJhYjFnbXRjVDBoOHY1M2xBdGV4cVUxeUdGWXBjT2xlRC9R?= =?utf-8?B?Z242QXUyRVJxdkl1SFE4Y2JEbmtSV244UlAxMktlUm5QVDRWbXBVMjdXaSt6?= =?utf-8?B?R1RrcWpuZXdXR1JhSjEwcEJIMzRTYTgxcXZWNVI3SjRscjJMS2h1UTRnSXJ6?= =?utf-8?B?V05SZ2VhdWR0NnJKMWZCSVJ4RitPa0JDc050TUgrckFJZ0ZpeDNjcDZYMnRM?= =?utf-8?B?NmIxaC9VeHhJWGlqL055dDlWVk4yQ0s0czkzc2lYRWhwa3U2M0I5RlpDdXk3?= =?utf-8?B?Nzc1MGcrVmJQbVpseTlJdmtnSlBZeUdUS0U3SG93eFU5V0FJRVBrUm1nPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(10070799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTdFOWRjRk5jMVU3ODNaaHR2Q01RTytQZFdxVTB6NnFpc1o5VEcrajI1ODBZ?= =?utf-8?B?TlFOcThIbXNDL0czT280cm5jV3NaK2pXT2VvYkk4K2RJVEdQSm1sUjIxcit0?= =?utf-8?B?RlpJQWhXYlZZMk1waVc0NGJaZU5VNVdXRDBuWmtLcmdxTkowNVpIamh6Uk1M?= =?utf-8?B?WDcraXdoRzVRNzNVOTdnT3p0eHcyc0Fjck1SQkVCU1I4ODU1QkY1aDdZNFhY?= =?utf-8?B?NGNUYWpGK0gxR21EczE4SVplQ00rUDU4UllQaHBBZUR6Z1pOSzFaQTJuUGFl?= =?utf-8?B?c0t4YXJZd0lsVTRtbmlwS2o2Q0lzMFUrT2EvbGdmTTNXQ3Y0M3ZjdE1nUWEr?= =?utf-8?B?YmF2QzN1WjNmbHI2aStZaWdSN0M5Z01rQlNOOE9wNXZVTmgyTDloeFlpQzcw?= =?utf-8?B?ekVnZ2pBdU41bHJpOUxaZ1VjWEU2bksybmR2QmM0dWVyL3pJaEV0TzRsZm0v?= =?utf-8?B?ZDJxemM4c3F2amxuN0wzTmp5cFdmb0h2b24wYlpLdVdzN0JMOWVMTm1sWkxC?= =?utf-8?B?WkRldDRaTzhkS2NKcjAvUWdERmpBeStaSzFsTFZZc1Q3RzNLRjBVVy9EUXBO?= =?utf-8?B?c0J5b3F5MDVOMkZGakUzcENGZ0prdjBhVjZ5RXdES0J4eDRtVksrbFlhVUsx?= =?utf-8?B?R3V1VTNDcG5IRjB1V1NqNmZYM1Rmc3I4ajJUS2RFQlUybVNQNWlLOWtqTDQr?= =?utf-8?B?K0Y4Nm01dWNsdzBOclA3VTZxNWFEd3QxcVpFUi9NU1NZUS9MVHBtdXRIaGxY?= =?utf-8?B?dWVpamoxSVdLVHVFazRlUUdESGRGNGJYQjRacGJOYmJzc3pXNEwrcllJZ1BF?= =?utf-8?B?aEdKQ0lERFpCcFptQnVJbDhrS2VyR0paemlsdk45Qkw5c3FLOTdpWHhlbVB1?= =?utf-8?B?VmdhT3lZM1ptNnR6NUlNdFZTbyt4RlFDdnpTUFYxc0E3K1FVb2REL3drWDln?= =?utf-8?B?QThHdXlrQlh4Y21HMDVVdnpPbDd4YmF0L0JEMlZZNHJSRk16MFg0NytadEtt?= =?utf-8?B?THVqbjgvNmxsbU9VSDBNL2E4VjZOTGRtdEdyZldIUVFZa25tcGJPMXFrU1hs?= =?utf-8?B?eFhkVnU2UnMzVnBoeEhBbFhadm5zTThLK2NiTzNmWlMzSG4rUEZhM2dFRkJQ?= =?utf-8?B?Y3UzWFUwa2ZHRGVjc2VIMXdPZW5qdkMreVI5MnBzejdQdlBYaUprR2pyUGl6?= =?utf-8?B?L2xGQm9EQ0lSN21FM0FPeTAybEQvdWNGZkNGZ2tPT21DaUZZWnlBbW91WkRH?= =?utf-8?B?RWhDejF6VlpKNWdDT204dDdseDV1VG9DbUQvWk1XcjBWQnlkeFhaZUU3clNv?= =?utf-8?B?K29mTHpZNGpWdWt0MnJjYlFMMGhCRzhySENDSlFQdTZQekJ1Z3Z1TTNqa1RQ?= =?utf-8?B?MGlsbWR1T2ZpNTlONEdRSGVBRVJFOGxiSEVVZUVlNy9nek9xL0xOUFlxUHhj?= =?utf-8?B?S1VpMkNYbW9wTGdYU0NxRStHbHAxUFVFNVVrT3pmbVgwQWphOEkwczhmblNo?= =?utf-8?B?Sm10MFBZb0tTZGRUMm1tYUZrbjMvUHBLaUJBaWU3UGpudnNqbkY3L3plazJm?= =?utf-8?B?bjNTWG1FN2o4OVRCK3VlQVlnWXV6RjFRd2pzOHl0TGhYbnFhM3lzRlZpa2da?= =?utf-8?B?eGNidWhXR1BaZlhvVFJzYVdkVmNEbmw0NjU0VDFjYlYyc1hodEREanlUZjFy?= =?utf-8?B?L3pING85ajNwRlpneTd3RzVpTk9QL0pjY2ZPbnVXam9KRThpK2hhSGh4QzF3?= =?utf-8?B?RG92OEhDV3g5NGdVei9acTBjamtRcnFzazRpSEVwcUxBb3hnYm1pSnJWZG4z?= =?utf-8?B?aENNcWdEMzlmM0ZZQThhdnpENWxZZFBnUHgxMUs1OG5FZzk2UmJmU1dobXlv?= =?utf-8?B?dmQzUWJhR0M1blREY3RHdlppWXVMVFhkMU9wTER0K0llMVJrVHMxVlpqK1dI?= =?utf-8?B?eFpuTDRkR204MzRoOStGcldtc05IWEI3Z2Ivc0kzRk1aRVd2MjJXVTY4SWFD?= =?utf-8?B?OW90WVVXM3BGNlhLNGczbEdXZlZONGQ4SmgvUHF2NzBPY2N1VTN2dHV2a2pQ?= =?utf-8?B?cGtQd3hhdFM1bWQvTUFYSldLanZzZGp6SnZTMXpDbmViMFFYa1RKaEdRKy9s?= =?utf-8?B?QzBHdFpDaW8rY0taMXM4MEVGbDdpRlZVeS9IQ3pYM1NKckt1RDd1RzdNMlFG?= =?utf-8?B?dDFXNXZmVWY1UGREYjNZWmtHV1pPSW9ZWXYvbC9oNXpzbGlkL3BqS3lES2tz?= =?utf-8?B?VUhHcXBhSThSN3djV0Z0VEwrNnNBPT0=?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9577773d-ef19-42bf-d230-08dceda19951 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 05:15:49.9627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PmOYXKSwCDq/+v0E1q7VDhPbu8X6eW6Fizmta3OzOfTP2xE2k2UAz3w9cOxPpKInz3XRW9e5P9knJ5DaHTxLcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9329 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 16-10-2024 10:43, Stephen Hemminger wrote: > On Wed, 16 Oct 2024 10:39:40 +0530 > Hemant Agrawal wrote: > >>> diff --git a/devtools/build-dict.sh b/devtools/build-dict.sh >>> index a8cac49029..d503fb52fc 100755 >>> --- a/devtools/build-dict.sh >>> +++ b/devtools/build-dict.sh >>> @@ -17,6 +17,8 @@ sed '/^..->/d' | >>> sed '/^uint->/d' | >>> sed "/^doesn'->/d" | >>> sed '/^wasn->/d' | >>> +sed '/^ser->/d' | >>> +sed '/^fle->/d' | >>> >>> # print to stdout >>> cat >> Hi Stephen, >> >>     It may not be good idea to add these.  For DPAA these are proper >> keyboard, however for others - *fle* can be a spelling mistake of *file* >> >> Regards, >> >> Hemant > > But every patch gets tagged as checkpatch error now. > Or change the variable names? Changing variable name is not feasible, as it align with base driver and register names. If you don't want to ignore the checkpatch errors, than we can go with your suggestion.