From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 46CE2C45C for ; Thu, 16 Jun 2016 14:32:30 +0200 (CEST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B402964D22; Thu, 16 Jun 2016 12:32:29 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-166.ams2.redhat.com [10.36.4.166]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5GCWSj6028407; Thu, 16 Jun 2016 08:32:28 -0400 To: Neil Horman , dev@dpdk.org References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1465494421-6210-1-git-send-email-nhorman@tuxdriver.com> <1465494421-6210-6-git-send-email-nhorman@tuxdriver.com> Cc: Bruce Richardson , Thomas Monjalon , Stephen Hemminger From: Panu Matilainen Message-ID: Date: Thu, 16 Jun 2016 15:32:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465494421-6210-6-git-send-email-nhorman@tuxdriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 16 Jun 2016 12:32:29 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCHv7 5/6] pmdinfo.py: Add tool to query binaries for hw and other support information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 12:32:30 -0000 On 06/09/2016 08:47 PM, Neil Horman wrote: > This tool searches for the primer sting PMD_DRIVER_INFO= in any ELF binary, > and, if found parses the remainder of the string as a json encoded string, > outputting the results in either a human readable or raw, script parseable > format > > Note that, in the case of dynamically linked applications, pmdinfo.py will > scan for implicitly linked PMDs by searching the specified binaries > .dynamic section for DT_NEEDED entries that contain the substring > librte_pmd. The DT_RUNPATH, LD_LIBRARY_PATH, /usr/lib and /lib are > searched for these libraries, in that order > > If a file is specified with no path, it is assumed to be a PMD DSO, and the > LD_LIBRARY_PATH, /usr/lib[64]/ and /lib[64] is searched for it > > Currently the tool can output data in 3 formats: > > a) raw, suitable for scripting, where the raw JSON strings are dumped out > b) table format (default) where hex pci ids are dumped in a table format > c) pretty, where a user supplied pci.ids file is used to print out vendor > and device strings > > Signed-off-by: Neil Horman > CC: Bruce Richardson > CC: Thomas Monjalon > CC: Stephen Hemminger > CC: Panu Matilainen > --- > mk/rte.sdkinstall.mk | 2 + > tools/pmdinfo.py | 629 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 631 insertions(+) > create mode 100755 tools/pmdinfo.py > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index 68e56b6..dc36df5 100644 > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -126,6 +126,8 @@ install-runtime: > $(Q)$(call rte_mkdir, $(DESTDIR)$(sbindir)) > $(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/dpdk_nic_bind.py, \ > $(DESTDIR)$(sbindir)/dpdk_nic_bind) > + $(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/pmdinfo.py, \ > + $(DESTDIR)$(bindir)/dpdk-pmdinfo) The symlink should be with underscore instead of dash for consistency with all the other tools, ie dpdk_pmdinfo. Neil, I already gave you an ack on the series as per the functionality, feel free to include that in any future versions of the patch series. Minor nits like these are ... well, minor nits from my POV at least. - Panu -