From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>, <dev@dpdk.org>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: set the max Rx pktlen value correctly
Date: Fri, 22 Oct 2021 16:22:38 +0100 [thread overview]
Message-ID: <b1e2c3d5-03ea-b4d7-4cdd-9358dea4db6f@intel.com> (raw)
In-Reply-To: <20211022140717.11103-1-ciara.loftus@intel.com>
On 10/22/2021 3:07 PM, Ciara Loftus wrote:
> Commit 1bb4a528c41f ("ethdev: fix max Rx packet length") clarified the
> expected usage of the max_rx_pktlen and max_mtu values and implemented some
> extra checks on these values to ensure they are sane. After this,
> the AF_XDP PMD fails to initialise. The value for max_rx_pktlen which
> represents the max size of the Ethernet frame was set to ETH_FRAME_LEN
> (1514) and the max_mtu which represents the size of the payload was set to
> the max size of the Ethernet frame. This did not make sense, as naturally
> the maximum frame size should be greater than the payload size.
>
> Fix this by setting the max_rx_pktlen equal to the max size of the
> Ethernet frame as expected, and the max MTU equal to the max_rx_pktlen
> less the overhead which is set to the size of an Ethernet header plus
> CRC.
>
> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Thanks for the fix.
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2021-10-22 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 14:07 Ciara Loftus
2021-10-22 15:22 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e2c3d5-03ea-b4d7-4cdd-9358dea4db6f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).