From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EFE0A0C43; Fri, 22 Oct 2021 17:22:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 333E8411EA; Fri, 22 Oct 2021 17:22:50 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C28D741149 for ; Fri, 22 Oct 2021 17:22:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="216237416" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="216237416" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 08:22:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="464074748" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 22 Oct 2021 08:22:47 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:22:47 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 08:22:46 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 08:22:46 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 08:22:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLYjLgXeWCzEQS/klRnJIGAFCjliZRYF3vri1ZEwtuJRaBrbxRA+YSd+9DvGoOs6n8ooEj5cl98TePoirCPZhOToOPzZCBIMnj9vIsEBB7hdYuRlA/II/zpUSGBySEGOq7YCWqW+H81HVxC68wFUlaJUiECTMTcKNZQgby82kIzyu+0HASJWlxfEYmW23lJWs3qc8HbhEB1cuTDOXHwTEANX+wnd6M78uS8iS2ObNtSLCW8EoRt0dqRDECk3tweW6dpTG1qAKQ5AnCelvsSQ1CEg5eaMSP48bd5dK7Xk1/BSp7qXgOtnKlVPONocgNipOtzdFWm97vJSdEbKFsxXXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ABjW0Aa7wLwVdiVi+lBp/Zh8oISZwZ5KEr7Ru5nlaXU=; b=nG6BM3OHzhANRX94CUK3vS5CxUlqyyIlufX4FdbRjMUZl57rxm1NFm9/h4A1DlpuAi7a06PNb+wfDVLXxOw9lb846vM+nwSiN2JOatwpUymhVQ64m7OlCSlHxfS7Tk6Zro4Yhfco0/daiF3vre6cCxKGBRa/+suVgiylpIeetjYGmWEkRa7YV7MJmKzdnSDGJ2RQ3PRLpXI2nF0wa5un6MIuZykYN39VeuzuLhPRTTO98g/rSvwREQ8DkvIN8dEpLHqvxsF9LV9AiuS+qvmSHm4sCe471LYboTajIhqW3t2O8Jqb+cFUxv1LX8YBC1cczcy9qmIL9L3lDt0pc6VrdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ABjW0Aa7wLwVdiVi+lBp/Zh8oISZwZ5KEr7Ru5nlaXU=; b=jbTMoQI8ZzDG8WsEACuFmA34W1XQ6R2vMaQyXWyIj0TlqLarGI7rkHkihmUG2y7mgUQTmC2oexiNye0SrnNLdXHGfPkYetVPb27T7x+HMnhhaXijbTVTs8B+BdyXUnrn3HkiWN/k1AvdxwFtM+HF7fOshPVnVtULqP4PKM6Gqp0= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 15:22:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 15:22:44 +0000 Message-ID: Date: Fri, 22 Oct 2021 16:22:38 +0100 Content-Language: en-US To: Ciara Loftus , References: <20211022140717.11103-1-ciara.loftus@intel.com> CC: Andrew Rybchenko From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211022140717.11103-1-ciara.loftus@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0201CA0008.eurprd02.prod.outlook.com (2603:10a6:4:3f::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0201CA0008.eurprd02.prod.outlook.com (2603:10a6:4:3f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 15:22:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72349420-f7cc-4f95-23dd-08d9956fcbbb X-MS-TrafficTypeDiagnostic: PH0PR11MB4790: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: us7RIrG45odz2SXvDR34tkN68JpcYDuHFF6UTSTF7t0TulZHJI8MTh9Epc6UVqle/CTROClckAzMSrgY0erWvhGo80mcndz1cXRxfBYtUowuv2exQ0pN1z6R3Sea/FZSKhpsEuNneasyZL7YyDZZfQjkMVEzjFV6Dhy9El5QGwN6xJU+VfEfLq/6FFknrXfms06/uIaMRxhEJi52hTsf6wmMgcujvMavRrWp/+mz440L1sH9L7CIyUyvlqoqufh970hnhs8PCxFOHKc2PEhJgyetJZF47bodV/morECEBtYEwhHe0NyE+twRkFf34EJkNs2/HtzXqo9vbCCWnNwM3pETfSL+go5G0IiNmdH0QsXjCcaiRnu3n8qxsmS2D9LuOLXkBjp+HZr69dd9xquf4u9f65+hMpT3fw7dFxs6h3DqDv/8zWDLlUJoP/d6yduYYd4EsCnejxr85rkyWZkZpaNruhPIIsv/fH8AhBtLz8tBX+XqF65GNxL/5hQ/T/qkg5vmc45vSG6kpTFoFh1BCYYZt3eyJma9bZzlfrereTcXa0KEIv4b9uY+0IZ2riRXZuph1glv/DFnM3lnqP+Sk/+Z7v00ijySmIOoykuDy546EDIqIZrTYL74TS9Yx7SbnZHv6vK/jMh0ygMNrBOt2YG1M92UJyBx+MwTK3UNj2TlPYdwLIsbBvLgphg1PGwoYcx+mn2amoBcOirQoInWyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6666004)(2616005)(6486002)(956004)(31686004)(82960400001)(316002)(66946007)(44832011)(86362001)(4326008)(16576012)(36756003)(31696002)(66476007)(5660300002)(66556008)(508600001)(186003)(26005)(38100700002)(2906002)(8936002)(8676002)(53546011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azBBK0p6cmV4Rm1zYSsrK3o1b3B3Q1FzdHVidnRXYmNHUDAzaTBsSStuMk9u?= =?utf-8?B?STB3YjlZUU5TOTNUVGllUmg1UjR3bms2c2IzMjJiRE1nazIzWmROZUc0MWlh?= =?utf-8?B?cEYrWXphcHN1M0taWmFuNzNmVjFnbzVWSGN4SWUrREpQdExINEplbmpBSkFK?= =?utf-8?B?YlErdWFiTHFqNGV3c1JYdzlzQy92Uk1zTmJrMkJuVEJhUFFJcTQ2RWgrYXJF?= =?utf-8?B?L0lTMS9GbFhCSnhjYTdza2EyYTliSGNGZTBtd3AxSVR2ZEQ4bTV3Tk5vMzIv?= =?utf-8?B?YzUzS2d2RlVIdi9CNlRSSkJvSUM5eWxLVlNOVVVCSWR0OE9RNGtSeDZ0OVZm?= =?utf-8?B?c3Yrc2IvaDNCMzdtV1RrQlBickRhQ1hPWnFnZStHUDhyRVBRZnFubFB3WVlT?= =?utf-8?B?bStVZllSNVhzcldpb1RLYXFvTEllcDVwb2F4WWtEQlkzMVNxRzBObUU1TUhr?= =?utf-8?B?UDBOb0dQamwxdG5hVlh3T2haWlFIVzNsSUNqV0pRQnF5dUxyd2Y5c2k4QS9K?= =?utf-8?B?ajJtS25zOVc5T1FpV3hDRXJPVW5ZK1l1cDhrMnlSOHZGclFqL1FIUmpwZ3Qw?= =?utf-8?B?M1dWR0dUbkRoV2YvejlzOWlXWkhkZ0JSa09BTlRSZ3RxRi9Qb08vZTlVWTVw?= =?utf-8?B?M3BsTDFWblFVbUNScnVjVXNJeFk4NDUwdmNDbDN1U2dWSnRkUktPY25BRndj?= =?utf-8?B?Y2xOaWRpRG9aNVZua1B3MThtcVkwejQ0c2V0QU1JeUhjZzhMNkRRR0hYYXU4?= =?utf-8?B?Wm1WUTQyZ1hadk9ucXROTDBmemlKL3d2Y0JPNU5Bb0EzZFM3dHFnNVRkZURX?= =?utf-8?B?WDhnUnNPdDFkWTJveDFndWNwU2pyM0tCMVIrbmNta1I2Q2l3ejFNTFF6V3h0?= =?utf-8?B?ZHZONnZEZkE2ZHNKNlNDODkyWEVuZnE3eVNYbk4xQTZWNG9YdHVueWlONFNs?= =?utf-8?B?bUxTNTlzQmhkMlNNa0twUHdCRXd6ZTg4bFNxNlNuTGI0Y2lrUTNERFloNmZr?= =?utf-8?B?UDZaT2hORnhlRE10S1MvK0pRcE1TY0tuR0ltY0V2YlNTZmRkM3VYTWJGeXZN?= =?utf-8?B?cWdwQ00yRmFSZ0xGMzM3cEhFWitCSzdZclpWYUlxaU4rRExkTnYwMSt1VnRQ?= =?utf-8?B?Zzc2YlhLMG1HU2tKZmM5QllrY24rLzBqd2g2cFMzMGFCb0t3THo1RVkzRVp6?= =?utf-8?B?UWk2MGFsYlpwNXF4UnFmOUJJbjFEUndLVWdMV283ZWVPK0NEd2JyTm0vd01i?= =?utf-8?B?WWxDRUVFR0VQTGxVRHprenhucVc4c0hDamFaRUdhNzdTZ1hUazVBbzJoa00z?= =?utf-8?B?Um1NRkN6UC9KOU9nMUNXMjB5NE9sMlg2TjB3UFVTVWQ2RUJpak1HWS9USnN4?= =?utf-8?B?MmhrM3JsSHNmRVVJdytBZk5ydWRraHI5aGV5N0xORnFZeTYvZENHK1BiZzg5?= =?utf-8?B?SlRXNzhqYVRxNkxDY0U3aFJ3V3Z5aXk1UHFuQW5NUlMxQ3ZjNTloK3ZGUnBJ?= =?utf-8?B?Y3NkVkxmbWp5U05pYmRSMjdpam1iWkNWVHhXUjBBbGlrV3NadUZ4aVhNSUdo?= =?utf-8?B?d3p6SVZCSU9aQlZmYmhNSzdBbzhkNXQwN1dqR29CZytWTWZHdHFFSm55Vkto?= =?utf-8?B?Yld2dTViak9iQ29pT0xaZTJWSUhxZ2FKVktMNlpIUWZTWS9HanpvOXJOOHgy?= =?utf-8?B?ejBsV3Vhd0I0cHZQWVBkZTBwTDkvT1VxYnF5eGxzZlBZVUJYSWFNeEVLZm14?= =?utf-8?B?cE9tY1dHTGJSQkdMakZuUmZRWEJocEhYQjVHMyt1QWxCdDdRUWk0ZmErem93?= =?utf-8?B?K2FTeklFUVpHSUJFRExJZzVDT3JUa3g0b1Vnd0hwMEFxOTlWVitOT1ByWE1I?= =?utf-8?B?UVh5dSsyZVJQYmhxc2t4b2EweHBNN2t1MUxaQ2dDNGppbTRzM3VFTTVaekda?= =?utf-8?Q?R5vrMhL/0B7FDk3VmJkSFDvMY3X2TbIo?= X-MS-Exchange-CrossTenant-Network-Message-Id: 72349420-f7cc-4f95-23dd-08d9956fcbbb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 15:22:44.4022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: set the max Rx pktlen value correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 3:07 PM, Ciara Loftus wrote: > Commit 1bb4a528c41f ("ethdev: fix max Rx packet length") clarified the > expected usage of the max_rx_pktlen and max_mtu values and implemented some > extra checks on these values to ensure they are sane. After this, > the AF_XDP PMD fails to initialise. The value for max_rx_pktlen which > represents the max size of the Ethernet frame was set to ETH_FRAME_LEN > (1514) and the max_mtu which represents the size of the payload was set to > the max size of the Ethernet frame. This did not make sense, as naturally > the maximum frame size should be greater than the payload size. > > Fix this by setting the max_rx_pktlen equal to the max size of the > Ethernet frame as expected, and the max MTU equal to the max_rx_pktlen > less the overhead which is set to the size of an Ethernet header plus > CRC. > > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > > Signed-off-by: Ciara Loftus Thanks for the fix. Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.