From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 7038E475E
 for <dev@dpdk.org>; Fri,  9 Dec 2016 13:02:37 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP; 09 Dec 2016 04:02:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="40813269"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by fmsmga006.fm.intel.com with ESMTP; 09 Dec 2016 04:02:35 -0800
To: Bernard Iremonger <bernard.iremonger@intel.com>,
 thomas.monjalon@6wind.com, dev@dpdk.org
References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com>
 <1481282878-26176-4-git-send-email-bernard.iremonger@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <b1e6668c-8528-7cdd-c3ab-292a39f8722d@intel.com>
Date: Fri, 9 Dec 2016 12:02:34 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1481282878-26176-4-git-send-email-bernard.iremonger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v1 3/5] app/testpmd: add command for set VF
 VLAN filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Dec 2016 12:02:37 -0000

On 12/9/2016 11:27 AM, Bernard Iremonger wrote:
> Add the following command to testpmd:
> set vf vlan filter <port_id> <vlan_id> <vf_mask> <on|off>
> 
> Add command to the testpmd user guide.
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---

<...>

> +
> +cmdline_parse_inst_t cmd_set_vf_vlan_filter = {
> +	.f = cmd_set_vf_vlan_filter_parsed,
> +	.data = NULL,
> +	.help_str = "set vf vlan filter <port_id> <vlan_id> <vf_mask> <on_off>",

s/<on_off>/on|off

Only variables should be wrapped with "<>", fixed string with options
can be used as a|b|c .

similar issues in other testpmd patches.