From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1F8A62BBD for ; Wed, 3 Oct 2018 09:42:21 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 92A34480059; Wed, 3 Oct 2018 07:42:19 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Oct 2018 00:42:14 -0700 To: Jerin Jacob , Wenzhuo Lu , Jingjing Wu , "Bernard Iremonger" , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Olivier Matz CC: , References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> From: Andrew Rybchenko Message-ID: Date: Wed, 3 Oct 2018 10:41:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ocex03.SolarFlarecom.com (10.20.40.36) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24132.005 X-TM-AS-Result: No-4.643500-4.000000-10 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9NU8z+tFJHR0cZFsYO/SuCO3y sWjNsapAofKl0HWAHQPNcD+/klt5MGIkuSDGYD3DutvHF25zoU+5fJIYLVJ3q7lmMfLNiukada6 ASFnNnbJP90G317bPD/hlWosf3Mm3mh2ketXuCEfBtFDYGmaWKpkShYcLpGH9H06W6rwtvNXN2W jbpqXgofa8+G6VxpdYgWg8WzvAdS0FrDF4OCzISZ06nVOMOuVpLZWWNVgH0Y07LF3pX3rdVLjxa 5EVBV1q4vM1YF6AJbZFi+KwZZttLxMQLQ/0+9hGq77TyioJzBjoim2fjPcz9HwXWTmm/KEpC3OU wUk9rhcDH5Sbae6vdP4MH0/Su1X4Oq4ud9WNWzdlR0D4jOt6q2GMMTGHy4NLmJPsH1bdEoKgXfL EDDlNOGU6kIHHsIvBvJRHNKjlxzf1amLLIXG74DSX4bwsCQENbtnD2b+0SynWw7S8+IYCkf5lt3 W5BZO2AeKLdreBFSnAvpLE+mvX8g== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.643500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24132.005 X-MDID: 1538552540-6cCcFkXBLukE Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 07:42:21 -0000 On 10/2/18 10:24 PM, Jerin Jacob wrote: > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and > PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP > checksum offload. PKT_TX_OUTER_UDP_CKSUM, not TCP > > To use hardware Tx outer UDP checksum offload, the user needs to, > > - enable following in mbuff: mbuf > a) fill outer_l2_len and outer_l3_len in mbuf > b) set the PKT_TX_OUTER_UDP_CKSUM flag > c) set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6 > > - configure DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slow path > > Signed-off-by: Jerin Jacob The question about mbuf and ethdev changes separation is applicable here as well. I have no strong opinion, but I think it would be good to follow.