From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1A9A0546; Fri, 30 Apr 2021 17:57:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 673F84014F; Fri, 30 Apr 2021 17:57:00 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 961444013F for ; Fri, 30 Apr 2021 17:56:58 +0200 (CEST) IronPort-SDR: aD9eUeVnmVtsAgabmerf24Ce9Ye8IqUtNgH/5QoUTJixBg9+/lFw0hXz8hElHATN861P/Duc/L 4VxzAVUVSroA== X-IronPort-AV: E=McAfee;i="6200,9189,9970"; a="258586180" X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="258586180" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 08:56:57 -0700 IronPort-SDR: BEpA/tnzPd0/9Rj4bcin4uvLm9ABEfLA2ovBEPeaaly36a7ZcFQmks6XKa4XKqWCEQKrpvveDH dvzULS2ki22g== X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="425064509" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.242.68]) ([10.213.242.68]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 08:56:56 -0700 To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko References: <20210428094926.22185-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 30 Apr 2021 16:56:52 +0100 MIME-Version: 1.0 In-Reply-To: <20210428094926.22185-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/28/2021 10:49 AM, Ivan Malov wrote: > From: Andrew Rybchenko > > Signed-off-by: Andrew Rybchenko > Signed-off-by: Ivan Malov > --- > drivers/common/sfc_efx/base/efx_regs_mcdi.h | 3509 +++++++++++++++-- > .../common/sfc_efx/base/efx_regs_mcdi_aoe.h | 142 +- > .../common/sfc_efx/base/efx_regs_mcdi_strs.h | 2 +- > 3 files changed, 3312 insertions(+), 341 deletions(-) Hi Ivan, There are some checkpatch spelling warnings, can you please check them? Also is there a versioning on the MCDI, if so you may want to document the updated version in driver guide and/or release notes.