From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F4C1A04BC; Tue, 29 Sep 2020 17:25:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 881321D6B5; Tue, 29 Sep 2020 17:25:49 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 82AB21D5B6 for ; Tue, 29 Sep 2020 17:25:46 +0200 (CEST) IronPort-SDR: 8YLrIwuG93K0Gskx2Zeoa++rIqUQD3+iHlsVti+PLuqbbMbjxdCzz0/qQvSlbPcnh90ShZd3FW dGSPvYvfTA0g== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="159545549" X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="159545549" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 08:25:44 -0700 IronPort-SDR: /j9bwmWX0wL5H9xGIjr5SuAKNKcpods732Hrk0x3zJXw6ubMKoz5gciW91CQyjkXYroi7SlNp3 CicOM6A0nePg== X-IronPort-AV: E=Sophos;i="5.77,319,1596524400"; d="scan'208";a="457314385" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 08:25:42 -0700 To: David Marchand Cc: dev , Bruce Richardson , "Burakov, Anatoly" , Robin Jarry References: <20200928104328.409055-1-kevin.laatz@intel.com> <20200929102224.440322-1-kevin.laatz@intel.com> From: Kevin Laatz Message-ID: Date: Tue, 29 Sep 2020 16:25:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/09/2020 13:22, David Marchand wrote: > Hello Kevin, > > On Tue, Sep 29, 2020 at 12:27 PM Kevin Laatz wrote: >> This patch set converts all python scripts in the project to use >> python3 only and removes all deprecation notices associated with these >> changes. This is due to python2 being EOL in January 2020. >> >> --- >> v6: >> - rebased, removing conflict with make removal patchset. >> - added changes to buildtools/map_to_win.py >> >> v7: >> - typo in email Cc'ing David Marchand >> - added maintainers for buildtools patch >> >> v8: >> - removed unrelated cleanup >> - replaced integer cast with integer division operator >> >> v9: >> - include documentation updates >> >> Kevin Laatz (4): >> app/test-cmdline: support python3 only >> app/test: support python3 only >> buildtools: support python3 only >> doc: support python3 only >> >> Louise Kilheeney (7): >> usertools/dpdk-telemetry-client: support python3 only >> usertools/dpdk-devbind: support python3 only >> usertools/dpdk-pmdinfo: support python3 only >> usertools/cpu_layout: support python3 only >> devtools: support python3 only >> config/arm: support python3 only >> app/test-bbdev: support python3 only Hi David, > I can still see one issue in doc/guides/conf.py as you mentioned yesterday. > There is also a script that directly calls /usr/bin/python3, worth > fixing from my pov. > > $ for file in $(find app/ buildtools/ config/ devtools/ doc/ drivers/ > examples/ kernel/ lib/ license/ usertools/ -name "*.py"); do head -1 > $file |grep -q env.*python3 || echo $file; done > doc/guides/conf.py > usertools/dpdk-telemetry.py doc/guides/conf.py is indirectly called from sphinx which potentially causes some compatibilty issues when we make conf.py only support python3 (if sphinx in using python2) - this is why I left this out of the patchset, otherwise the doc build will be broken :-( I can change direct call to /usr/bin/python3. -Kevin