From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61837A0C43; Tue, 28 Sep 2021 17:52:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1DE2410DB; Tue, 28 Sep 2021 17:52:49 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id 98EB6410D7 for ; Tue, 28 Sep 2021 17:52:48 +0200 (CEST) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18SF8QUv039917; Tue, 28 Sep 2021 11:52:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=AwUMsmPVYSkMEFnmMwB+kWC6kwXzGVpAlPBuEOYPMwQ=; b=eRvBsXt5cbByAI9K3ts+WkrigtsFpZ10GNg31DU31WZBUv0CQGPdolIXUH5kbGJxRaKd VxERtCA6JA7U+PKsdd0jzSDLcTvobyopPvBXAWZD7n6Et4qMQhMRs0qVmqLGbo7geNE/ ULG0euk7yIf76gHl55S/ddPq00sSIGjKjXHRxlclZFRMjCzfyjctqCINtc3EdTY2BOWT sFqx/9JiG9wrs8nMjv2RFahRpo0+BFET1x5tJGgXSijfLkQ1cg3TVfLslYPw/mkNmfHq 4JGyERZQEw1lizAqYyNEh2ae9ESWSRg5dicIn7nkF0XF+SP17Nafm0TBmcVZcZdu3dIV BQ== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bbtewftnt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 11:52:47 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18SFhDol018136; Tue, 28 Sep 2021 15:52:46 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03wdc.us.ibm.com with ESMTP id 3b9udapeu1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 15:52:46 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18SFqkI726673542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Sep 2021 15:52:46 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 65E27AC05F; Tue, 28 Sep 2021 15:52:46 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C7748AC05B; Tue, 28 Sep 2021 15:52:45 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.69.22]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 28 Sep 2021 15:52:45 +0000 (GMT) To: Pablo de Lara , yipeng1.wang@intel.com, byron.marohn@intel.com Cc: dev@dpdk.org, John McNamara References: <20210917125606.2524678-1-pablo.de.lara.guarch@intel.com> <20210928135839.3778960-1-pablo.de.lara.guarch@intel.com> From: David Christensen Message-ID: Date: Tue, 28 Sep 2021 08:52:45 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210928135839.3778960-1-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Ou1FrGtg_JpbyjkCXdvClSbc3FgfQAi4 X-Proofpoint-GUID: Ou1FrGtg_JpbyjkCXdvClSbc3FgfQAi4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-28_05,2021-09-28_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109280089 Subject: Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/21 6:58 AM, Pablo de Lara wrote: > rte_efd_create() function was using uint8_t for a socket bitmask, > for one of its parameters. > This limits the maximum of NUMA sockets to be 8. > Changing to to uint64_t increases it to 64, which should be > more future-proof. > > Coverity issue: 366390 > Fixes: 56b6ef874f8 ("efd: new Elastic Flow Distributor library") > > Signed-off-by: Pablo de Lara > Acked-by: John McNamara > --- > > v4: Set socket id in EFD tests > > v3: Fixed commit message > > v2: Fixed EFD tests Results with v4 on a non-consecutive NUMA system: $ lscpu Architecture: ppc64le Byte Order: Little Endian CPU(s): 128 On-line CPU(s) list: 0-127 Thread(s) per core: 4 Core(s) per socket: 16 Socket(s): 2 NUMA node(s): 6 Model: 2.3 (pvr 004e 1203) Model name: POWER9, altivec supported CPU max MHz: 3800.0000 CPU min MHz: 2300.0000 L1d cache: 32K L1i cache: 32K L2 cache: 512K L3 cache: 10240K NUMA node0 CPU(s): 0-63 NUMA node8 CPU(s): 64-127 NUMA node252 CPU(s): NUMA node253 CPU(s): NUMA node254 CPU(s): NUMA node255 CPU(s): $ sudo /home/drc/src/dpdk/build/app/test/dpdk-test -l 64-127 -n 4 --no-pci EAL: Detected 128 lcore(s) EAL: Detected 2 NUMA nodes EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: No available 1048576 kB hugepages reported EAL: VFIO support initialized APP: HPET is not enabled, using TSC as default timer RTE>>efd_autotest Entering test_add_delete Entering test_efd_find_existing Entering test_add_update_delete Entering test_five_keys Entering test_efd_creation_with_bad_parameters, **Errors are expected ** EFD: Allocating key array on socket 8 failed EFD: At least one CPU socket must be enabled in the bitmask EFD: Allocating EFD table management structure on socket 255 failed # Test successful. No more errors expected Evaluating table utilization and correctness, please wait Added 2097152 Succeeded 2097152 Lost 0 Added 2097152 Succeeded 2097152 Lost 0 Added 2097152 Succeeded 2097152 Lost 0 Average table utilization = 100.00% (2097152/2097152) Test OK RTE>>efd_perf_autotest Measuring performance, please wait .......... Results (in CPU cycles/operation) ----------------------------------- Keysize Add Lookup Lookup_bulk Delete 4 471 17 11 59 8 502 18 14 73 16 542 23 21 81 32 662 37 36 97 48 782 54 53 110 64 881 75 74 119 9 512 18 16 75 13 539 23 22 84 37 726 48 47 115 40 726 47 46 112 Test OK