From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Andy Moreton" <andy.moreton@amd.com>,
"Ivan Malov" <ivan.malov@arknetworks.am>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2 8/8] net/sfc: fix calloc parameters
Date: Thu, 25 Jan 2024 10:10:16 +0300 [thread overview]
Message-ID: <b25461e5-bb96-411e-b23e-3ca4b8ae502d@oktetlabs.ru> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F19A@smartserver.smartshare.dk>
On 1/24/24 22:02, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com]
>> Sent: Wednesday, 24 January 2024 19.54
>>
>> gcc [1] generates warning [2] about rte_calloc usage, because
>> rte_calloc parameter order is wrong, fixing it by replacing parameters.
>>
>> [1]
>> gcc (GCC) 14.0.1 20240124 (experimental)
>>
>> [2]
>> Compiling C object drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae.c.o
>> ../net/sfc/sfc_mae.c: In function ‘sfc_mae_action_set_list_add’:
>> ../drivers/net/sfc/sfc_mae.c:1353:35:
>> warning: ‘rte_calloc’ sizes specified with ‘sizeof’ in the earlier
>> argument and not in the later argument [-Wcalloc-transposed-args]
>> 1353 | sizeof(struct sfc_mae_action_set *),
>> | ^~~~~~
>>
>> Fixes: 002f591f54c3 ("net/sfc: support packet replay in transfer
>> flows")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2024-01-25 7:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 13:08 [PATCH 1/2] pipeline: " Ferruh Yigit
2023-11-02 13:08 ` [PATCH 2/2] net/nfp: " Ferruh Yigit
2023-11-03 1:26 ` Chaoyong He
2023-11-06 14:26 ` [PATCH 1/2] pipeline: " Dumitrescu, Cristian
2024-01-24 18:53 ` [PATCH v2 1/8] " Ferruh Yigit
2024-01-24 18:53 ` [PATCH v2 2/8] net/nfp: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 3/8] rawdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-25 3:39 ` Hemant Agrawal
2024-01-24 18:54 ` [PATCH v2 4/8] eventdev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:34 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 5/8] dmadev: " Ferruh Yigit
2024-01-24 18:59 ` Morten Brørup
2024-01-25 2:35 ` fengchengwen
2024-01-24 18:54 ` [PATCH v2 6/8] common/mlx5: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-26 10:12 ` Dariusz Sosnowski
2024-01-24 18:54 ` [PATCH v2 7/8] net/bnx2x: " Ferruh Yigit
2024-01-24 19:01 ` Morten Brørup
2024-01-24 18:54 ` [PATCH v2 8/8] net/sfc: " Ferruh Yigit
2024-01-24 19:02 ` Morten Brørup
2024-01-25 7:10 ` Andrew Rybchenko [this message]
2024-01-24 19:00 ` [PATCH v2 1/8] pipeline: " Morten Brørup
2024-02-18 16:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b25461e5-bb96-411e-b23e-3ca4b8ae502d@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=andy.moreton@amd.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ivan.malov@arknetworks.am \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).