From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 538A9A0613 for ; Tue, 24 Sep 2019 13:56:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40B4B2BE1; Tue, 24 Sep 2019 13:56:27 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AA53D2BBB for ; Tue, 24 Sep 2019 13:56:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 04:56:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,544,1559545200"; d="scan'208";a="193425288" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga006.jf.intel.com with ESMTP; 24 Sep 2019 04:56:10 -0700 To: Andrew Rybchenko , "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Bruce Richardson , Jan Remes , Rastislav Cernay , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon Cc: dev@dpdk.org, Igor Romanov References: <1567780495-14120-1-git-send-email-arybchenko@solarflare.com> <1567780495-14120-3-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 24 Sep 2019 12:56:09 +0100 MIME-Version: 1.0 In-Reply-To: <1567780495-14120-3-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: make stats and xstats reset callbacks return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: > From: Igor Romanov > > Change return value of the callbacks from void to int. Make > implementations across all drivers return negative errno > values in case of error conditions. > > Both callbacks are updated together because a large number of > drivers assign the same function to both callbacks. > > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko > --- > app/test/virtual_pmd.c | 4 ++- > drivers/net/af_packet/rte_eth_af_packet.c | 4 ++- > drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++- > drivers/net/ark/ark_ethdev.c | 6 ++-- > drivers/net/atlantic/atl_ethdev.c | 6 ++-- > drivers/net/avp/avp_ethdev.c | 6 ++-- > drivers/net/axgbe/axgbe_ethdev.c | 6 ++-- > drivers/net/bnxt/bnxt_stats.c | 38 +++++++++++++++++------ > drivers/net/bnxt/bnxt_stats.h | 4 +-- > drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++-- > drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++- > drivers/net/dpaa/dpaa_ethdev.c | 4 ++- > drivers/net/dpaa2/dpaa2_ethdev.c | 10 +++--- > drivers/net/e1000/em_ethdev.c | 6 ++-- > drivers/net/e1000/igb_ethdev.c | 18 +++++++---- > drivers/net/enetc/enetc_ethdev.c | 4 ++- > drivers/net/enic/enic.h | 2 +- > drivers/net/enic/enic_ethdev.c | 4 +-- > drivers/net/enic/enic_main.c | 11 +++++-- > drivers/net/failsafe/failsafe_ops.c | 16 ++++++++-- > drivers/net/fm10k/fm10k_ethdev.c | 10 ++++-- > drivers/net/hinic/base/hinic_pmd_niccfg.c | 14 ++++++--- > drivers/net/hinic/base/hinic_pmd_niccfg.h | 4 +-- > drivers/net/hinic/hinic_pmd_ethdev.c | 25 +++++++++++---- > drivers/net/i40e/i40e_ethdev.c | 6 ++-- > drivers/net/i40e/i40e_ethdev_vf.c | 6 ++-- > drivers/net/i40e/i40e_vf_representor.c | 4 +-- > drivers/net/iavf/iavf_ethdev.c | 11 ++++--- > drivers/net/ice/ice_ethdev.c | 6 ++-- > drivers/net/ipn3ke/ipn3ke_representor.c | 14 +++++---- > drivers/net/ixgbe/ixgbe_ethdev.c | 18 +++++++---- > drivers/net/kni/rte_eth_kni.c | 4 ++- > drivers/net/liquidio/lio_ethdev.c | 23 ++++++++------ > drivers/net/memif/rte_eth_memif.c | 4 ++- > drivers/net/mlx4/mlx4.h | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 7 ++++- > drivers/net/mlx5/mlx5.h | 4 +-- > drivers/net/mlx5/mlx5_stats.c | 19 +++++++++--- > drivers/net/mvneta/mvneta_ethdev.c | 11 +++++-- > drivers/net/mvpp2/mrvl_ethdev.c | 16 +++++++--- > drivers/net/netvsc/hn_ethdev.c | 15 ++++++--- > drivers/net/netvsc/hn_var.h | 4 +-- > drivers/net/netvsc/hn_vf.c | 13 +++++--- > drivers/net/nfp/nfp_net.c | 6 ++-- > drivers/net/null/rte_eth_null.c | 6 ++-- > drivers/net/octeontx/octeontx_ethdev.c | 8 ++--- > drivers/net/octeontx2/otx2_ethdev.h | 4 +-- > drivers/net/octeontx2/otx2_stats.c | 33 +++++++++++++------- > drivers/net/pcap/rte_eth_pcap.c | 4 ++- > drivers/net/qede/qede_ethdev.c | 8 +++-- > drivers/net/ring/rte_eth_ring.c | 4 ++- > drivers/net/sfc/sfc_ethdev.c | 7 +++-- > drivers/net/szedata2/rte_eth_szedata2.c | 4 ++- > drivers/net/tap/rte_eth_tap.c | 4 ++- > drivers/net/thunderx/nicvf_ethdev.c | 13 ++++++-- > drivers/net/vhost/rte_eth_vhost.c | 8 +++-- > drivers/net/virtio/virtio_ethdev.c | 6 ++-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++-- > lib/librte_ethdev/rte_ethdev.c | 12 ++++--- > lib/librte_ethdev/rte_ethdev.h | 2 ++ > lib/librte_ethdev/rte_ethdev_core.h | 4 +-- > 61 files changed, 380 insertions(+), 169 deletions(-) 'nfb' driver was missing, updating it while merging. <...> > @@ -72,7 +72,7 @@ typedef int (*eth_stats_get_t)(struct rte_eth_dev *dev, > struct rte_eth_stats *igb_stats); > /**< @internal Get global I/O statistics of an Ethernet device. */ > > -typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev); > +typedef int (*eth_stats_reset_t)(struct rte_eth_dev *dev); > /**< @internal Reset global I/O statistics of an Ethernet device to 0. */ > > typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, > @@ -85,7 +85,7 @@ typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, > unsigned int n); > /**< @internal Get extended stats of an Ethernet device. */ > > -typedef void (*eth_xstats_reset_t)(struct rte_eth_dev *dev); > +typedef int (*eth_xstats_reset_t)(struct rte_eth_dev *dev); > /**< @internal Reset extended stats of an Ethernet device. */ > > typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev, > Adding following comments to the dev_ops while merging, please shout if needs update: -typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev); -/**< @internal Reset global I/O statistics of an Ethernet device to 0. */ +/** + * @internal + * Reset global I/O statistics of an Ethernet device to 0. + * + * @param dev + * ethdev handle of port. + * + * @return + * Negative errno value on error, 0 on success. + * + * @retval 0 + * Success, statistics has been reset. + * @retval -ENOTSUP + * Resetting statistics is not supported. + * @retval -EINVAL + * Resetting statistics is not valid. + * @retval -ENOMEM + * Not enough memory to get the stats. + */ +typedef int (*eth_stats_reset_t)(struct rte_eth_dev *dev); typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, struct rte_eth_xstat *stats, unsigned n); @@ -129,8 +147,26 @@ typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, unsigned int n); /**< @internal Get extended stats of an Ethernet device. */ -typedef void (*eth_xstats_reset_t)(struct rte_eth_dev *dev); -/**< @internal Reset extended stats of an Ethernet device. */ +/** + * @internal + * Reset extended stats of an Ethernet device. + * + * @param dev + * ethdev handle of port. + * + * @return + * Negative errno value on error, 0 on success. + * + * @retval 0 + * Success, statistics has been reset. + * @retval -ENOTSUP + * Resetting statistics is not supported. + * @retval -EINVAL + * Resetting statistics is not valid. + * @retval -ENOMEM + * Not enough memory to get the stats. + */ +typedef int (*eth_xstats_reset_t)(struct rte_eth_dev *dev);