From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D261C282 for ; Fri, 7 Apr 2017 13:59:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491566376; x=1523102376; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=SDHnFUSr2clbVJSLxRPSR9fbWxn43EOVD7GwqPNFe2c=; b=dNr/5R7v4sCYdhOCMmCNmq3balZ9mAWTx+gCsAy1tZznApRqbYekPrNF u5S7JXNLwNADb781SCYnChfQFmfv7g==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 04:59:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,164,1488873600"; d="scan'208";a="86363672" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 07 Apr 2017 04:59:34 -0700 To: Jerin Jacob , dev@dpdk.org References: <20170406160651.15432-1-jerin.jacob@caviumnetworks.com> Cc: thomas.monjalon@6wind.com From: Ferruh Yigit Message-ID: Date: Fri, 7 Apr 2017 12:59:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170406160651.15432-1-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/thunderx: use rte version of byteorder.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 11:59:37 -0000 On 4/6/2017 5:06 PM, Jerin Jacob wrote: > The base code was using native GCC macros > for endian detection. Change to portable > rte_byteorder.h based endian detection. > > Fixes: 262d43fe20ee ("net/thunderx/base: add HW register definitions") > > Suggested-by: Thomas Monjalon > Signed-off-by: Jerin Jacob There is one more __BYTE_ORDER__ usage [1], is it kept intentional? [1] $ git grep __BYTE_ORDER__ drivers/net/thunderx/ drivers/net/thunderx/base/nicvf_mbox.c:#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__