Re: [25.11 PATCH 1/3] dmadev: add enqueue dequeue operations

[fengchengwen <fengchengwen@huawei.com>]

Hi Pavan,

On 2025/4/16 18:09, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Add enqueue/dequeue operations that use struct rte_dma_op
> to communicate with the dma device.
> These operations need to be enabled at dma device configuration
> time by setting the flag rte_dma_conf::enable_enq_deq if the
> device supports RTE_DMA_CAPA_OPS_ENQ_DEQ capability.
> The enqueue dequeue operations are not compatible with
> rte_dma_copy, rte_dma_copy_sg, rte_dma_fill, rte_dma_submit,
> rte_dma_completed, rte_dma_completed_status range of APIs.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  app/test/test_dmadev.c               | 160 +++++++++++++++++++++++++++
>  app/test/test_dmadev_api.c           |  78 +++++++++++--
>  doc/guides/prog_guide/dmadev.rst     |  34 ++++++
>  drivers/dma/dpaa/dpaa_qdma.c         |   2 +-
>  drivers/dma/dpaa2/dpaa2_qdma.c       |   2 +-
>  lib/dmadev/rte_dmadev.c              |  30 ++++-
>  lib/dmadev/rte_dmadev.h              | 155 ++++++++++++++++++++++++--
>  lib/dmadev/rte_dmadev_core.h         |  10 ++
>  lib/dmadev/rte_dmadev_trace.h        |   2 +-
>  lib/dmadev/rte_dmadev_trace_fp.h     |  20 ++++
>  lib/dmadev/rte_dmadev_trace_points.c |   6 +
>  11 files changed, 477 insertions(+), 22 deletions(-)

It seemed this API couldn't use at the same time with original API. Could you describe this explicitly?
I'm inferring that this feature is added mainly for performance. and we traded it off when design the API.
So could you share the performance gain when use this API compared with original API?

You have show the programming model for the enqueue/dequeue operations at cover letter, that's nice,
but I want to know the higher level: how the library API interact with Application. so that I can
understand why the rte_dma_op contain so such fields.

And also, please split this commit to at least two: one for library, one for UT.

Thanks