From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 08C162B87; Thu, 9 May 2019 20:16:41 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47461307D910; Thu, 9 May 2019 18:16:40 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2087560FB4; Thu, 9 May 2019 18:16:38 +0000 (UTC) To: Ferruh Yigit , Anatoly Burakov Cc: dev@dpdk.org, dpdk-stable References: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com> From: Kevin Traynor Message-ID: Date: Thu, 9 May 2019 19:16:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 09 May 2019 18:16:40 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 18:16:41 -0000 On 09/05/2019 18:50, Ferruh Yigit wrote: > On 5/9/2019 6:50 PM, Ferruh Yigit wrote: >> On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >>> In no-shconf mode, there is no need to clean runtime directory >>> because it's not created in the first place. >>> >>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization") >>> >>> Signed-off-by: Anatoly Burakov >> >> Is this for 18.11.x LTS? >> cc'ed the stable mail list assuming that is the case. > > +Kevin > >> >> Is this valid for 19.05 too? >> It's already applied on 18.11 branch. The same change is also in master courtesy of the referenced upstream commit below, so this one not needed for master. Thanks for checking. commit 4c1ef6dff7230f08f90427355741f56d2faf5884 Author: Anatoly Burakov Date: Wed Apr 24 16:26:10 2019 +0100 eal: fix cleanup in no-shconf mode [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ] >>> --- >>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >>> index 30138b638..59497d04a 100644 >>> --- a/lib/librte_eal/linuxapp/eal/eal.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal.c >>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv) >>> * whether we are primary or secondary process, but we cannot remove >>> * primary process' files because secondary should be able to run even >>> * if primary process is dead. >>> + * >>> + * In no_shconf mode, no runtime directory is created in the first >>> + * place, so no cleanup needed. >>> */ >>> - if (eal_clean_runtime_dir() < 0) { >>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) { >>> rte_eal_init_alert("Cannot clear runtime directory\n"); >>> return -1; >>> } >>> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 037AEA0096 for ; Thu, 9 May 2019 20:16:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F0E5493D; Thu, 9 May 2019 20:16:42 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 08C162B87; Thu, 9 May 2019 20:16:41 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47461307D910; Thu, 9 May 2019 18:16:40 +0000 (UTC) Received: from [10.36.117.210] (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2087560FB4; Thu, 9 May 2019 18:16:38 +0000 (UTC) To: Ferruh Yigit , Anatoly Burakov Cc: dev@dpdk.org, dpdk-stable References: <9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com> From: Kevin Traynor Message-ID: Date: Thu, 9 May 2019 19:16:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 09 May 2019 18:16:40 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509181638.VnIKXnvm3FDYGlnJOweUX23w7YOimwrtWaSIPQ2lKQU@z> On 09/05/2019 18:50, Ferruh Yigit wrote: > On 5/9/2019 6:50 PM, Ferruh Yigit wrote: >> On 4/24/2019 4:26 PM, Anatoly Burakov wrote: >>> In no-shconf mode, there is no need to clean runtime directory >>> because it's not created in the first place. >>> >>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization") >>> >>> Signed-off-by: Anatoly Burakov >> >> Is this for 18.11.x LTS? >> cc'ed the stable mail list assuming that is the case. > > +Kevin > >> >> Is this valid for 19.05 too? >> It's already applied on 18.11 branch. The same change is also in master courtesy of the referenced upstream commit below, so this one not needed for master. Thanks for checking. commit 4c1ef6dff7230f08f90427355741f56d2faf5884 Author: Anatoly Burakov Date: Wed Apr 24 16:26:10 2019 +0100 eal: fix cleanup in no-shconf mode [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ] >>> --- >>> lib/librte_eal/linuxapp/eal/eal.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >>> index 30138b638..59497d04a 100644 >>> --- a/lib/librte_eal/linuxapp/eal/eal.c >>> +++ b/lib/librte_eal/linuxapp/eal/eal.c >>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv) >>> * whether we are primary or secondary process, but we cannot remove >>> * primary process' files because secondary should be able to run even >>> * if primary process is dead. >>> + * >>> + * In no_shconf mode, no runtime directory is created in the first >>> + * place, so no cleanup needed. >>> */ >>> - if (eal_clean_runtime_dir() < 0) { >>> + if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) { >>> rte_eal_init_alert("Cannot clear runtime directory\n"); >>> return -1; >>> } >>> >> >