From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC980A0C57; Mon, 1 Nov 2021 12:42:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E35940E28; Mon, 1 Nov 2021 12:42:05 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 28FBB40DF6 for ; Mon, 1 Nov 2021 12:42:02 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="229725004" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="229725004" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 04:42:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="576160927" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 01 Nov 2021 04:41:59 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 04:41:58 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 04:41:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 04:41:58 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 04:41:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBpLZ9T024qOkbWBBDvd7pHSyvhw4Zi6s9hZ7fHwYnHYExcm/NowEdH8fGcgi4lOvaY6K3dahEE6/WNYAnWpetEZqd9POo6CAhi0phW13pGA3kX6/aavzW6zJyFBe7jNRkaXohZ5oUPUJU+mJJELBcVae2HN2S7OPYEgr+IZvkLee2gsPU50C3gxA1FkKcpsMBJdq+32ogde/C8Av/OBE3uzi6PUwb/4At4U8DwLT22YNayd7ui+jMY/7BoMUrAEOcuRSpVezF9mS2r22R28hPtSIZTQjxBS84JRBt6KIcq3xlpXIOly3JD0TXxT9DK/nKEKX6T6FOsZN/SwO3iN/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wLU8eS3AS7qxh7YRGPMRmViC1LTELFEMC2kSUlpfZOg=; b=mCcuDBZmFblMRQXoDr0NGtlG/zh//0YeNEwP1YI8Tpo1Fg0ZHuAgvekBQ9Tw02wXRYb4Fy4lNJ0bb81mRCsDVaOORxynNRRtVrKk7pPFPgnp3Pt0aXKhdUD26ccetJYu1SBHd0+vHozDCulYOPD0Sqk1efiR6/iO912s0fvIq3JQlOmXCy/lqoc6b6I+4MAGCTruWj3egnpXUB8Tj9Pp4BdNKd4k+VIU0bkplgoLF83VVw9k4v++mwqv781wYHwqyorTzVTRc4jAWGbiPrJH+jwvi9WHdug/q6VLsha6XEzJ4cYhw0A8w5/TuqoFGI9SMPUSn4PXG7N2PRncALFf4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLU8eS3AS7qxh7YRGPMRmViC1LTELFEMC2kSUlpfZOg=; b=E9M98EFH2iXCvP6F6IM0g6x38zXDZzHxs9zVl6C++pY8Evilq3iSacHntaJcGRaeDi4WTcGYvxqx+4MJKncbfC4vrWRUOhfRsOxbKik5H9Plk8XGnvlOrLc+1EPtX8x5qCGX5xlnQtB//Dh5E3TdE5LvPTbkKFEUNCUurIrz4JE= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5914.namprd11.prod.outlook.com (2603:10b6:510:138::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Mon, 1 Nov 2021 11:41:55 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 11:41:55 +0000 Message-ID: Date: Mon, 1 Nov 2021 11:41:48 +0000 Content-Language: en-US From: Ferruh Yigit To: David Marchand , Radu Nicolau CC: Jingjing Wu , Beilei Xing , Ray Kinsella , dev , Declan Doherty , , Qi Zhang , Bruce Richardson , "Ananyev, Konstantin" References: <20210909142428.750634-1-radu.nicolau@intel.com> <20211028160500.2775783-1-radu.nicolau@intel.com> <20211028160500.2775783-5-radu.nicolau@intel.com> X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0054.eurprd07.prod.outlook.com (2603:10a6:6:2a::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0054.eurprd07.prod.outlook.com (2603:10a6:6:2a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Mon, 1 Nov 2021 11:41:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38f2be76-8c72-4fe8-ed73-08d99d2c9abf X-MS-TrafficTypeDiagnostic: PH7PR11MB5914: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mxejmoPWRPddgk/1r1tH5zzSeGgFb+arIzaDK+nW68qhKA6Kl/qtvu26hqcQnXjhHXo9RWliRCAfHCBirslz+PqYl0Clz7x4xmJsK47UVeDgZZDI/neLiOzUl5cNbIi33sDnzDwv5mS8wDYL/ty5U2DaJ1U5E1QIYplYmhfL209d7ucKv+qO8B8CVeMqof4BIA4pXgCpjCkFk9vtO/c0q2ocg1v5v+VDxGFg2p2FwSpElqvVip8kpZ3o2/7VItWkKjFD+dWof9ty7xJhaXdmtvl2oFB6bfyogX9HRorGMbvRWseWiQ8kkZH199D9Evr6iaIzhwU2PvF6rUJj1dsGqUyhSDYXHKvv4ABTx840biyTcPN3Aopa14yRCOrvP4OOXsY727OikWntdTujQGDjm4Q3tR8/XYscb+Hp9o7Zi7hac4o48rWMb7FuO+ZpuCgTeZeL8a/pxmuMOnFSZfboYp6REcXvk49HBfzie3Yv05jDx56K7J8f2NVv0sgurguDggIiLulHDVfoyCfl3TZmCV2+7tCVa3Fogg6YOWAElC6tnP/oR2c7vkz9DOU9PTHUKVfAfYCdisAmKqNNT+0PevoWwaQu9DofTy/UmPfjgYvTEdriv+69qYjgarqR/6/VM1HsX5A+GZW7ribYM32HE0eWHJ2p44vIO+tki6G8OnJnr2APSMhA6I2uUqkz4uswXep6aj4o/grVQdNip6simc00wzKN24LKiqdKTLNcsZdSVWY0mpZvnJ5Q0oYJCIEjPJKkMwxQ8aY4XYfLGl51UUw2DsrcraCwOOaTAHXOx1w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(83380400001)(2906002)(16576012)(82960400001)(53546011)(107886003)(2616005)(110136005)(966005)(44832011)(5660300002)(86362001)(54906003)(6486002)(66946007)(36756003)(4326008)(38100700002)(8676002)(6636002)(66556008)(31696002)(508600001)(316002)(26005)(31686004)(6666004)(186003)(8936002)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmNZakJZYXBucDNFMUxXTmJKNUszK0krbVByTnp1MlpjbHdXNzV0Y3RWcDF1?= =?utf-8?B?VGhIOXc0ZnAyRVRxZDQyVVJualZXQ2hNMEY0eGw2aUREVDF5TkFDN3pNZEd3?= =?utf-8?B?UjJVa3dubU1PRDk2aW81WTJtRVltSkhHRDVrRjdxUDZhMzVIb1NoNSs2OWFa?= =?utf-8?B?WHduamFKLzB5QTZBaTBLRVh2Y05MU1BLNmVSQ0ZsRWgvV0VzVE9zbEVoUlJP?= =?utf-8?B?T05zd3BPWWlPUG5VK0JLdEpRNDhteThqNXNFcUhtNEFlQ3RRVXNGbmU1em9E?= =?utf-8?B?aXpza0xGbDlQNmhVcXRMQWFpYUlHT3QzMCtNd2FBZm4wUWUvUnFPb0E4NFJN?= =?utf-8?B?eHdwVlFhRGpCaVhpRVZRQWI5QThwV0txSGh3M1pWa3lTRnNDaG5JYnpQbU9F?= =?utf-8?B?WGRoZG5xQjFUVEpnSFdROEtwQ0tNSlVXMmlMRHRTL3cxbWNTUVE0dEZaNHc4?= =?utf-8?B?NFNkckhyYmZzVENhSDRzVU1qYm5jOHRiamZxQlJ4WUI1VVFCdmZYcGNIZE5J?= =?utf-8?B?K1RKQlRPbFJWTHp2cy84dmYvd0kyRUNSZFpvb3BrdHMwQjhaeVFweS9MRVdE?= =?utf-8?B?ZHB6THlaeVFhZ282b1kvTTJ3VnhLa1lna2xsL2lmaVgxWG1kYmJjRWt0OFVH?= =?utf-8?B?RWxyWHhtekFCNys1MktMTzJ6TmhaL3ZCMEZTempTS3h6bDJmQlkveDZKRnNB?= =?utf-8?B?dDBMTC95aE95ZDN4cDJkT0hrZVlzMXp2Mkk0WWI1UzBjd2NIUkFCbDdtRTdQ?= =?utf-8?B?UTNSVldnN2tHbURXREFoYndScGdkdCsvTUpIa2lmQjRBUEcwbDVOb2w5VHlD?= =?utf-8?B?MWFua242UHIvUEN3TG1RdklBUUZjYzVQeG1aWjVPZ3dkb2hNVEU2ZGJPbi9O?= =?utf-8?B?S1dXL0t0UWg4bFdFN1VZUllpVFVXeEZ5Y3VPR0FUUmR5b3pvK29adjJMWUc3?= =?utf-8?B?ZGtVQ29lcVpycWw1UzJDTlFIaWZtWi9xWXVLd2R4ZHBhV0lWM25OMkpnNVZN?= =?utf-8?B?S2N3OGZNeWgyREFqalREenVadWl2Tnhid0ZWUDg0ZWlkNmRGUGl0b0dFRzNY?= =?utf-8?B?MTFTR0h0OG5PNU14STVaTFAxL3FFSXg3LzJPblA1Zm42bjFDY1RDUlJVOU5D?= =?utf-8?B?alVjek1KQ1pYZkYzN05URXJIMGwzaEpucWhJZlFJRG1RUGpidXR6bnA0bnE2?= =?utf-8?B?UW9sb0x4VjZtYUdnekZUVS8yVW8vdTBuNVlaZEJ4a2g2dUtkZWxDd3VwRHpJ?= =?utf-8?B?L0RyYS95S0pPWDNSdjBJV2lwVmt4MHhpZEY0YUlXMjZJVG1RRVdJaU5lQ3I0?= =?utf-8?B?N2ZxaFg5YW1VVGRWcVZFNHRhQ0JjdTRzWWEzZ3hKYnpYZXl1WFkrMlBxbWVk?= =?utf-8?B?SUtiNXE5VU1kZnE0TWJRQjBGQjRKVjlDa2dGWGk5OFd6MHNyYVNmTjJ0clhU?= =?utf-8?B?aEJ2SGdVdmZFSkZCem1WSU9SN3lyWm5NN2FlcmFiTnl1T3pXdjR4ME1NS3dR?= =?utf-8?B?cThTRnlxdWJ5ekpCR2NEei9XcEJTRG93THlDdTl4L1prbHNVMG5nOHZoOEIw?= =?utf-8?B?S3kwTFgyeXU3S05MYXFId1JYTFJ6MmxZOFRRTjRQb1M5dmNMZEJQQWp2a05G?= =?utf-8?B?Yk9yZ2lhSS9aclFRYUNEVm5BaGZaQ3R6dGZob1V4S1pLU01LY08zYm5kSWox?= =?utf-8?B?eGY1T3NCZU1rY3JRU0x2dG80NDJQZWJ6OFFWcUtiamZaYUFtSE1ubDNvRWl1?= =?utf-8?B?aGdtSzQ2bm5NeWpqZmlMQk54U29uaTlZbGdIYlhDNXF3YXlKUVB5WkRaQURO?= =?utf-8?B?dVpxOVlHbVFDVGMyU3Z2WTAxT0RwVTJYaExoZHZrSEF6YzFLbm1XQ0U1V1g4?= =?utf-8?B?WWlIbDlGeEhvYnMvSFdhWjc5RHJWeFBDL2NaK3pyK0NmenRCNUw2eWh3TURH?= =?utf-8?B?eEVFam4yYnVodk1LRU5JejlvUmFsZEtwSFNmRHVDMDFXSUV3SWMweDZMazZK?= =?utf-8?B?SEwxSXB5dXFxNzhsNmZZN1N1QVpuUlM1UmVpM0lyUlFkWFFOSno2REYrSUhC?= =?utf-8?B?L1drWDJzL1NUbUN2N0xkV2xlcUlTYXRGQ0pmVEQ4QVUwNWxhUG9TWWhPZFM0?= =?utf-8?B?eTJ2MWdabzNuUVltYWQrUllWWDI3OWJEcUdPUTdNUXdUcmFENTZWZDV0aHlP?= =?utf-8?Q?6tM5Y98sscpI5caRRHa8sb4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 38f2be76-8c72-4fe8-ed73-08d99d2c9abf X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 11:41:55.2655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1j6Ks2EOz89Wb2XAltS7zOsMeAx3ZZa/1rBj0ykURXa3LTxDZiE9oRZxm0yRVGLYfw3lWggwniBeJ0AsOxjzMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5914 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v13 4/7] net/iavf: add iAVF IPsec inline crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/2021 11:36 AM, Ferruh Yigit wrote: > On 11/1/2021 10:45 AM, Ferruh Yigit wrote: >> On 10/30/2021 9:41 PM, David Marchand wrote: >>> On Thu, Oct 28, 2021 at 6:21 PM Radu Nicolau wrote: >>>> +static const struct rte_cryptodev_symmetric_capability * >>>> +get_capability(struct iavf_security_ctx *iavf_sctx, >>>> +       uint32_t algo, uint32_t type) >>>> +{ >>>> +       const struct rte_cryptodev_capabilities *capability; >>>> +       int i = 0; >>>> + >>>> +       capability = &iavf_sctx->crypto_capabilities[i]; >>>> + >>>> +       while (capability->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { >>>> +               if (capability->op == RTE_CRYPTO_OP_TYPE_SYMMETRIC && >>>> +                       capability->sym.xform_type == type && >>>> +                       capability->sym.cipher.algo == algo) >>>> +                       return &capability->sym; >>>> +               /** try next capability */ >>>> +               capability = &iavf_crypto_capabilities[i++]; >>>> +       } >>>> + >>>> +       return NULL; >>>> +} >>> >>> As of cc13af13c8e6 ("net/ngbe: support Tx done cleanup"), next-net >>> build is still KO for Windows: >>> http://mails.dpdk.org/archives/test-report/2021-October/236938.html >>> >>> FAILED: drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj >>> "clang" "-Idrivers\libtmp_rte_net_iavf.a.p" "-Idrivers" "-I..\drivers" >>> "-Idrivers\net\iavf" "-I..\drivers\net\iavf" "-Idrivers\common\iavf" >>> "-I..\drivers\common\iavf" "-Ilib\ethdev" "-I..\lib\ethdev" "-I." >>> "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" >>> "-I..\lib\eal\include" "-Ilib\eal\windows\include" >>> "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" >>> "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" >>> "-Ilib\eal" "-I..\lib\eal" "-Ilib\kvargs" "-I..\lib\kvargs" >>> "-Ilib\net" "-I..\lib\net" "-Ilib\mbuf" "-I..\lib\mbuf" >>> "-Ilib\mempool" "-I..\lib\mempool" "-Ilib\ring" "-I..\lib\ring" >>> "-Ilib\metrics" "-I..\lib\metrics" "-Ilib\telemetry" >>> "-I..\lib\telemetry" "-Ilib\meter" "-I..\lib\meter" >>> "-Idrivers\bus\pci" "-I..\drivers\bus\pci" >>> "-I..\drivers\bus\pci\windows" "-Ilib\pci" "-I..\lib\pci" >>> "-Idrivers\bus\vdev" "-I..\drivers\bus\vdev" "-Ilib\security" >>> "-I..\lib\security" "-Ilib\cryptodev" "-I..\lib\cryptodev" "-Ilib\rcu" >>> "-I..\lib\rcu" "-Xclang" "-fcolor-diagnostics" "-pipe" >>> "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-Werror" "-O3" >>> "-include" "rte_config.h" "-Wextra" "-Wcast-qual" "-Wdeprecated" >>> "-Wformat" "-Wformat-nonliteral" "-Wformat-security" >>> "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" >>> "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" >>> "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" >>> "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" >>> "-D_GNU_SOURCE" "-D_WIN32_WINNT=0x0A00" "-D_CRT_SECURE_NO_WARNINGS" >>> "-march=native" "-DALLOW_EXPERIMENTAL_API" "-DALLOW_INTERNAL_API" >>> "-Wno-strict-aliasing" "-DCC_AVX2_SUPPORT" "-DCC_AVX512_SUPPORT" >>> "-DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.iavf" -MD -MQ >>> drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj -MF >>> "drivers\libtmp_rte_net_iavf.a.p\net_iavf_iavf_ipsec_crypto.c.obj.d" >>> -o drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_ipsec_crypto.c.obj >>> "-c" ../drivers/net/iavf/iavf_ipsec_crypto.c >>> ../drivers/net/iavf/iavf_ipsec_crypto.c:111:31: error: comparison of >>> integers of different signs: 'const enum rte_crypto_sym_xform_type' >>> and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] >>>                          capability->sym.xform_type == type && >>>                          ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~ >>> ../drivers/net/iavf/iavf_ipsec_crypto.c:112:32: error: comparison of >>> integers of different signs: 'const enum rte_crypto_cipher_algorithm' >>> and 'uint32_t' (aka 'unsigned int') [-Werror,-Wsign-compare] >>>                          capability->sym.cipher.algo == algo) >>>                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~ >>> 2 errors generated. >>> >>> >> >> Thanks for the report, I will update in next-net as following: >> >> diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c >> index 19e703e6895d..935f436ac4f1 100644 >> --- a/drivers/net/iavf/iavf_ipsec_crypto.c >> +++ b/drivers/net/iavf/iavf_ipsec_crypto.c >> @@ -108,8 +108,8 @@ get_capability(struct iavf_security_ctx *iavf_sctx, >> >>          while (capability->op != RTE_CRYPTO_OP_TYPE_UNDEFINED) { >>                  if (capability->op == RTE_CRYPTO_OP_TYPE_SYMMETRIC && >> -                       capability->sym.xform_type == type && >> -                       capability->sym.cipher.algo == algo) >> +                       capability->sym.xform_type == (int)type && >> +                       capability->sym.cipher.algo == (int)algo) >>                          return &capability->sym; >>                  /** try next capability */ >>                  capability = &iavf_crypto_capabilities[i++]; > > Hmm, with this some other compilers are failing with same error, > it looks like compilers can't agree on the sign of the enum. > > According standard, enum type is implementation specific > > ' > N1570 Committee Draft — April 12, 2011 ISO/IEC 9899:201x > > 6.7.2.2 Enumeration specifiers > 4 Each enumerated type shall be compatible with char, a signed integer type, or an > unsigned integer type. The choice of type is implementation-defined,128) but shall be > capable of representing the values of all the members of the enumeration. > ' > > I will cast both enum and value to 'int', although it looks ugly. Or only cast enum to 'uint32_t' as suggested by Radu.