From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 794E4D468 for ; Fri, 24 Mar 2017 15:02:04 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 24 Mar 2017 07:02:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,215,1486454400"; d="scan'208";a="1111783078" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by orsmga001.jf.intel.com with ESMTP; 24 Mar 2017 07:02:02 -0700 To: Zhiyong Yang , dev@dpdk.org References: <1487926101-4637-2-git-send-email-zhiyong.yang@intel.com> <1488539851-71009-1-git-send-email-zhiyong.yang@intel.com> Cc: bruce.richardson@intel.com From: Ferruh Yigit Message-ID: Date: Fri, 24 Mar 2017 14:02:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1488539851-71009-1-git-send-email-zhiyong.yang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/5] consistent PMD batching behaviour X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 14:02:04 -0000 On 3/3/2017 11:17 AM, Zhiyong Yang wrote: > The rte_eth_tx_burst() function in the file Rte_ethdev.h is invoked to > transmit output packets on the output queue for DPDK applications as > follows. > > static inline uint16_t > rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id, > struct rte_mbuf **tx_pkts, uint16_t nb_pkts); > > Note: The fourth parameter nb_pkts: The number of packets to transmit. > > The rte_eth_tx_burst() function returns the number of packets it actually > sent. Most of PMD drivers can support the policy "send as many packets to > transmit as possible" at the PMD level. but the few of PMDs have some sort > of artificial limits for the pkts sent successfully. For example, VHOST tx > burst size is limited to 32 packets. Some rx_burst functions have the > similar problem. The main benefit is consistent batching behavior for user > to simplify their logic and avoid misusage at the application level, there > is unified rte_eth_tx/rx_burst interface already, there is no reason for > inconsistent behaviors. > This patchset fixes it via adding wrapper function at the PMD level. > > Changes in V2: > 1. rename ixgbe, i40e and fm10k vec function XXX_xmit_pkts_vec to new name > XXX_xmit_fixed_burst_vec, new wrapper functions use original name > XXX_xmit_pkts_vec according to Bruce's suggestion. > > 2. simplify the code to avoid the if or if/else. > > Zhiyong Yang (5): > net/fm10k: remove limit of fm10k_xmit_pkts_vec burst size > net/i40e: remove limit of i40e_xmit_pkts_vec burst size > net/ixgbe: remove limit of ixgbe_xmit_pkts_vec burst size > net/vhost: remove limit of vhost TX burst size > net/vhost: remove limit of vhost RX burst size Can you please update release notes (release_17_05.rst) with this feature? This patch changes the PMD behavior for the user, that is why it would be nice to mention from this change in release notes. Also i40e_rxtx_vec_altivec.c needs to be updated in patch 2/5. You can keep Konstantin's ack in next patchset. Thanks, ferruh