From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFAF8A00BE; Fri, 11 Feb 2022 10:38:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE10F426F9; Fri, 11 Feb 2022 10:38:31 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 2615041144 for ; Fri, 11 Feb 2022 10:38:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644572310; x=1676108310; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=o+hJye28m71U5FBvMMcNSKgwA7LIm+Hpyp2rOmtK9MU=; b=eaU0pcgahFsyq0j4y1zpC6/enf9MU7o+S+J7uejC88Q25yzWkmjiiIQ2 km67Vzbs1hofYnuSh+GCnBZ3kr+W1Roekv5HAu/6O9y17DQYXtKeRbPPT h70J5Fs8/XEBIQ5BvwaY1q4j9E2ZYORAfrxWm+hinMYxGPMciqiL5dIQm ygKuuR274ZyIgotr72UjniUut58zRP6eqR2C467cNO2dUtess2926xwba ZsVc8lSVOizQQ8fiNhFYzKNG+okOHGHsIJ1rlo0Cpu2G2yopBusDxTHgn gPz/gndOiH72+CWb9ngNh+eZmTf7VT5cdqHSC/SgbEmj9Sl7Kyk+WLV7m g==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="312983039" X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="312983039" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 01:38:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208";a="774197148" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 11 Feb 2022 01:38:28 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 01:38:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 01:38:28 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 01:38:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OW7JmQAZi5lQ3um+k5evOIuJQlWtY4WX2C7Be46vMeJV9bmTTqevErBuCljryzwXghEwfp6zrkhQvhaW+ipo7bZYZ58D26SOoefo0Gf7UWIE9Eai3F5NpNzb/BVNzOObFF2xVf/R49PFVQ9jZuKtlxkIOp+EtwMkTTdQtAxK6/lR1whhVDyiujtuZnU0FJNib94k2nZGR3bgd19+HAKyL9LsZnwz2nm5nR9DR0b2v1t1ASVyefTGOkRj7ZnKoSkIuo3DcnCGagZJhRExdKTqKxngv4LQetccdfbJtzTZ8OZUfsKcyHeZQ4mh1wm8BOg1DMJCDhpo0SG4x98U1lN4JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DwswXJNoX3vKB//Ku1pC4X7k+DUOd0O1X9kr3YO0bic=; b=R+5M0Kmdmjb+XTGaOgsJBAFersvBwyC6flRFrJg7jYgc1gHwkb2MpkxOmAZrd+xIzLE1DMu6dM4t+nrmLXDuSJVffn1GQqI6XXxgDJsPMmvbisuraCA1dGDFDUK31zUFyE4RcYhPmjFScDIhH3Unf1bhxY7wKcS62eB8Gd5IEHtGaESwszP3zTuqUbfCQVHPe5634x4D/bOMODX0aTGhzJm6aWcAsMXlD6TajnKFZZ/O+atF32lvyLLLCTTqx+5eDlQHB+t/j1e9QY6D5/I4Jg7Jeeef1Sw/I2z81NlcY1z5RXstQs2cR+mtG7/lD3/6Op6i5rKUsM60r5H7aWniQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3377.namprd11.prod.outlook.com (2603:10b6:208:66::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.14; Fri, 11 Feb 2022 09:38:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 09:38:26 +0000 Message-ID: Date: Fri, 11 Feb 2022 09:38:21 +0000 Content-Language: en-US To: Sean Zhang , , Olivier Matz CC: , Andrew Rybchenko , Ori Kam References: <20220126084404.40178-1-xiazhang@nvidia.com> <20220211014530.77711-1-xiazhang@nvidia.com> <20220211014530.77711-2-xiazhang@nvidia.com> From: Ferruh Yigit Subject: Re: [v2 1/4] lib: add optional fields in GRE header X-User: ferruhy In-Reply-To: <20220211014530.77711-2-xiazhang@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::34) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a016a584-b557-4ea5-8ae6-08d9ed4240e8 X-MS-TrafficTypeDiagnostic: BL0PR11MB3377:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UQbC6VTSxTmjzkPA8rb6lCB6BS+VCZZwQUJw9MPQ1OR5wY7QWh4Rc1D+VpxkvDX5LM/yTRz0GN7LBtCSFyqgjwIIDrYhqmaVXlDQa04yx1Gsj0W3De8hGNT0l2E4MV6KsCEBeD1CGFFiRbfRt28Y0awV4Nx6EiMt3GtdRyvXDOSYKoRu3YC5Oid6HDX2M5Q8CiM4S+LHQzFUaJCoQJVlMgrx8xuo6ncL1MS50cdSY8J+S/w1O+JQcy1VLHWRATKj8Zc72NGjt2u4hsDb91WB9sEEhRcHC9B4OPauWvcokqeg1CdV0IkD/0pbjak4bo3CqHqhrVo2gS8nsASEodTbxSleA/YWnRECXiIA0CbnWZt+SJprD+NQB9FAJzI4QBwSLPo/M3R1SfaRhLCvpzv1+wz/W9xNX+6MaIcdxQkJQpTO4VS3b4QXyokelBeiG4/B445kZVB0EYt6m9+/2Q1+hW5FJgK6vTwBOQpo2sdfw/TdLRZdz77JvGe+CHCwqB2jeuncpH+iXT7Yz29LREUUfBijMNGYmkRmCMy/gjMgG1etg8nWVK46CzjqKVj/k4d/2bmitkvmzfIosURODewnYJK7h31fvtnDLBrY5PZARsXxbNGxgeh4CQ/VKglVJtB8FRFMeTyS7T3qYCsXzbth4fnPk8fjIvaKDVZyz/DikHIAAuvPFP2VPLJJamXwvqtI5ssU0L2zEgeFxYbsE0YJaA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(36756003)(55236004)(508600001)(31686004)(53546011)(6506007)(86362001)(38100700002)(6666004)(6486002)(2906002)(316002)(6512007)(83380400001)(26005)(8676002)(66946007)(4326008)(8936002)(5660300002)(66556008)(66476007)(110136005)(54906003)(186003)(44832011)(2616005)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmJFSlVSSlYwQzk0V0FySm9oY2tDWnJrT05RZmNaS0RkWEltVGNXWm0yelJO?= =?utf-8?B?aW1OOUQxajF3UHoyY1EzZUQzRVRmdWpWSGFSbkZHeTVKdTRTcFFpSWxudk9w?= =?utf-8?B?SjNSMzdETlQyclNOZkZrTWUvcmJkTzBuSFY5QjhVby95TkFTaU91S3FMSnps?= =?utf-8?B?TkFydi9WUEJKOE5Db094UDRZczU2WjIvTktlbklodjBJRC8vNURvN3dvVWN3?= =?utf-8?B?dTlPbHVlWm9ITlNlenhEdDRHS2tOb08xcGcwdUEzeFdNYTZWME1QNG52NXQ2?= =?utf-8?B?c0tEa1J2WjRLR01EVXg4akRtazlqUWRrYzdhcGhqUmFaT1BvbDFZUzRzM2Zk?= =?utf-8?B?Z1lFMTVqVkhRTjJ6R3c1VmR4Q0NZc2xkQWt4bTNaa09PdmhoZUtYY3ZIaWZz?= =?utf-8?B?M0hndGJpaUprVnJxaVgzbzlMQXU2TjdZUFJaYXQ2YmlGUU4vblhDSGVlcCsz?= =?utf-8?B?MG1LKzFoRDFqbmVBbXI1V29LQWV5ZkdOZldBZFFHM2daZkk3S0pBT1ZhUEt2?= =?utf-8?B?U0UwNEg2enY4UHIyUCtEZHRXc3ZMRUdKa1N2SFZ6U2RxTktVYW9Zd2VKd3Fj?= =?utf-8?B?TlZhMlYyeDVBdFZRcHI0aHFld0N1Qk9kbEpOZEJMVkhzTU0yYzZWZzFmQnNQ?= =?utf-8?B?ODFtVkdwQUFnQndsQnY0a0x2dEdkeUxxeGdDWjhsNU1VYnZ4c0tZcDFWajY1?= =?utf-8?B?b1I2VXJzMXlCeFpCdnAyT1l4SFlUSVFpWUpGU2c2SitNUXl3MEt6clN2SS9q?= =?utf-8?B?Rm0vNXBFcEhsbmlzd0Rlb3RPWjBjZzNXU1o1SGR3U0IyOHphQ2RRTDRUOE5t?= =?utf-8?B?bEttSXNMWTdZc0hMelE1blBPVjJMejVSR3R0ajJFclpmcERIS1NXbUh6Z0p0?= =?utf-8?B?NmVNNjZFdG45WTVKWVRPNEFhajNEMDZmOE1QUTh5bFhxWHpxQzNaVnJaUVl5?= =?utf-8?B?SjV5emk2MzI2blMwdlRqdXZlRUFQZUdKVFJ2TVZiek51UzB6K1VIRlFjN1Nn?= =?utf-8?B?Z25oWjBzV1FCcmY3VzRkeHhEV3dLVHc4U3A5bFRDNDZlVnhPUWRtVk9YY1NK?= =?utf-8?B?ek9rZjFrSzl2UUlGOEFRSmp0bkN0ZzF3WEJCM0dpczlwdE9BbGVscDllQS9I?= =?utf-8?B?QUZnTnVXL096VUJxa210emRvWldCM0ltYitvVXZmQ2k5U1lFODlwWjNCOTJ3?= =?utf-8?B?YnZ6Zi83Slg3VEtlcWNUNzIzRkZFSzU2Q1hERFEvV3VxclMzNlhKcnpWQVZU?= =?utf-8?B?RnpXZHBudGlYc3l0UklyL1Z2WHNCRjJ2OU9YTjdPa0lrQ1RJQ3JoV1VlekNp?= =?utf-8?B?bndDRDdtOWhCZEdBendMdzdnNzVWSWxLYUdicjhJTFgxK3ZOUEdKMXRhRWpH?= =?utf-8?B?VjhmZ0c0a2VyVEFQVmd2eFdLL1NBdEw0dXViTU5UMmZyTmFHRFpmUG1ETS91?= =?utf-8?B?WDgxKzhNQWFId09DRStGYzM3WkliUTUvRW1TWms2NE9RUk5jWTBSMHdUMWwr?= =?utf-8?B?ODQrVkljbk4zcGU5N3pQY1l6c1VQZzd0NWl4bnRQMjcrcTBjSENOZGh5Vkdl?= =?utf-8?B?MGEvc2ozV0g0Zzk3ckJKelFheVVORlR0MzQrUi9rc1BJRE1QWktDQys1MnpL?= =?utf-8?B?ZzJ1ZWJLRzBjT0ozQ1ZiOFNlWFUvQzBVN3RNSHFiRk4xUTVpV3E3ZHNtQmlE?= =?utf-8?B?cHA5bXF6UUJCRHFTV3dRUy9GeTFMSE5JclkrRm5kZE9FalZFS0tBTzNxUmVu?= =?utf-8?B?c3pQVjZNMjlYT3ZrUGJkeXdRSGtVYkJHa1hyYjd2aU1jRWRJWmRFU010cUZK?= =?utf-8?B?TVBsOVNtbHdkYW9HSHdVK1Rxb3QrVEpTRk9wTUxJekp4c25rVWZ4WWJkc1lS?= =?utf-8?B?ajZwbW5TenpMejdsd2F4NHhxMGc4NXJwL2hCMnBYQTIvd0lKVEliL29ReFdN?= =?utf-8?B?SzZVcnVlWW5wVGZJeVpJSk4xbGZ5MG00cDVHQTJQZXM4SmFHNHRrYytoUWli?= =?utf-8?B?bklvY1JKWVFHUFlsdW5ybXJDZC9IMG4vWGdsdWFsaCtyRk9EellIUmU2QlBv?= =?utf-8?B?SmQ3RE9BcmtxbFFJeFBlem54Y05kTnU2dGVDaFY3QThJVURRMEdEM0thSnFK?= =?utf-8?B?L3Z0TkR4QjJPd0kxTkRpcTE1eHhKM1RQb0pnby8vdGhDNkwyUC9haXM1cU8y?= =?utf-8?Q?Cb+AcInGrGm66JxeBBCWPnk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a016a584-b557-4ea5-8ae6-08d9ed4240e8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 09:38:26.4272 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /OtOJEOzIaaCOIMJ0V1gvAlxZ/D3jbkefWep5iU2KlPnMs3rxiRk8t3Dpb56v9P1bcHfxVyoVhW6XhyzMnABeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3377 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/11/2022 1:45 AM, Sean Zhang wrote: > There are optional fields in GRE header(checksum/key/sequence), this > patch adds definition of structures of the optional fields. > > Signed-off-by: Sean Zhang > --- > lib/net/rte_gre.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/net/rte_gre.h b/lib/net/rte_gre.h > index 5897756..6c6aef6 100644 > --- a/lib/net/rte_gre.h > +++ b/lib/net/rte_gre.h > @@ -48,6 +48,28 @@ struct rte_gre_hdr { > uint16_t proto; /**< Protocol Type */ > } __rte_packed; > > +/** > + * Optional field checksum in GRE header > + */ > +struct rte_gre_hdr_opt_checksum_rsvd { > + rte_be16_t checksum; > + rte_be16_t reserved1; Can you please explain why this reserved field is added, I guess it i not part of the GRE spec, but added for mlx driver? Since these struts will be public, we can't update them later easily, so we should be careful on them. > +} __rte_packed; > + > +/** > + * Optional field key in GRE header > + */ > +struct rte_gre_hdr_opt_key { > + rte_be32_t key; > +} __rte_packed; > + > +/** > + * Optional field sequence in GRE header > + */ > +struct rte_gre_hdr_opt_sequence { > + rte_be32_t sequence; > +} __rte_packed; > + > #ifdef __cplusplus > } > #endif