From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1565A45822;
	Tue, 20 Aug 2024 15:43:03 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 93BCF4025F;
	Tue, 20 Aug 2024 15:43:02 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id 8E7B3400D6
 for <dev@dpdk.org>; Tue, 20 Aug 2024 15:43:00 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F353CDA7;
 Tue, 20 Aug 2024 06:43:25 -0700 (PDT)
Received: from [10.1.36.41] (e132423.arm.com [10.1.36.41])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9901A3F66E;
 Tue, 20 Aug 2024 06:42:58 -0700 (PDT)
Message-ID: <b326ba80-0bef-498a-92f5-549d72b8e10f@arm.com>
Date: Tue, 20 Aug 2024 14:42:56 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 4/4] test-pmd: add more packet verbose decode options
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Ori Kam <orika@nvidia.com>, Aman Singh <aman.deep.singh@intel.com>,
 Luca.Vizzarro@arm.com, Paul.Szczepanek@arm.com
References: <20240312220129.70667-1-stephen@networkplumber.org>
 <20240802195824.1336603-1-stephen@networkplumber.org>
 <20240802195824.1336603-5-stephen@networkplumber.org>
Content-Language: en-US
From: Alex Chapman <alex.chapman@arm.com>
In-Reply-To: <20240802195824.1336603-5-stephen@networkplumber.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Stephen,

I have gone through your patch series and the hexdump option would be 
quite valuable for use in DTS.

However I am currently facing the issue of distinguishing noise packets 
from intentional packets within the verbose output. Prior to your patch, 
the intention was to use the Layer 4 port to distinguish between them, 
however with the hexdump option, the plan is to now use a custom payload.

The one issue is that with verbose level 5 does not print the required 
RSS hash and RSS queue information.

Would it be possible for you to add this to your patch series? 
Otherwise, do you have any ideas and/or solutions to tackle this 
specific problem?

On 8/2/24 20:56, Stephen Hemminger wrote:
<snip>
> +static uint16_t
> +dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[],
> +	      uint16_t nb_pkts, int is_rx)
> +{
> +	if (unlikely(nb_pkts == 0))
> +		return 0;
> +
> +	switch (verbose_level) {
> +	case VERBOSE_RX ... VERBOSE_BOTH:
> +		dump_pkt_verbose(port_id, queue, pkts, nb_pkts, is_rx);
> +		break;
> +	case VERBOSE_DISSECT:
> +		dump_pkt_brief(port_id, queue, pkts, nb_pkts, is_rx);
> +		break;
> +	case VERBOSE_HEX:
> +		dump_pkt_hex(pkts, nb_pkts);
> +	}
> +	fflush(stdout);
> +	return nb_pkts;
> +}

I have identified the function above that would require altering in 
order to accommodate the additional RSS information.

Thanks,
Alex