From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0065.outbound.protection.outlook.com [104.47.38.65]) by dpdk.org (Postfix) with ESMTP id BAF891B53 for ; Thu, 23 Mar 2017 11:38:50 +0100 (CET) Received: from BN3PR0301CA0005.namprd03.prod.outlook.com (10.160.180.143) by BN6PR03MB2786.namprd03.prod.outlook.com (10.173.144.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11; Thu, 23 Mar 2017 10:38:50 +0000 Received: from BY2FFO11FD011.protection.gbl (2a01:111:f400:7c0c::175) by BN3PR0301CA0005.outlook.office365.com (2a01:111:e400:4000::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14 via Frontend Transport; Thu, 23 Mar 2017 10:38:49 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD011.mail.protection.outlook.com (10.1.14.129) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Thu, 23 Mar 2017 10:38:48 +0000 Received: from [127.0.0.1] ([10.232.40.199]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2NAcdVj032744; Thu, 23 Mar 2017 03:38:46 -0700 To: Sergio Gonzalez Monroy , References: <20170317084510.2120-1-akhil.goyal@nxp.com> <20170323080648.7149-1-akhil.goyal@nxp.com> <20170323080648.7149-2-akhil.goyal@nxp.com> <1db2a8d1-e59c-b4ae-7496-6b59e28adba3@intel.com> CC: , , , From: Akhil Goyal Message-ID: Date: Thu, 23 Mar 2017 16:08:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1db2a8d1-e59c-b4ae-7496-6b59e28adba3@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131347391291275176; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39840400002)(39410400002)(39400400002)(39850400002)(39450400003)(39380400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(377454003)(199003)(24454002)(189002)(9170700003)(31686004)(50986999)(76176999)(6666003)(33646002)(120886001)(86362001)(229853002)(81166006)(2950100002)(65826007)(106466001)(53546009)(7126002)(65956001)(64126003)(8676002)(6246003)(47776003)(50466002)(54356999)(38730400002)(105606002)(65806001)(83506001)(77096006)(85426001)(4001350100001)(93886004)(53936002)(104016004)(5660300001)(2906002)(8656002)(8936002)(54906002)(4326008)(356003)(7246003)(305945005)(575784001)(23746002)(36756003)(230700001)(5890100001)(31696002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2786; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD011; 1:w4z2j3pQTArjLbMxYvrfFBVOTbPU+3s8Qk38vitoBqq7vQqpFdF8mPif6ocTh+Qmv10gBl+4WllBbgIIsyDO/vYieKSG57U5g4BZbXx75GLuo1GWeq+YpZN9gIYwsVQgJuBMxrF3OF6AvmfyRfjNQ/LvOB7qNvc73FJ/vfpoo7eCvBPCzmgidPPeRW4I7vaNoLzvfSBUq9m1JTUBh2ikmgohP4EQpyWbvqgHOK1tWRjKAsBZX6jjy3aQLgLe7nCG0eIY+Z5gXQSTbqw0rjpCnpiKg/o4QQ+VDDbPrX62kFtGgUt++uLMZQGiX46VXRhYlmeXGh6caBx5j45/wfXrcwA/Hc5WWisNyJwvovsgrwJoRz9czPHQFvSI9g805eCmKXVutMZzTUcGk4P6I5Ki21OCSWxGqRXMFYCpuPM+OULO5DESouHWtYvYl6mjxjzJbeNVad2LaPaMhe5kofM4Z7MziLUTNT2EtelmG0qng+hDbXYx1+WTM1Zn72bGMTcImU1/8p+sRnOHgkNYk1wXmk4MB5rsU2VCUD5SDIK+XpZZwwEiVtHaxMv00N/D0spRKbM2HpwLeKQG+SAzWwOTjoyiNuIzpBn10YUHVESCeYk6h9538DDIuKytPR0LEwKi X-MS-Office365-Filtering-Correlation-Id: e8c383d7-e5b3-48ea-d647-08d471d8ca8b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2786; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2786; 3:s0ROjaRYwdbbeFxOI35SMbt3GJqDrrz6VeGq0SQBTorgHbr7TB5WlOL4e8HhSetjvX7vALDUpC9Qtzd8SsJzWkuevLqkgk+t/sM+cXkJxQKJMDYvRMs/MgEVyPAwKpQwJPLoOsuyxT0fRI9VUROz98eBjD0Xf8ZyYi4SwvuI4Tk4f2Fg1m9UuWJX3s+wBvyTf0/TJTbIm6Dhskr3xa0PNTClL9fXs7ar2lBo4Q20gnqFor8G1E6iQzfiUZvIYJjdznejgt8pnCuLEwPq8M3rYsOB616Vqa3hq94LuAs6Vrh6fpu8qkxB0RAse/62X14p2GBPhROw5UGhmZ1niUoupxPOpV76CcvpuRPCdi8XfWDY6jJD1QeQTfXYS9GN6E/a; 25:pee2dyAx+7SuE1doVScyaqZw8ObPQ00wZb8s9VExfQfdos57HYRbtkn4wNT9RE/GAsJMme+akJRbTkUiw1gkc2aVQyz8J60Z/i7nHmAU/P4BLo7XBaYyGznG3ndA1pQFk+BNAVobruMotSt3sOt+/HchipFEovJiiarGv43Me9hqU0nat6lU4W2nnN+p6Kn3Hda3FV5YjxPQNNdyILtG3sU/PPh2MjlD9T4+DPRqg+kV3rewZSBtvg28nyN3yUNmyZnwNBm7bKofuXt2naQPmUGB3rQUCyFg4S9BAZ5LaIhHKk1LXztc9T3QLAQI4z9gbTXCdC6ns+XBWM834N1GqWOG13nc5dt5oqiDlpTxMrAyLtyeNAh2rSywGyAm6HbVoGoKbJ6zhia1U65MglxhfA6IlI1YznNt6X8REjtsGNAk+sktTjpRrUVWA1kQQTy/htD1ptCrjymRSr3RE76iHQ== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2786; 31:4UiQvGRZUrKJot/cbZ/ASWUMP1ynAUL04smGQQTXcOmsElfJ1rxRkmZSIz3LyAgB2kes/ZptdhY1blUB2+l3sC/PKrVL9VyRz81PPJF1Ya39NCfXBlf1qb0nlvPb5nDiuCeHIaMVUrzKwPZh+uzABmw1w/sPDcuBmC4I/41lSNyhj0h0KSuyGS/hSElKcmnDejURfjsH7BdVCnmr4Cqc/i6d/NMgPZ0LmYaveSBN1ahaZzDRBd2QU8K5T2newnHaGjasG2LNjcRErdiRHmQphg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(13017025)(13023025)(8121501046)(13024025)(13015025)(5005006)(10201501046)(3002001)(6055026)(6096035)(20161123559025)(20161123565025)(20161123561025)(20161123556025)(20161123563025); SRVR:BN6PR03MB2786; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2786; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2786; 4:goMmsZKwtrlDMDwOuFVxsiB2CUwlqMJuV6Ng9JTE9lcOJTo4JNuHAFzlwl4UW96ZV6Ee1yWb37Q+lcTqzWC+4zNxqiIIBba8UrCI/FDNObSuSbldaHznkeNNVEQHCokwrQEjjlaYz7vNiC25MOo54Xg67ze7XK+b19uVlU9EXI28MLdE/5FniyTjmuw3523eqQhaykGgZu9SAFxBPShDhifBZTviM5ideB3MVacAoJsmCmLH45RVHGvBSB8KQ+oOo2Bi6RBammINKyCkXFlxgH9PQwrNYRTBt1yvYyykQuD3hHgHf5utzuOBL580omp8tcSd2HY+CGk+//JbseMFg80QGoCESFuL5//Mql1hjnCp7LRhhBERdO/pE3o3I0WKyCEhgc9BBDC57Odh3unKxGqgmBZcW2pxfX6ALkmQjjcAdmxOOBzHZ1FPOt+A01sD+SKcStoars6dT2OyWV8hou1grx+s+VecqHhqFtj7RgVagf/UAQrAucAs4lYkYe73IPWlOYooZM0cG7xB+Im4vLJz+LDVs0R3iB0wl9UhalSmKrX6s6HYylwPmV21SdjJYJx29jIUaO+hzjCQlQQw7KwgmLUv8DphwETWWfTX5EnK0qLJYFT/Y87OnTLWL3/SoeEIR0YQ96vVfS42PGUHudLwZ+pCI6dsqPqKwDeEDCytVuVnvxkY72mnuFeTV/LIZk+NXFI9/Kvg14R4LQHMjuwbHo1DTc5D66goIzGh6sKoqGxabRc6cOeh1b6V8BfZLvMaKPzTCeAuojsYX7dOQg== X-Forefront-PRVS: 0255DF69B9 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2786; 23:hGf0R3iC7j91B5YoYNZTyv89Endg2E93QQ7+4?= =?Windows-1252?Q?7OxVmg5QF1KSwz3SJAWQTR6TWJYl2SuaerqpRwX9yZqeiElQ19A5RlnO?= =?Windows-1252?Q?zi0kN+K/kyziHjAMP76oxH0Vae4hZ1OKM2aDiJoWkQ3dQx/WmNAybI3O?= =?Windows-1252?Q?xUOuJ89I78D1TOlo5VSDcJYYoFIgdNGe2g+6rNgFFyF45TP7uqDVX1bj?= =?Windows-1252?Q?ncHmmKwLaBzOY7azp7ofsZ0kru9jAaTrvHLk9cL8CRxqCxFL5jk7+KoG?= =?Windows-1252?Q?2/B9DQg+tgRvZLoIh4XUSPVZw3SHyZn0+mg2doCc23/KOwKOLsHRfb5F?= =?Windows-1252?Q?PRi+5h9WZLYMqmmvO393Hq1+25qvClFUemC4XS5iMPR1mM8SHCEOt7n3?= =?Windows-1252?Q?/xRcGrcMUGDCOe1BMFCEPMA5hnWdVANeH8CGymApMAcSQOIoSnrBbNC1?= =?Windows-1252?Q?FgX8wZQdNrlcIDhdVmQVFV7+vN16Ak2Luiuge5c+i90RuexcqdABjciS?= =?Windows-1252?Q?AMjqTHpIodJxgBZG9c6M9PL8D2KmRWFOSr5c2H2tSqTcRqsU2wqb+yOR?= =?Windows-1252?Q?T0NPLr3BWql0iccIjzs9YHjJLGwmYUCs/vxoXFYJhqSgVmKBjMY21djt?= =?Windows-1252?Q?IhFwGuiXHPEFk4gmiejwd4Tj/gBJPrcKou8zP/jNAAtW/DYL8AtA+aLz?= =?Windows-1252?Q?Mguun1CshQuZdxbwgHbHsAg29U1dnxfxuAe4ixt65hm/nZ6L4WmN3Rd6?= =?Windows-1252?Q?zgKP9rVg+iZp5GvsdTlzv3md7p6fJ7olR++bcHtRvBasJJpMUfDosUB3?= =?Windows-1252?Q?Ci7BEVb5/gYkZzrF40TPKIRg5eYyKZ7/iduUrZ9GcSHKtmDyCHiFLlGO?= =?Windows-1252?Q?45jvlsglPN4uvg0aGv1cIoZkMV3DeM9hAQcSP4OcE1YAh8EvH+qrPN+Q?= =?Windows-1252?Q?oRhlBCE0dQ6T5hned7Z4F23Aah1R8h6oR1fcbqdFUbt+zSQ6ydY/ssdf?= =?Windows-1252?Q?eL7MJ3q6IgIoOZ12DBLeBl0SroGOAF8rKlTVsFJynGtZcsSGa3OGJC6E?= =?Windows-1252?Q?Z3jHPfHp9FjhVw/HuxzxvnobSfDtM1H8uU2zbzb9c/V8irI82qMftUvZ?= =?Windows-1252?Q?KtAq13clOMPM0P37SzftE0jE8xb2xOAj5caYJU/d2eOjJCvjQ3Hgy7Ek?= =?Windows-1252?Q?JxyeNX1KjvWfhol6qAi2P2wowWQ9ycuq49uAKQFgHJWrnPs6RgPLrW5B?= =?Windows-1252?Q?vGfIuqBYo/wt4utCl66FF5K7nF9UeNgPAtV50X6OpiRFVKKIkxuxmMED?= =?Windows-1252?Q?2G0HJuBrBAlK0uiH61AE7Ah0K8MSCuSROr0ZrxiFBiDodLyWGGa9SlAq?= =?Windows-1252?Q?qxz7IBY/gP6g44B21Y6nGS7zDkkRYUQx6nXUGq3NM8bRWoC14dKml1eV?= =?Windows-1252?Q?bJyl/Gc73TmMJzs6UpgCpXbtYOwRP1Sk9S/RrPLxvLRow8OQ0lzeZRET?= =?Windows-1252?Q?mPm4Vb7Efp490dZAyYyW0K5j8+UMHnFnJ2O+Q483S4YPv58lmqTvkq42?= =?Windows-1252?Q?ce4/2O0Tpl+XojMNA7ONJitqRYrGNNh74FkE7A8syO1cb4ImReffWIDL?= =?Windows-1252?Q?orleNJR2ox1RghRN+BXEzMuWSjEoPi9fc/YxdD+eG3LUX/FORCl72Y4c?= =?Windows-1252?Q?Q3DRFCECcOZehwhCqtwFDz7eqXXIxcNjRUn2E8qHIjM5M2Dt1ES?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2786; 6:7UJi2PIdGHRWzMHTkqTpumdjfRMxCf5UfkVAB4bpM4w2Ys23p7SVjmKQHB2NgLahVomSzvdtx6bUgSBSBG7Sk/0rz/VjgJ+UhF4DR4aqAtZ3u95RPExgQf2G1b+F9XD7bUZEUNOBOfjjlaOuWBvPMVsCuHGsO+kqf8qgaBASFhcszTuTjUOCjSTbpa+A7uibgr/CeDSx/VJN0IKwaNrivanHajfnqoCuc5FHO1f3aRIXm8xjSTeCq6ZmXISA6JRrU6uNrNs972OSz4weQXsgaOzqQwK71QrUScF7mVB+aocf/rFfn9bEvuMKZo04Lz96+2xLgBh2HANixYDQnWsUvkAtRg1xqtkwueH2IJl2U6LDo4WXyKBPoX0+ur8x6K7DI0ZwUfFey5RLjEUC91mvgi4qmR+WP9v5PRdY2O1ZqNA=; 5:7lrAw+5f5+bCcFPun4xCRetBmL8YaLL7pyB7nsjE3jT1ZcwaDx8hr27PfxJC1kji6/BxQp3HIe92sYT0x5L9XBlA6SvUiHbJAtnASZnn3WLdQklzanaf+gigNpQpiiFbnuX9OZSOnAwlN3w7Kw7l0MOv1HYM3bOg9I7t5EIGsVnPG+JLSwW4LEO640Hllsug; 24:ZwQTCgv1aGuFslwyP5dQ21ub2qApzXSq1gTywxpBNS2zz7pjoWLT2L9+UMWAgjn1xJ2hVdUT8exdP4/tDzjPoBQxvDcfzHYHYOco7KlertI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2786; 7:U5VzWWvdt2jeafup2MCzaOkfDZD2ob2RN28Kr5eA9Dk4ZssXXdJLuWbli1362n1e/qFKOu5PYzwBc0VpOPFWvyAVuZYYh4hXlDtLQc+feY0qkJqgUrR5QDiPYwEZFV5YSNqfE6eafA8QeuBQgHX0xjhbE+a8qKRGKuCsJSNxPFEx5VAXxdntqkieBuGGe4M6+RtzlrccCsfA4cDVfxg62RKMzy6QLISM8XzpFoRXqPSswKr6sJ5SQWwmam1x5r6oiY3XyNpQq1WEJxNBI/y+zYWkljhmEt93vWBd4RU3qONwbaGeqnpfae3BdSneLttR4ukRNGsWixc47wDYs7v8DA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2017 10:38:48.8779 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2786 Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 10:38:51 -0000 On 3/23/2017 4:00 PM, Sergio Gonzalez Monroy wrote: > That was simpler than I thought. > > For some reason I understood that the device will support thousands of > queues and single session per queue which would have needed more app > changes. > > On 23/03/2017 08:06, akhil.goyal@nxp.com wrote: >> From: Akhil Goyal >> >> adding support for attaching session to queue pairs. >> This is required as underlying crypto driver may only >> support limited number of sessions per queue pair >> if max_nb_sessions_per_qp > 0, session should be >> attached to a particular qp. >> >> Signed-off-by: Akhil Goyal >> --- >> examples/ipsec-secgw/ipsec.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c >> index 144f0aa..b35b30f 100644 >> --- a/examples/ipsec-secgw/ipsec.c >> +++ b/examples/ipsec-secgw/ipsec.c >> @@ -47,6 +47,7 @@ >> static inline int >> create_session(struct ipsec_ctx *ipsec_ctx __rte_unused, struct >> ipsec_sa *sa) >> { >> + struct rte_cryptodev_info cdev_info; >> unsigned long cdev_id_qp = 0; >> int32_t ret; >> struct cdev_key key = { 0 }; >> @@ -73,6 +74,17 @@ create_session(struct ipsec_ctx *ipsec_ctx >> __rte_unused, struct ipsec_sa *sa) >> sa->crypto_session = rte_cryptodev_sym_session_create( >> ipsec_ctx->tbl[cdev_id_qp].id, sa->xforms); >> + rte_cryptodev_info_get(ipsec_ctx->tbl[cdev_id_qp].id, &cdev_info); >> + if (cdev_info.sym.max_nb_sessions_per_qp > 0) { >> + ret = rte_cryptodev_queue_pair_attach_sym_session( >> + ipsec_ctx->tbl[cdev_id_qp].qp, >> + sa->crypto_session); >> + if (ret < 0) { >> + RTE_LOG(ERR, IPSEC, "Session cannot be attached" >> + " to qp %u ", ipsec_ctx->tbl[cdev_id_qp].qp); > > Guideline is to keep error strings in single line to facilitate grep. > Other than that: > > Acked-by: Sergio Gonzalez Monroy > >> + return -1; >> + } >> + } >> sa->cdev_id_qp = cdev_id_qp; >> return 0; > > > Hi Sergio, Similar error string is mentioned above my change also in the same function. I deliberately did that as per the error strings in the file. Thanks, Akhil