From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 586B71B03F for <dev@dpdk.org>; Fri, 19 Jan 2018 18:33:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 09:33:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,382,1511856000"; d="scan'208";a="11559404" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2018 09:33:55 -0800 To: Xiao Wang <xiao.w.wang@intel.com>, yliu@fridaylinux.org, olivier.matz@6wind.com, maxime.coquelin@redhat.com, Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, thomas@monjalon.net, tiwei.bie@intel.com, stephen@networkplumber.org References: <20180110012356.57456-4-xiao.w.wang@intel.com> <20180116214103.67803-1-xiao.w.wang@intel.com> <20180116214103.67803-6-xiao.w.wang@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <b3334982-ef8b-fdb2-95b1-e904ca9c7ee0@intel.com> Date: Fri, 19 Jan 2018 17:33:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180116214103.67803-6-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 5/5] net/virtio: support GUEST ANNOUNCE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 19 Jan 2018 17:33:59 -0000 On 1/16/2018 9:41 PM, Xiao Wang wrote: > When live migration is done, for the backup VM, either the virtio > frontend or the vhost backend needs to send out gratuitous RARP packet > to announce its new network location. > > This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live > migration scenario where the vhost backend doesn't have the ability to > generate RARP packet. > > Brief introduction of the work flow: > 1. QEMU finishes live migration, pokes the backup VM with an interrupt. > 2. Virtio interrupt handler reads out the interrupt status value, and > realizes it needs to send out RARP packet to announce its location. > 3. Pause device to stop worker thread touching the queues. > 4. Inject a RARP packet into a Tx Queue. > 5. Ack the interrupt via control queue. > 6. Resume device to continue packet processing. > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Hi Yuanhan, This commit breaks the build! As far as I understand you send a fix but merged into other patch, which leaves this commit still broken. What do you think sending a fix that can be mergable to this one, so I can squash it on next-net? Thanks, ferruh