From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Július Milan" <jmilan.dev@gmail.com>
Cc: dev@dpdk.org, jgrajcia@cisco.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/memif: enable loopback
Date: Mon, 9 Mar 2020 11:14:55 +0000 [thread overview]
Message-ID: <b34cef22-2632-5d90-78cc-085534062b45@intel.com> (raw)
In-Reply-To: <20200309120905.GA22024@vbox>
On 3/9/2020 12:09 PM, Július Milan wrote:
> On Thu, Feb 27, 2020 at 04:46:09PM +0000, Ferruh Yigit wrote:
>> On 2/19/2020 8:18 AM, Július Milan wrote:
>>> With this patch it is possible to connect 2 DPDK memifs into loopback,
>>> i.e. when they have the same id and different roles, as for example:
>>> "--vdev=net_memif0,role=master,id=0"
>>> "--vdev=net_memif1,role=slave,id=0"
>>>
>>> Signed-off-by: Július Milan <jmilan.dev@gmail.com>
>>> ---
>>> drivers/net/memif/memif_socket.c | 30 ++++++++++++++----------------
>>> drivers/net/memif/rte_eth_memif.c | 1 +
>>> drivers/net/memif/rte_eth_memif.h | 1 +
>>> 3 files changed, 16 insertions(+), 16 deletions(-)
>>
>> Hi Július,
>>
>> Can you please document this new feature in the memif documentation, and it may
>> be good to give a sample testpmd commands like ones already exist in that doc?
>>
>> Thanks,
>> ferruh
>>
>
> Hi Ferruh
>
> Sure, I will send a next patch containing changes to doc/,
> not sure about the best workflow in cases like this.
>
A new version of the patchset with documentation changes would be good,
but I see you already send the doc patch separately, that is OK, I can squash it
to the commit that feature added while merging.
Thanks,
ferruh
next prev parent reply other threads:[~2020-03-09 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 8:18 Július Milan
2020-02-19 13:07 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2020-02-27 16:46 ` Ferruh Yigit
2020-03-09 12:09 ` Július Milan
2020-03-09 11:14 ` Ferruh Yigit [this message]
2020-02-27 16:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b34cef22-2632-5d90-78cc-085534062b45@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=jmilan.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).