From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 906F91B61D for ; Fri, 22 Dec 2017 23:01:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2017 14:01:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,442,1508828400"; d="scan'208";a="13984739" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.109]) ([10.241.224.109]) by FMSMGA003.fm.intel.com with ESMTP; 22 Dec 2017 14:01:46 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1512042367-6361-1-git-send-email-hemant.agrawal@nxp.com> <1512042367-6361-3-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: Date: Fri, 22 Dec 2017 14:01:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512042367-6361-3-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] kni: set initial value for MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 22:01:48 -0000 On 11/30/2017 3:46 AM, Hemant Agrawal wrote: > Configure initial application provided mtu on the KNI interface. > > Signed-off-by: Hemant Agrawal <...> > @@ -95,6 +95,7 @@ struct rte_kni_conf { > struct rte_pci_addr addr; > struct rte_pci_id id; > char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ > + uint16_t mtu; Same issue here, adding a new field into middle of the public struct. I think it would be OK to add to the end, but to be sure would you please run ABI check script (validate-abi.sh) after adding to the end? Thanks, ferruh > > __extension__ > uint8_t force_bind : 1; /* Flag to bind kernel thread */ >