Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 11/26/2019 5:02 PM, Ferruh Yigit wrote:
> On 11/26/2019 3:32 AM, Dexuan Cui wrote:
>>> From: Dexuan Cui
>>> Sent: Monday, November 25, 2019 7:29 PM
>>> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
>>> Donald_Lee@trendmicro.com
>>> Cc: stable@dpdk.org
>>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
>>>
>>>> From: Stephen Hemminger <stephen@networkplumber.org>
>>>> Sent: Monday, November 25, 2019 9:13 AM
>>>> To: dev@dpdk.org
>>>> Cc: Stephen Hemminger <stephen@networkplumber.org>;
>>> stable@dpdk.org;
>>>> Dexuan Cui <decui@microsoft.com>
>>>>
>>>> In order to change RSS parameters, the host requires that RSS
>>>> is disable first.
>>>>
>>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
>>>> Cc: stable@dpdk.org
>>>> Signed-off-by: Dexuan Cui <decui@microsoft.com>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> ---
>>>>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/drivers/net/netvsc/hn_ethdev.c
>>> b/drivers/net/netvsc/hn_ethdev.c
>>>> index 164e9ad174a7..575780ee5f26 100644
>>>> --- a/drivers/net/netvsc/hn_ethdev.c
>>>> +++ b/drivers/net/netvsc/hn_ethdev.c
>>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
>>>> *dev,
>>>>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>>>>  	}
>>>>
>>>> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +	if (err) {
>>>> +		PMD_DRV_LOG(NOTICE,
>>>> +			"rss disable failed");
>>>> +		return err;
>>>> +	}
>>>> +
>>>>  	err = hn_rndis_conf_rss(hv, 0);
>>>>  	if (err) {
>>>>  		PMD_DRV_LOG(NOTICE,
>>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
>>>> *dev)
>>>>  			return err;
>>>>  		}
>>>>
>>>> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
>>>> +		if (err) {
>>>> +			PMD_DRV_LOG(NOTICE,
>>>> +				"rss disable failed");
>>>> +			return err;
>>>> +		}
>>>> +
>>>>  		err = hn_rndis_conf_rss(hv, 0);
>>>>  		if (err) {
>>>>  			PMD_DRV_LOG(NOTICE,
>>>> --
>>>> 2.20.1
>>>
>>> Hi, Stephen,
>>> I think the patch originally came from Donald Lee (I added him to "To").
>>>
>>> IMO Donald's Signed-off-by should be added.
>>>
>>> And, can you please change my Signed-off-by to Tested-by?
>>>
>>> -- Dexuan
>>
>> Also, please add Tested-by for 
>>
>> Abhishek Marathe <abmarath@microsoft.com> (Cc'd).
> 
> Hi Stephen,
> 
> I will update this in next-net if you confirm.
> And to prevent confusion, can you please reply the tags that needs to be used?
> 

Dropping from next-net until owner of the work clarified.