From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B161A04DD; Tue, 26 Nov 2019 18:20:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95C214C90; Tue, 26 Nov 2019 18:20:05 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 11A992B88; Tue, 26 Nov 2019 18:20:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Nov 2019 09:20:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,246,1571727600"; d="scan'208";a="359224630" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga004.jf.intel.com with ESMTP; 26 Nov 2019 09:19:59 -0800 From: Ferruh Yigit To: Dexuan Cui , Stephen Hemminger , "dev@dpdk.org" , "Donald Lee (RD-TW)" Cc: "stable@dpdk.org" , Abhishek Marathe References: <8adfb064-0bd4-ead3-b5e4-0435a9e96e65@intel.com> Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 26 Nov 2019 17:19:58 +0000 MIME-Version: 1.0 In-Reply-To: <8adfb064-0bd4-ead3-b5e4-0435a9e96e65@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/26/2019 5:02 PM, Ferruh Yigit wrote: > On 11/26/2019 3:32 AM, Dexuan Cui wrote: >>> From: Dexuan Cui >>> Sent: Monday, November 25, 2019 7:29 PM >>> To: Stephen Hemminger ; dev@dpdk.org; >>> Donald_Lee@trendmicro.com >>> Cc: stable@dpdk.org >>> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters >>> >>>> From: Stephen Hemminger >>>> Sent: Monday, November 25, 2019 9:13 AM >>>> To: dev@dpdk.org >>>> Cc: Stephen Hemminger ; >>> stable@dpdk.org; >>>> Dexuan Cui >>>> >>>> In order to change RSS parameters, the host requires that RSS >>>> is disable first. >>>> >>>> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") >>>> Cc: stable@dpdk.org >>>> Signed-off-by: Dexuan Cui >>>> Signed-off-by: Stephen Hemminger >>>> --- >>>> drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> >>>> diff --git a/drivers/net/netvsc/hn_ethdev.c >>> b/drivers/net/netvsc/hn_ethdev.c >>>> index 164e9ad174a7..575780ee5f26 100644 >>>> --- a/drivers/net/netvsc/hn_ethdev.c >>>> +++ b/drivers/net/netvsc/hn_ethdev.c >>>> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev >>>> *dev, >>>> hv->rss_ind[i] = reta_conf[idx].reta[shift]; >>>> } >>>> >>>> + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); >>>> + if (err) { >>>> + PMD_DRV_LOG(NOTICE, >>>> + "rss disable failed"); >>>> + return err; >>>> + } >>>> + >>>> err = hn_rndis_conf_rss(hv, 0); >>>> if (err) { >>>> PMD_DRV_LOG(NOTICE, >>>> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev >>>> *dev) >>>> return err; >>>> } >>>> >>>> + err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE); >>>> + if (err) { >>>> + PMD_DRV_LOG(NOTICE, >>>> + "rss disable failed"); >>>> + return err; >>>> + } >>>> + >>>> err = hn_rndis_conf_rss(hv, 0); >>>> if (err) { >>>> PMD_DRV_LOG(NOTICE, >>>> -- >>>> 2.20.1 >>> >>> Hi, Stephen, >>> I think the patch originally came from Donald Lee (I added him to "To"). >>> >>> IMO Donald's Signed-off-by should be added. >>> >>> And, can you please change my Signed-off-by to Tested-by? >>> >>> -- Dexuan >> >> Also, please add Tested-by for >> >> Abhishek Marathe (Cc'd). > > Hi Stephen, > > I will update this in next-net if you confirm. > And to prevent confusion, can you please reply the tags that needs to be used? > Dropping from next-net until owner of the work clarified.