From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26C2245B52; Wed, 16 Oct 2024 18:03:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6E8340150; Wed, 16 Oct 2024 18:03:32 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id D69D4400D6 for ; Wed, 16 Oct 2024 18:03:30 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id E8F2919750 for ; Wed, 16 Oct 2024 18:03:29 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id DC6BE1974F; Wed, 16 Oct 2024 18:03:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.85] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 56FD419831; Wed, 16 Oct 2024 18:03:28 +0200 (CEST) Message-ID: Date: Wed, 16 Oct 2024 18:03:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] bitset: fix build for GCC without experimental API To: =?UTF-8?Q?Morten_Br=C3=B8rup?= , David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com, ktraynor@redhat.com, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Tyler Retzlaff References: <20241015121046.2556695-1-david.marchand@redhat.com> <20241016113817.3956187-1-david.marchand@redhat.com> <20241016113817.3956187-3-david.marchand@redhat.com> <56a2edd6-b464-47af-a56f-a8766e57cb2c@lysator.liu.se> <98CBD80474FA8B44BF855DF32C47DC35E9F7EF@smartserver.smartshare.dk> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F7EF@smartserver.smartshare.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-10-16 17:42, Morten Brørup wrote: >> From: David Marchand [mailto:david.marchand@redhat.com] >> Sent: Wednesday, 16 October 2024 17.37 >> >> On Wed, Oct 16, 2024 at 4:14 PM Mattias Rönnblom >> wrote: >>> >>> On 2024-10-16 13:38, David Marchand wrote: >>>> For a reason similar to the change on bitops header, hide bitset >>>> implementation relying on experimental API. >>>> >>>> Fixes: 99a1197647d8 ("eal: add bitset type") >>>> >>>> Signed-off-by: David Marchand >>>> Acked-by: Morten Brørup >>>> --- >>>> lib/eal/include/rte_bitset.h | 123 >> +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 123 insertions(+) >>>> >>>> diff --git a/lib/eal/include/rte_bitset.h >> b/lib/eal/include/rte_bitset.h >>>> index 74c643a72a..8ae8425fc2 100644 >>>> --- a/lib/eal/include/rte_bitset.h >>>> +++ b/lib/eal/include/rte_bitset.h >>>> @@ -255,7 +255,13 @@ __rte_experimental >>>> static inline bool >>>> rte_bitset_test(const uint64_t *bitset, size_t bit_num) >>>> { >>>> +#ifdef ALLOW_EXPERIMENTAL_API >>>> return __RTE_BITSET_DELEGATE(rte_bit_test, bitset, bit_num); >>>> +#else >>>> + RTE_SET_USED(bitset); >>>> + RTE_SET_USED(bit_num); >>>> + return false; >>> >>> This is no RTE_VERIFY(0) here, because this is just dummy code, that >>> will never be run. Is that correct? >> >> Adding a RTE_VERIFY(false) is an interesting idea. >> It is not supposed to be run, indeed. > > Great idea. > >> >> Do you prefer I respin with this? > > No need. > Instead, create a ticket in Bugzilla so RTE_VERIFY(false) goes in everywhere there is dummy code, not just here. > No experimental function is supposed to be invoked, if ALLOW_EXPERIMENTAL_API is not set, right? So RTE_VERIFY(), or its compile-time equivalent, should be in every such function, not just the broken ones. >> >> >> -- >> David Marchand >