From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 68B541B040 for ; Tue, 20 Feb 2018 16:32:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2018 07:32:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,539,1511856000"; d="scan'208";a="176687007" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.231.16]) ([163.33.231.16]) by orsmga004.jf.intel.com with ESMTP; 20 Feb 2018 07:32:51 -0800 To: Bruce Richardson References: <20180220145001.18442-1-remy.horton@intel.com> <20180220151113.GB14804@bricha3-MOBL3.ger.corp.intel.com> Cc: dev@dpdk.org From: Remy Horton Organization: Intel Shannon Limited Message-ID: Date: Tue, 20 Feb 2018 15:32:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20180220151113.GB14804@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] metrics: fix potential missing NULL termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 15:32:53 -0000 On 20/02/2018 15:11, Bruce Richardson wrote: [..] > Again, I think the better fix is to replace strncpy with snprintf which > will guarantee the null termination, unlike strncpy which is nasty that > way. OK, v2 on way..